fix: iOS Hybrid - Native share - Switching between Submit and Share causes keyboard to lose focus. by Krishna2323 · Pull Request #63741 · Expensify/App

Krishna2323 · 2025-06-09T11:13:58Z

Explanation of Change

Fixed Issues

$ #62206
PROPOSAL: #62206 (comment)

Tests

Precondition: Log in to the app
Note: Can only be tested on native app

Open the Gallery on the phone
Select a photo or receipt and share it with the app
On the share screen
Tap on the Share button and switch to the Submit button and vice versa
Verify input is focused when tab is changed

Verify that no errors appear in the JS console

Offline tests

Precondition: Log in to the app
Note: Can only be tested on native ap

Open the Gallery on the phone
Select a photo or receipt and share it with the app
On the share screen
Tap on the Share button and switch to the Submit button and vice versa
Verify input is focused when tab is changed

QA Steps

Precondition: Log in to the app
Note: Can only be tested on native app

Open the Gallery on the phone
Select a photo or receipt and share it with the app
On the share screen
Tap on the Share button and switch to the Submit button and vice versa
Verify input is focused when tab is changed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

iOS: Native

ios_native.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…auses keyboard to lose focus. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-06-09T11:36:14Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2025-06-13T11:58:36Z

@Krishna2323

Please fix the conflicts.

Krishna2323 · 2025-06-13T15:59:09Z

@c3024, I think we should hold on this issue.

c3024 · 2025-06-21T06:18:37Z

Okay. Please add it in the title.

linhvovan29546 · 2025-06-24T08:41:13Z

@Krishna2323 @c3024 #63913 (comment) Merged into the main

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…uts. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-06-24T18:31:05Z

@c3024, after merging main, the solution I initially implemented stopped working. Despite multiple attempts, I couldn’t get it to work again. I noticed that we are using onTabSelectFocusHandler in NewChatSelectorPage to handle input focus on tab selection, so I applied the same approach in ShareRootPage and it works perfectly.

App/src/pages/NewChatSelectorPage.tsx

Lines 42 to 55 in 8f00485

    
           // We're focusing the input using internal onPageSelected to fix input focus inconsistencies on native. 
        
           // More info: https://github.com/Expensify/App/issues/59388 
        
           const onTabSelectFocusHandler = ({index}: {index: number}) => { 
        
               // We runAfterInteractions since the function is called in the animate block on web-based 
        
               // implementation, this fixes an animation glitch and matches the native internal delay 
        
               InteractionManager.runAfterInteractions(() => { 
        
                   // Chat tab (0) / Room tab (1) according to OnyxTabNavigator (see below) 
        
                   if (index === 0) { 
        
                       chatPageInputRef.current?.focus(); 
        
                   } else if (index === 1) { 
        
                       roomPageInputRef.current?.focus(); 
        
                   } 
        
               }); 
        
           };

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

c3024 · 2025-06-30T07:00:20Z

With the changes to MoneyRequestParticipantsSelector, the text input autofocus behavior is broken in the standard ‘Create Expense’ flow.

Screen.Recording.2025-06-30.at.12.27.28.PM.mov

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-07-01T14:47:57Z

@c3024 ^ issue fixed

c3024 · 2025-07-04T07:07:03Z

This PR introduced a behavior where the text input should be focused only after the contact import modal is dismissed on native apps.

However, the current changes in the PR focus the input even before the modal is dismissed, resulting in unexpected behavior where the on-screen keyboard opens over the contact import modal:

Screen.Recording.2025-07-04.at.12.32.01.PM.mov

Steps to reproduce (on iOS app_:
1. Create a new account
2. Start the Create Expense flow from the FAB
3. If using a simulator, do not use the hardware keyboard — use the software keyboard
4. Tap the To field to select a participant
5. The text input gets focused and the on-screen keyboard appears, while the contact import modal remains visible in the background

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-07-04T18:24:35Z

@c3024, ^ issue fixed now:

Monosnap.screencast.2025-07-04.23-49-53.mp4

Monosnap.screencast.2025-07-04.23-52-55.mp4

c3024 · 2025-07-07T01:29:10Z

I am seeing this Not found page on create expense flow on Android. Does not seem related to this PR but it does not exist on main also. Could you merge main into this branch?

Screen.Recording.2025-07-07.at.6.57.30.AM.mov

c3024 · 2025-07-07T08:18:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

shareAndroid.mov

Android: mWeb Chrome

shareAndroidmWeb.mov

iOS: HybridApp

shareiOS.mov

iOS: mWeb Safari

shareiOSmWeb.mov

MacOS: Chrome / Safari

shareChrome.mov

MacOS: Desktop

shareDesktop.mov

c3024

LGTM!

OSBotify · 2025-07-07T21:06:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-08T21:34:00Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.1.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-10T06:52:41Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.78-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

hungvu193 · 2025-10-07T07:28:50Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

+                onFocusTextInput={() => {
+                    setTextInputAutoFocus(true);
+                    selectionListRef.current?.focusTextInput?.();
+                }}


This line causes: #70626

More details:
#70626 (comment)

Krishna2323 added 2 commits May 27, 2025 04:05

fix: iOS Hybrid - Native share - Switching between Submit and Share c…

54e2e68

…auses keyboard to lose focus. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/62206

a079969

Krishna2323 marked this pull request as ready for review June 9, 2025 11:36

Krishna2323 requested a review from a team as a code owner June 9, 2025 11:36

melvin-bot bot requested review from c3024 and removed request for a team June 9, 2025 11:36

Krishna2323 added 2 commits June 24, 2025 17:37

fix merge conflicts.

d68e95b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/62206

eaa96d9

Krishna2323 force-pushed the krishna2323/issue/62206 branch from 46476bb to eaa96d9 Compare June 24, 2025 18:09

use same approach as in NewChatSelectorPage component to focus on inp…

af4f8e3

…uts. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 changed the title ~~[Hold for PR #64207]fix: iOS Hybrid - Native share - Switching between Submit and Share causes keyboard to lose focus.~~ fix: iOS Hybrid - Native share - Switching between Submit and Share causes keyboard to lose focus. Jun 24, 2025

Krishna2323 added 2 commits June 29, 2025 20:46

Merge branch 'main' into krishna2323/issue/62206

f3327be

minor fix.

969d0b5

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 2 commits July 1, 2025 19:47

Merge branch 'Expensify:main' into krishna2323/issue/62206

e7aa433

fix autoFocus in IOURequestStepParticipants.

bf06363

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 3 commits July 4, 2025 23:09

Merge branch 'main' into krishna2323/issue/62206

d753195

fix ESLint.

fdb658e

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix autofocus when modal is open.

e467867

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/62206

bcd32d1

c3024 approved these changes Jul 7, 2025

View reviewed changes

melvin-bot bot requested a review from amyevans July 7, 2025 08:21

amyevans approved these changes Jul 7, 2025

View reviewed changes

amyevans merged commit 7f843cc into Expensify:main Jul 7, 2025
19 checks passed

github-actions bot mentioned this pull request Jul 8, 2025

Deploy Checklist: New Expensify 2025-07-08 #65687

Closed

59 tasks

melvin-bot bot mentioned this pull request Jul 10, 2025

[Due for payment 2025-07-17] [$250] iOS Hybrid - Native share - Switching between Submit and Share causes keyboard to lose focus #62206

Closed

8 tasks

hungvu193 reviewed Oct 7, 2025

View reviewed changes

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 8] Input Focus usages #83069

Open

Conversation

Krishna2323 commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 9, 2025

Uh oh!

c3024 commented Jun 13, 2025

Uh oh!

Krishna2323 commented Jun 13, 2025

Uh oh!

c3024 commented Jun 21, 2025

Uh oh!

linhvovan29546 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented Jun 24, 2025

Uh oh!

c3024 commented Jun 30, 2025

Uh oh!

Krishna2323 commented Jul 1, 2025

Uh oh!

c3024 commented Jul 4, 2025

Uh oh!

Krishna2323 commented Jul 4, 2025

Uh oh!

c3024 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 7, 2025

Uh oh!

github-actions bot commented Jul 8, 2025

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

hungvu193 Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Krishna2323 commented Jun 9, 2025 •

edited

Loading

linhvovan29546 commented Jun 24, 2025 •

edited

Loading

c3024 commented Jul 7, 2025 •

edited

Loading

c3024 commented Jul 7, 2025 •

edited

Loading