fix: contact list search field not auto focused#64207
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@linhvovan29546 The rest looks fine, please test again after your new update and ping me again. Many thanks |
|
@DylanDylann This is ready. I noticed that on Android, after closing the modal, the input is focused but the keyboard does not appear. I’ve added runAfterInteractions to address this issue. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-06-17.at.15.57.33.movAndroid: mWeb ChromeScreen.Recording.2025-06-17.at.15.54.26.moviOS: HybridAppScreen.Recording.2025-06-17.at.16.12.01.moviOS: mWeb SafariScreen.Recording.2025-06-17.at.15.53.26.movMacOS: Chrome / SafariScreen.Recording.2025-06-17.at.15.50.21.movMacOS: DesktopScreen.Recording.2025-06-17.at.15.44.36.mov |
|
@amyevans Kindly bump |
…d-not-auto-focused
amyevans
left a comment
There was a problem hiding this comment.
Apologies for the delayed review, I was OOO last week.
Thanks for the fix and the thorough testing! Just one minor suggestion for the code comment.
Co-authored-by: Amy Evans <amy@expensify.com>
|
@amyevans I've updated |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.1.71-0 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.71-11 🚀
|
Explanation of Change
This PR fixes the issue where the text input does not auto-focus on both native and web platforms:
Fixed Issues
$ #63913
PROPOSAL: #63913 (comment)
Tests
Open the ND screen.
Open the FAB and select "Create expense" > "Manual."
Enter an amount and tap "Next."
On the "Choose recipient" page:
If the permission modal appears, tap "Allow" or "Don't Allow."
Verify that after selecting either option, the text input is auto-focused.
Close the "Choose recipient" page.
Reopen the "Choose recipient" page.
Verify that the text input is auto-focused.
Verify that no errors appear in the JS console
Offline tests
Same as test above
QA Steps
Same as test above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-06-14.at.15.28.04.mov
Screen.Recording.2025-06-14.at.15.25.57.mov
Screen.Recording.2025-06-14.at.15.22.42.mov
Screen.Recording.2025-06-14.at.15.15.45.mov
Screen.Recording.2025-06-14.at.15.13.43.mov
Android: mWeb Chrome
Screen.Recording.2025-06-14.at.15.00.15.mov
iOS: Native
Screen.Recording.2025-06-14.at.15.12.02.mov
Screen.Recording.2025-06-14.at.15.02.56.mov
iOS: mWeb Safari
Screen.Recording.2025-06-14.at.14.58.18.mov
MacOS: Chrome / Safari
Screen.Recording.2025-06-14.at.14.53.22.mov
MacOS: Desktop
Screen.Recording.2025-06-14.at.14.55.59.mov