Conversation
luacmartins
force-pushed
the
cmartins-form
branch
from
4a83029 to
f5c7bef
Compare
roryabraham
requested changes
Jan 31, 2022
Contributor
roryabraham
left a comment
roryabraham
left a comment
There was a problem hiding this comment.
Other than the one remaining comment I think this is lookin' good
roryabraham
previously approved these changes
Feb 1, 2022
marcaaron
requested changes
Feb 1, 2022
…dd value decorators
Contributor
Author
|
Addressed @marcaaron latest comments. I added the decorators in |
Contributor
Author
|
Updated! |
marcaaron
approved these changes
Feb 1, 2022
roryabraham
approved these changes
Feb 1, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
8 tasks
Contributor
|
🚀 Deployed to staging by @marcaaron in version: 1.1.35-0 🚀
|
This was referenced Feb 2, 2022
Contributor
|
🚀 Deployed to production by @sketchydroide in version: 1.1.35-1 🚀
|
7 tasks
7 tasks
Contributor
|
This issue caused this bug: First field is not focused after clicking the fix the errors link on Connect Manually page ##12400 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Implements Form as instructed in the design doc.
cc @marcaaron @roryabraham would you please review?
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/193359
$ https://github.com/Expensify/Expensify/issues/193360
$ https://github.com/Expensify/Expensify/issues/193361
Tests
Run
npm run storybookPlay around with the Form stories and make sure that it works as intended. Specifically, note the following:
fix the errorslink above the submit button focus on the first input with an error.Run the app and test that TextInput still works fine.
QA Steps
Regular regression tests, looking for any weird behavior on text inputs.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android