fix: missing backTo params on split screen#64297
Merged
grgia merged 4 commits intoExpensify:mainfrom Jun 19, 2025
Merged
Conversation
a3b1c2c to
5ff99f9
Compare
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb Chrome64297-android-chrome.mp4iOS: HybridAppiOS: mWeb Safari64297-ios-safari.mp4MacOS: Chrome / Safari64297-web.mp4MacOS: Desktop64297-desktop.mp4 |
grgia
approved these changes
Jun 19, 2025
53 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.1.70-0 🚀
|
8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
3 similar comments
Contributor
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When navigating from the report RHP page to the Per Diem page, we pass the
backToparameter to the route. However, in theWorkspace Initialpage, thebackToparameter is undefined. The functiongetParamsFromRouteis used to extract parameters that match a regex and pass them to the sidebarScreen page. SincebackTois not part of the workspace initialpath, it is not included in this process, resulting in thebackToparameter being missing.App/src/libs/Navigation/AppNavigator/createSplitNavigator/SplitRouter.ts
Lines 62 to 63 in 1cd33a2
In this PR, we fixed the issue described above by adding a new configuration to accept the
backToparameter.Fixed Issues
$ #63483
PROPOSAL: #63483 (comment)
Tests
Verify the test from NAVIGATION_TESTS
Verify the test from QA steps
Verify that no errors appear in the JS console
Offline tests
Same as QA steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-06-17.at.14.01.56.mov
Android: mWeb Chrome
Screen.Recording.2025-06-17.at.14.02.31.mov
iOS: Native
Screen.Recording.2025-06-17.at.13.58.45.mov
iOS: mWeb Safari
Screen.Recording.2025-06-17.at.13.57.09.mov
MacOS: Chrome / Safari
Screen.Recording.2025-06-17.at.13.50.19.mov
MacOS: Desktop
Screen.Recording.2025-06-17.at.13.45.38.mov