[NO QA] add jest unit tests for icons to prevent regressions while refactoring#64331
Merged
[NO QA] add jest unit tests for icons to prevent regressions while refactoring#64331
Conversation
51 tasks
blimpich
requested changes
Jun 17, 2025
Contributor
There was a problem hiding this comment.
I think our convention for testing is to name the test file {NameOfFileWeAreTesting}Test. Can we keep the convention here and move these tests over to ReportUtilsTest.ts?
Contributor
Author
There was a problem hiding this comment.
@blimpich I'll remove/move these after the refactor is done this week!
Comment on lines
+478
to
+479
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| participants: { |
Contributor
There was a problem hiding this comment.
Haven't checked out the branch to double check this, but what is wrong with the word participants such that we need to add a eslint-disable-next-line @typescript-eslint/naming-convention?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
**NOTE: **
This code represents the state of our current code base. Some of these tests do not behave optimally. For example, IOU Reports. This is so I can refactor this code safely while we work on fixing avatars. I will update the broken cases when we close #62869.
Fixed Issues
Part of #64337
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
NO QA as this adds Jest Tests and does not change customer facing logic.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop