New Feature : Allow inviting new users from the card assignment dialog#64373
Closed
twilight2294 wants to merge 27 commits intoExpensify:mainfrom
Closed
New Feature : Allow inviting new users from the card assignment dialog#64373twilight2294 wants to merge 27 commits intoExpensify:mainfrom
twilight2294 wants to merge 27 commits intoExpensify:mainfrom
Conversation
51 tasks
|
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@twilight2294 please fix conflicts |
Contributor
Author
|
@allgandalf please continue with your review, I will upload the videos tomorrow morning |
Contributor
|
@twilight2294 can you start working on the latest feedback please |
Contributor
|
@twilight2294 any updates ? |
Contributor
Author
|
Working on the newly requested changes, have to do major refactor of code hence the delay |
Contributor
Author
|
There conflicts were to complex and it broke the flow, created a new PR here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #60905
PROPOSAL: #60905 (comment)
Tests
Offline tests
QA Steps
Precondition: Note that the new user which is going to get invited needs to have an already validated account.
issue cardVerify that you are able to complete the card assignment
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop