Allow removing demo transactions by DylanDylann · Pull Request #64724 · Expensify/App

DylanDylann · 2025-06-23T08:15:03Z

Explanation of Change

Fixed Issues

$ #61718
PROPOSAL: NA

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test 1

Create a sample expense request in Manager Mctest
Verify that we can delete the sample expense

Test 2

Create a sample expense request with test drive receipt
Verify that we can delete the sample expense

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-06-30.at.10.47.47.mov

iOS: Native

Screen.Recording.2025-06-30.at.10.48.08.mov

iOS: mWeb Safari

Screen.Recording.2025-06-30.at.10.45.00.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-30.at.10.40.48.mov

Screen.Recording.2025-06-30.at.10.41.57.mov

MacOS: Desktop

Screen.Recording.2025-06-30.at.10.46.10.mov

melvin-bot · 2025-06-23T08:15:09Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-06-26T07:21:21Z

@s77rt We still need to wait BE update. But I think we can process this PR in parallel to speed it up

src/libs/ReportUtils.ts

DylanDylann · 2025-06-30T03:50:02Z

The BE is updated. We are good to go here

DylanDylann · 2025-06-30T04:42:51Z

~~My Android build failed. Still trying to solve it :( @s77rt could you help to test on the Android platform?~~

My android Hybrid App build failed. I uploaded Android Newdot App video instead. @s77rt Please help to test on Hybrid Android App

s77rt · 2025-07-02T17:30:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Build issues. NAB.

Android: mWeb Chrome

mweb-chrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

s77rt · 2025-07-02T17:36:15Z

This is missing offline-first support, when you create a demo expense, the transaction should optimistically have isDemoTransaction: true

desktop.mov

DylanDylann · 2025-07-07T10:01:06Z

@s77rt Sorry, my bad, I push wrong commit

src/libs/actions/IOU.ts

s77rt · 2025-07-07T11:51:48Z

src/components/OfflineWithFeedback.tsx

        (childrenProp: React.ReactNode): React.ReactNode => {
            const strikeThroughChildren = mapChildrenFlat(childrenProp, (child) => {
-                if (!React.isValidElement(child)) {
+                if (!React.isValidElement(child) || child.type === ImageSVG) {


I think we should look into this more and fix the root cause as I don't think this is explicitly linked to SVG component

DylanDylann · 2025-07-07T14:14:59Z

I think we should look into this more and fix the root cause as I don't think this is explicitly linked to SVG component

@s77rt But we can't strike out the SVG with the current way, because SVG elements do not recognize React Native's text style properties like textDecorationLine or textDecorationStyle. If we still want to strike out the SVG, we may need to implement another solution and I think it is out of scope now. It is the reason why I disable strike-out if it is SVG component

DylanDylann · 2025-07-07T14:16:20Z

I don't think this is explicitly linked to SVG

If that, do you have any idea on this? I think it relates to SVG (as mentioned here - the paid icon) and my solution also fix this problem

s77rt · 2025-07-07T19:12:43Z

@DylanDylann I'm not saying we should strike out the svg. I'm saying we should improve the condition so we don't strike the svg and other elements that may cause the same problem. Thus we should find what's about the svg that's causing this failure and use it as the condition.

DylanDylann · 2025-07-10T17:22:39Z

@s77rt Yeah, but this issue seems not to be related so much to our core feature. Could we handle it in another issue to unblock this PR first. I believe the current way will work well and won't cause any problem

cc @grgia

s77rt · 2025-07-11T17:48:20Z

Can you please resolve conflicts

grgia

@DylanDylann could you resolve conflicts?

grgia · 2025-07-15T11:45:47Z

@s77rt Yeah, but this issue seems not to be related so much to our core feature. Could we handle it in another issue to unblock this PR first. I believe the current way will work well and won't cause any problem

@DylanDylann What's the issue we need to create?

DylanDylann · 2025-07-15T15:35:41Z

@grgia conflict is resolved

DylanDylann · 2025-07-15T15:37:00Z

@s77rt suggests improving the solution for this bug. If ok, I can help to create a new issue

OSBotify · 2025-07-15T16:08:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-16T20:24:19Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.82-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-18T04:44:43Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.82-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

allow remove demo transaction

8291b98

DylanDylann requested a review from a team as a code owner June 23, 2025 08:15

melvin-bot bot requested review from s77rt and removed request for a team June 23, 2025 08:15

DylanDylann marked this pull request as draft June 23, 2025 08:15

DylanDylann added 6 commits June 26, 2025 11:39

merge main

29b4cc7

new update

4915983

fix UTs

3ac15e6

fix lint

26d13ce

lint fix

61fe4f8

lint fix

3b09e51

DylanDylann marked this pull request as ready for review June 26, 2025 07:20

s77rt suggested changes Jun 26, 2025

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

Merge branch 'main' into allow-remove-demo-transaction

0036d68

DylanDylann added 2 commits June 30, 2025 11:03

fix UTs

f2e6363

add UTs

a8bfe26

Merge branch 'main' into allow-remove-demo-transaction

d1b4957

s77rt suggested changes Jul 2, 2025

View reviewed changes

src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx Outdated Show resolved Hide resolved

DylanDylann added 6 commits July 3, 2025 18:05

Merge branch 'main' into allow-remove-demo-transaction

c84fdd8

add optimistic data

4f08b0e

add optimistic data

eef1756

merge main

0a45574

merge main

47fdae7

lint fix

c8cbac0

s77rt suggested changes Jul 7, 2025

View reviewed changes

resolve cmt

f060c5b

Merge branch 'main' into allow-remove-demo-transaction

5786770

DylanDylann mentioned this pull request Jul 8, 2025

[Due for payment 2025-07-25] Allow fake Transactions created by us for test purposes to be deleted #61718

Closed

DylanDylann added 2 commits July 11, 2025 01:12

merge main

6817a4f

merge main

acaeff2

DylanDylann added 3 commits July 13, 2025 16:58

Merge branch 'main' into allow-remove-demo-transaction

68309d4

chore

d996a2d

chore

d57586b

s77rt approved these changes Jul 13, 2025

View reviewed changes

melvin-bot bot requested a review from grgia July 13, 2025 12:41

grgia reviewed Jul 15, 2025

View reviewed changes

Merge branch 'main' into allow-remove-demo-transaction

b632a7c

grgia approved these changes Jul 15, 2025

View reviewed changes

grgia merged commit d4f4e53 into Expensify:main Jul 15, 2025
17 checks passed

github-actions bot mentioned this pull request Jul 16, 2025

Deploy Checklist: New Expensify 2025-07-16 #66274

Closed

68 tasks

Julesssss mentioned this pull request Jul 18, 2025

Deploy Checklist: New Expensify 2025-04-29 Expensify/App-Test-Fork#56

Closed

68 tasks

ZhenjaHorbach mentioned this pull request Oct 21, 2025

[CP Staging] Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one #73041

Merged

54 tasks

Conversation

DylanDylann commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 23, 2025

Uh oh!

DylanDylann commented Jun 26, 2025

Uh oh!

Uh oh!

DylanDylann commented Jun 30, 2025

Uh oh!

DylanDylann commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

s77rt commented Jul 2, 2025

Uh oh!

DylanDylann commented Jul 7, 2025

Uh oh!

Uh oh!

s77rt Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jul 7, 2025

Uh oh!

DylanDylann commented Jul 7, 2025

Uh oh!

s77rt commented Jul 7, 2025

Uh oh!

DylanDylann commented Jul 10, 2025

Uh oh!

s77rt commented Jul 11, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Jul 15, 2025

Uh oh!

DylanDylann commented Jul 15, 2025

Uh oh!

DylanDylann commented Jul 15, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DylanDylann commented Jun 23, 2025 •

edited

Loading

DylanDylann commented Jun 30, 2025 •

edited

Loading

s77rt commented Jul 2, 2025 •

edited

Loading