[CP Staging] Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one #73041

chuckdries · 2025-10-20T23:25:41Z

Explanation of Change

This change reverts this line of #63738. ConvertTrackedExpenseToRequest and AddTrackedExpenseToPolicy both expect the reportActionID that is returned from buildOptimisticIOUReportAction to not exist yet, it's supposed to be optimistic. Both of those commands fail in their happy paths with a unique constraint violation because this function was returning an existing reportActionID rather than a fresh one.

CC @lakchote @ZhenjaHorbach @eh2077 Since y'all worked on the PR that introduced this change, would appreciate an extra pair of eyes to make sure reverting this line doesn't break any functionality that I'm not aware of

Fixed Issues

$ #72536
$ https://github.com/Expensify/Expensify/issues/555438
$ https://github.com/Expensify/Expensify/issues/555351
PROPOSAL:

Tests

AddTrackedExpenseToPolicy

Create an expense in your selfDM
Press "Submit it to someone" in the concierge whisper
Select a workspace chat
Open the network tab of your devtools
Press "Create expense"
Observe that the AddTrackedExpenseToPolicy request does not say 400 Unique Constraints Violation in the preview tab

AddTrackedExpenseToPolicy.fixed.mp4

ConvertTrackedExpenseToRequest

Create an expense in your selfDM
Press "Submit it to someone" in the concierge whisper
Select a person
Open the network tab of your devtools
Press "Create expense"
Observe that the ConvertTrackedExpenseToRequest request does not say 400 Unique Constraints Violation in the preview tab

ConvertTrackedExpenseToRequest.fixed.mp4

Split expenses flow

Note: I'm copying these instructions from the PR that introduced this bug. I performed them locally, except they mention enabling the newDotUpdateSplits beta, which I couldn't find any code at all that references that, so I skipped that step.

Navigate to an eligible expense in your reports or expenses list.
Open the More menu.
Click the Split button.
Save the splits.
Open the created split transaction.
Verify that the amount label contains the word “Split.”
Open the More menu.
Verify that “Edit splits” is displayed instead of “Split”
Click the Edit splits button or click the amount.
Verify that the split UI appears with the “Edit splits” header.
Verify that the split item from which the split expense was opened is selected.
Click on any split.
Verify that the Report menu item is displayed with the current report name (Report menu item is not editable).
Make some changes and save the splits.
Verify that the splits have been updated correctly, with messages confirming the changes to split data (amount, description, tag, etc.).

Split.flows.work.mp4

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Submit expense from selfDM to workspace, confirm that the expense actually moves

Create an expense in a selfDM
Press "Submit it to someone" in the concierge whisper
Select a workspace chat
Press "Create expense"
Observe that you're taken to the workspace and shown that the expense was moved
Go to Settings > Troubleshoot > press "Clear cache and restart"
Go back to the workspace chat and confirm that the moved expense is still there
Go back to the selfDM and confirm that the moved expense is not there

Submit expense from selfDM to another person, confirm that the expense actually moves

Create an expense in a selfDM
Press "Submit it to someone" in the concierge whisper
Select a user
Press "Create expense"
Observe that you're taken to the user's DM and shown that the expense was moved
Go to Settings > Troubleshoot > press "Clear cache and restart"
Go back to the user DM chat and confirm that the moved expense is still there
Go back to the selfDM and confirm that the moved expense is not there

Split Expenses flow

Navigate to an eligible expense in your reports or expenses list.
Open the More menu.
Click the Split button.
Save the splits.
Open the created split transaction.
Verify that the amount label contains the word “Split.”
Open the More menu.
Verify that “Edit splits” is displayed instead of “Split”
Click the Edit splits button or click the amount.
Verify that the split UI appears with the “Edit splits” header.
Verify that the split item from which the split expense was opened is selected.
Click on any split.
Verify that the Report menu item is displayed with the current report name (Report menu item is not editable).
Make some changes and save the splits.
Verify that the splits have been updated correctly, with messages confirming the changes to split data (amount, description, tag, etc.).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ID when it should generate a new one

melvin-bot · 2025-10-20T23:25:47Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-10-20T23:27:36Z

LGTM . Thank you for your hard work!

truph01 · 2025-10-21T02:41:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-23.at.01.00.59.mov

Android: mWeb Chrome

Screen.Recording.2025-10-23.at.00.57.49.mov

iOS: HybridApp

I have error when building IOS app. I will add video later once it is fixed

iOS: mWeb Safari

Screen.Recording.2025-10-23.at.00.57.01.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-23.at.00.51.35.mov

MacOS: Desktop

Screen.Recording.2025-10-23.at.00.59.41.mov

truph01 · 2025-10-21T10:01:41Z

@chuckdries we have ESLint errors, could you fix them?

truph01 · 2025-10-21T10:38:32Z

src/libs/ReportUtils.ts

        isAttachmentOnly: false,
        originalMessage,
-        reportActionID: linkedExpenseReportAction?.reportActionID ?? reportActionID ?? rand64(),
+        reportActionID: reportActionID ?? rand64(),


@chuckdries Can we apply the new change only when isMovingTransactionFromTrackExpense is true? Something like:

Suggested change

reportActionID: reportActionID ?? rand64(),

reportActionID: isMovingTransactionFromTrackExpense(action) ? rand64() : (linkedExpenseReportAction?.reportActionID ?? reportActionID ?? rand64()),

I actually would prefer to use the change I committed because it restores the behavior to what we know worked before the PR that broke it, and the functionality of that PR works fine in my testing with my change applied. Paging @ZhenjaHorbach - can you provide more insight into why you added linkedExpenseReportAction?.reportActionID ?? here, and whether it's ever necessary?

I just read the description of the issue, and yes, I think using reportActionID from linkedExpenseReportAction was a bad idea, since it affected not only the split flow
However, I believe we should still pass reportActionID from saveSplitTransactions to avoid potential issues with IOUReportActions — although, to be honest, I don’t quite remember what exactly a random reportActionID could cause

And I didn't use reportActionID since this PR was being developed in parallel with my PR, where reportActionID parameter was added

Overall, given the description @chuckdries provided and the testing that works, I believe we should be able to proceed and maintain the existing behavior before #63738.

Given it affects real customers in production, I think we want to CP it to staging and production:

chuckdries · 2025-10-21T16:44:33Z

The eslint errors are for translateLocal being deprecated, which we just added yesterday. They're irrelevant to this PR, but no PR will be allowed to modify this file until we eslint-disable each of these calls, so I'll go ahead and do that here to unblock us.

…isticIOUReportAction-improperly-reuses-reportActionID

codecov · 2025-10-21T18:30:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`74.58% <100.00%> (+0.07%)`	⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chuckdries · 2025-10-21T18:32:46Z

😮‍💨 the codecov affected lines are only counted as changes because of the eslint comments, no actual coverage changes occurred with this PR

…isticIOUReportAction-improperly-reuses-reportActionID

github-actions · 2025-10-22T14:51:49Z

LGTM . Thank you for your hard work!

github-actions · 2025-10-22T15:06:40Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-22T15:11:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73041.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://73041.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

melvin-bot · 2025-10-22T18:04:31Z

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

IuliiaHerets · 2025-10-22T20:49:05Z

Regression is completed. The issue was fixed in the current build.
No new issues were found.

lakchote · 2025-10-23T05:46:15Z

Proceeding with the merge, as we need to fix this in production as soon as possible.

OSBotify · 2025-10-23T05:59:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…UReportAction-improperly-reuses-reportActionID [CP Staging/Production] Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one (cherry picked from commit 173dee9) (cherry-picked to staging by mountiny)

OSBotify · 2025-10-23T07:14:40Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.36-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-23T07:24:48Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.36-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-10-23T07:45:39Z

@lakchote do we need to check this PR in stg build too?

lakchote · 2025-10-23T07:51:39Z

@IuliiaHerets yes please. Just do not test on Android as the build failed due to external reasons for now.

IuliiaHerets · 2025-10-23T09:09:58Z

@lakchote QA steps are passed on Desktop, Windows 10/Chrome, Android 16/Chrome and iPhone 13/iOS 18.6, build v9.2.36-6

11.12.41.mp4

az_recorder_20251023_152611.mp4

IMG_3521.MP4

2025-10-23.11.17.00.mp4

2025-10-23.11.15.25.mp4

2025-10-23.11.14.15.mp4

OSBotify · 2025-10-23T11:23:54Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.36-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-23T12:45:22Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.36-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-23T13:10:47Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-24T17:52:58Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix buildOptimisticIOUReportAction returning an existing reportAction…

b327204

…ID when it should generate a new one

chuckdries requested a review from a team as a code owner October 20, 2025 23:25

melvin-bot bot assigned chuckdries Oct 20, 2025

melvin-bot bot requested review from truph01 and removed request for a team October 20, 2025 23:25

MarioExpensify self-requested a review October 21, 2025 00:00

truph01 reviewed Oct 21, 2025

View reviewed changes

chuckdries added 2 commits October 21, 2025 09:54

Ignore existing calls to deprecated translateLocal in ReportUtils

c7d427a

Merge remote-tracking branch 'origin/main' into chuckdries/buildOptim…

b4cf9c9

…isticIOUReportAction-improperly-reuses-reportActionID

chuckdries added 2 commits October 21, 2025 11:33

Run prettier

44cb52c

Merge remote-tracking branch 'origin/main' into chuckdries/buildOptim…

4e758e1

…isticIOUReportAction-improperly-reuses-reportActionID

lakchote removed the request for review from MarioExpensify October 22, 2025 14:50

Expensify deleted a comment from github-actions bot Oct 22, 2025

lakchote changed the title ~~Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one~~ [CP Staging/Productiob] Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one Oct 22, 2025

truph01 approved these changes Oct 22, 2025

View reviewed changes

melvin-bot bot requested a review from Beamanator October 22, 2025 18:04

lakchote removed the request for review from Beamanator October 23, 2025 05:46

lakchote approved these changes Oct 23, 2025

View reviewed changes

lakchote merged commit 173dee9 into main Oct 23, 2025
32 of 33 checks passed

lakchote deleted the chuckdries/buildOptimisticIOUReportAction-improperly-reuses-reportActionID branch October 23, 2025 05:47

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 23, 2025

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-21 #73157

Closed

57 tasks

mitarachim mentioned this pull request Oct 23, 2025

[$100] Expense- When submitting expense to workspace chat from self DM, selected report is not obeyed #73292

Closed

8 tasks

jponikarchuk mentioned this pull request Oct 23, 2025

Expense - Expense report show duplicate previews of the remaining split after deleting split #73295

Closed

8 tasks

lakchote changed the title ~~[CP Staging/Production] Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one~~ [CP Staging] Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one Oct 23, 2025

melvin-bot bot mentioned this pull request Oct 23, 2025

[Due for payment 2025-10-30] Expense sent from self DM to workspace chat disappears from both chats #72536

Closed

8 tasks

rayane-d mentioned this pull request Oct 23, 2025

[$250] Track Expense - Not here page opens after clicking on the report header. #73048

Closed

8 tasks

	reportActionID: reportActionID ?? rand64(),
	reportActionID: isMovingTransactionFromTrackExpense(action) ? rand64() : (linkedExpenseReportAction?.reportActionID ?? reportActionID ?? rand64()),

[CP Staging] Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one #73041

[CP Staging] Fix buildOptimisticIOUReportAction returning an existing reportActionID when it should generate a new one #73041

Uh oh!

Conversation

chuckdries commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

AddTrackedExpenseToPolicy

ConvertTrackedExpenseToRequest

Split expenses flow

Offline tests

QA Steps

Submit expense from selfDM to workspace, confirm that the expense actually moves

Submit expense from selfDM to another person, confirm that the expense actually moves

Split Expenses flow

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

truph01 commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Oct 21, 2025

Uh oh!

truph01 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

chuckdries Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lakchote Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuckdries commented Oct 21, 2025

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chuckdries commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

melvin-bot bot commented Oct 22, 2025

Uh oh!

IuliiaHerets commented Oct 22, 2025

Uh oh!

lakchote commented Oct 23, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

IuliiaHerets commented Oct 23, 2025

Uh oh!

lakchote commented Oct 23, 2025

Uh oh!

IuliiaHerets commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

chuckdries commented Oct 20, 2025 •

edited

Loading

truph01 commented Oct 21, 2025 •

edited

Loading

ZhenjaHorbach Oct 21, 2025 •

edited

Loading

lakchote Oct 22, 2025 •

edited

Loading

codecov bot commented Oct 21, 2025 •

edited

Loading