Remove initialValue from useOnyx hook by VickyStash · Pull Request #64735 · Expensify/App

VickyStash · 2025-06-23T11:10:27Z

Explanation of Change

Remove initialValue from useOnyx hook

Fixed Issues

$ #65022
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Log in with a new account.
Start 1-1 chat with any user using FAB.
Send several messages.
Add a reaction to the message, change the reaction skin tone.
Create an expense.
Put the expense on hold -> make sure the educational modal about on hold appears.
Go to the Search page, try to apply a couple of filters.
Open Profile page, make sure it looks the same way as before.
Open Wallet page, make sure it looks the same way as before.
Create a Workspce and open it. Make sure it looks the same way as before.
Log out and login again using the same account.
Go to the expense from step 6 and make sure the educational modal about on hold doesn't appear the second time.

Offline tests

Same, as in the Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

src/components/MoneyReportHeader.tsx

VickyStash · 2025-06-24T15:28:35Z

src/components/MoneyRequestHeader.tsx

    const [isDeleteModalVisible, setIsDeleteModalVisible] = useState(false);
    const [downloadErrorModalVisible, setDownloadErrorModalVisible] = useState(false);
-    const [dismissedHoldUseExplanation, dismissedHoldUseExplanationResult] = useOnyx(ONYXKEYS.NVP_DISMISSED_HOLD_USE_EXPLANATION, {initialValue: true, canBeMissing: false});
+    const [dismissedHoldUseExplanation = true, dismissedHoldUseExplanationResult] = useOnyx(ONYXKEYS.NVP_DISMISSED_HOLD_USE_EXPLANATION, {canBeMissing: false});


Why the initial value was added here? Due to this issue: #37012

Updating the logic to use the default value creates a bug - Hold Request education modal never appears!

I've investigated it, and I think we can get rid of dismissedHoldUseExplanation initial value at all, since we have the check for isLoadingHoldUseExplained:

App/src/components/MoneyReportHeader.tsx

Lines 412 to 413 in 19b6dfa

if (isLoadingHoldUseExplained || dismissedHoldUseExplanation || !isOnHold) {

return;

When I remove initialValue it still works as expected.

src/pages/home/sidebar/SidebarLinksData.tsx

src/pages/GroupChatNameEditPage.tsx

src/hooks/useSidebarOrderedReports.tsx

src/pages/settings/Wallet/WalletPage/WalletPage.tsx

…-useOnyx

…-useOnyx # Conflicts: # src/components/SelectionList/Search/TransactionGroupListItem.tsx

…-useOnyx # Conflicts: # src/components/MoneyRequestHeader.tsx # src/pages/settings/Profile/PersonalDetails/LegalNamePage.tsx # src/pages/settings/Profile/ProfileAvatar.tsx

…-useOnyx

VickyStash · 2025-07-09T10:27:26Z

Note: I haven't resolved errors from Changed files ESLint check to not overcomplicate the PR, let me know if you agree!

melvin-bot · 2025-07-09T10:27:43Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2025-07-09T13:13:08Z

@VickyStash Does this need reviewing, just confirming based on this:

This PR is just investigation about possibility of removing initialValue from useOnyx hook

VickyStash · 2025-07-09T13:22:35Z

@VickyStash Does this need reviewing, just confirming based on this:

@alitoshmatov Yeah, this one requires review, sorry for the confusion, I've updated the description!

alitoshmatov · 2025-07-09T13:25:20Z

@VickyStash Reviewing right now, also can you resolve conflicts

…-useOnyx # Conflicts: # src/pages/Search/SearchPage.tsx

alitoshmatov · 2025-07-09T15:05:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

onyx-mweb.mov

iOS: HybridApp

onyx-ios.mp4

iOS: mWeb Safari

onyx-safari.mov

MacOS: Chrome / Safari

onyx-web-0.mov

MacOS: Desktop

onyx-desktop-0.mov

alitoshmatov

LGTM!

roryabraham

LGTM 👍🏼

I'm choosing to ignore the changed files lint for things like canBeMissing, just to maintain the low risk of this PR that changes a lot of files.

melvin-bot · 2025-07-09T16:25:29Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

roryabraham · 2025-07-09T16:25:44Z

Merging despite discussion of potential further refinements in Expensify/eslint-config-expensify#150, mostly to avoid conflicts.

Not an emergency, see previous comment

OSBotify · 2025-07-09T16:34:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-10T07:25:51Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-11T17:37:55Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Remove initialValue from useOnyx

682cf8b

VickyStash commented Jun 23, 2025

View reviewed changes

VickyStash added 3 commits June 24, 2025 15:19

Merge branch 'main' into VickyStash/refactor/remove-initialValue-from…

c3b8e0e

…-useOnyx

Merge branch 'main' into VickyStash/refactor/remove-initialValue-from…

301b499

…-useOnyx # Conflicts: # src/components/SelectionList/Search/TransactionGroupListItem.tsx

Lint and TS fixes

731dce4

roryabraham mentioned this pull request Jun 26, 2025

[Due for payment 2025-08-11] [Due for payment 2025-07-28] [Due for payment 2025-07-18] Remove the initialValue option from the useOnyx hook #65022

Closed

VickyStash added 6 commits July 8, 2025 14:31

Merge branch 'main' into VickyStash/refactor/remove-initialValue-from…

fb07a10

…-useOnyx # Conflicts: # src/components/MoneyRequestHeader.tsx # src/pages/settings/Profile/PersonalDetails/LegalNamePage.tsx # src/pages/settings/Profile/ProfileAvatar.tsx

Add stable default values references

80cff7c

Minor improvement

2e1bd9f

Remove unnecessary default value

d9230b1

Merge branch 'main' into VickyStash/refactor/remove-initialValue-from…

f938603

…-useOnyx

Fix useOnyx import

badced3

VickyStash changed the title ~~[WIP] [Investigation] Remove initialValue from useOnyx~~ [WIP] Remove initialValue from useOnyx hook Jul 9, 2025

VickyStash changed the title ~~[WIP] Remove initialValue from useOnyx hook~~ Remove initialValue from useOnyx hook Jul 9, 2025

VickyStash marked this pull request as ready for review July 9, 2025 10:27

VickyStash requested a review from a team as a code owner July 9, 2025 10:27

melvin-bot bot requested review from alitoshmatov and removed request for a team July 9, 2025 10:27

VickyStash added 2 commits July 9, 2025 15:31

Merge branch 'main' into VickyStash/refactor/remove-initialValue-from…

a5a5816

…-useOnyx # Conflicts: # src/pages/Search/SearchPage.tsx

Remove unused imports

a773a37

alitoshmatov approved these changes Jul 9, 2025

View reviewed changes

melvin-bot bot requested a review from roryabraham July 9, 2025 15:06

roryabraham approved these changes Jul 9, 2025

View reviewed changes

roryabraham merged commit 2e8b475 into Expensify:main Jul 9, 2025
18 of 19 checks passed

melvin-bot bot added the Emergency label Jul 9, 2025

roryabraham removed the Emergency label Jul 9, 2025

github-actions bot mentioned this pull request Jul 10, 2025

Deploy Checklist: New Expensify 2025-07-10 #65809

Closed

77 tasks

fabioh8010 mentioned this pull request Jul 10, 2025

[No QA] Forbid imports from src/ inside .github #65906

Merged

51 tasks

mkzie2 mentioned this pull request Jul 18, 2025

[Due for payment 2025-07-30] [$250] Drafts are cleared when moving away from a chat #66633

Closed

16 tasks

pasyukevich mentioned this pull request Feb 17, 2026

[Due for payment 2026-03-19] [Onyx Audit] Remove allowStaleData from useOnyx #80094

Closed

	if (isLoadingHoldUseExplained \|\| dismissedHoldUseExplanation \|\| !isOnHold) {
	return;

Conversation

VickyStash commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

VickyStash Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VickyStash commented Jul 9, 2025

Uh oh!

melvin-bot bot commented Jul 9, 2025

Uh oh!

alitoshmatov commented Jul 9, 2025

Uh oh!

VickyStash commented Jul 9, 2025

Uh oh!

alitoshmatov commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alitoshmatov commented Jul 9, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Jul 9, 2025

Uh oh!

roryabraham commented Jul 9, 2025

Uh oh!

OSBotify commented Jul 9, 2025

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VickyStash commented Jun 23, 2025 •

edited

Loading

alitoshmatov commented Jul 9, 2025 •

edited

Loading