Skip to content

[CP Staging] Revert "Search Autocomplete: Always Render with Loading Skeleton & add isReady focus guard"#64759

Merged
chiragsalian merged 1 commit intomainfrom
revert-63627-62335-recent-searches
Jun 23, 2025
Merged

[CP Staging] Revert "Search Autocomplete: Always Render with Loading Skeleton & add isReady focus guard"#64759
chiragsalian merged 1 commit intomainfrom
revert-63627-62335-recent-searches

Conversation

@cristipaval
Copy link
Contributor

@cristipaval cristipaval commented Jun 23, 2025 •
edited
Loading

Reverts #63627

Fixes #64678

@cristipaval cristipaval self-assigned this Jun 23, 2025
@cristipaval cristipaval requested a review from a team as a code owner June 23, 2025 18:57
@cristipaval cristipaval changed the title Revert "Search Autocomplete: Always Render with Loading Skeleton & add isReady focus guard" [CP Staging] Revert "Search Autocomplete: Always Render with Loading Skeleton & add isReady focus guard" Jun 23, 2025
@melvin-bot melvin-bot bot requested review from Gonals and removed request for a team June 23, 2025 18:58
@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2025

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chiragsalian chiragsalian merged commit 418b4b5 into main Jun 23, 2025
20 of 24 checks passed
@chiragsalian chiragsalian deleted the revert-63627-62335-recent-searches branch June 23, 2025 19:33
@melvin-bot melvin-bot bot added the Emergency label Jun 23, 2025
@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2025

@chiragsalian looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@chiragsalian
Copy link
Contributor

chiragsalian commented Jun 23, 2025

The only failed tests were author and reviewer checklist. But this is a straight revert, so not an emergency.

OSBotify pushed a commit that referenced this pull request Jun 23, 2025
@chiragsalian @OSBotify
Merge pull request #64759 from Expensify/revert-63627-62335-recent-se…
64a168f 
…arches

[CP Staging] Revert "Search Autocomplete: Always Render with Loading Skeleton & add isReady focus guard"

(cherry picked from commit 418b4b5)

(cherry-picked to staging by chiragsalian)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 23, 2025
@github-actions github-actions bot mentioned this pull request Jun 23, 2025
Closed
53 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jun 23, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 9.1.70-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

@Gonals Gonals Gonals approved these changes

Assignees

@cristipaval cristipaval

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search - Skeleton is blocked by the black area above the keyboard when keyboard is opened

4 participants

@cristipaval @chiragsalian @OSBotify @Gonals