Skip to content

[CP Staging] Revert "Use tripdata payload to get reservations setup"#64769

Merged
mountiny merged 1 commit intomainfrom
revert-63853-parasharrajat/travel-update
Jun 24, 2025
Merged

[CP Staging] Revert "Use tripdata payload to get reservations setup"#64769
mountiny merged 1 commit intomainfrom
revert-63853-parasharrajat/travel-update

Conversation

@rlinoz
Copy link
Contributor

@rlinoz rlinoz commented Jun 23, 2025 •
edited
Loading

Reverts #63853

https://expensify.slack.com/archives/C05LX9D6E07/p1750715484832909

Fixes trip preview showing NaN in the amount if child report is not loaded.

@rlinoz rlinoz marked this pull request as ready for review June 23, 2025 22:58
@rlinoz rlinoz requested a review from a team as a code owner June 23, 2025 22:58
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team June 23, 2025 22:58
@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2025

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #64769.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://64769.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@mountiny mountiny changed the title Revert "Use tripdata payload to get reservations setup" [CP Staging] Revert "Use tripdata payload to get reservations setup" Jun 24, 2025
mountiny
mountiny approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert, confirmed in slack the issue is fixed https://expensify.slack.com/archives/C05LX9D6E07/p1750723744451799?thread_ts=1750715484.832909&cid=C05LX9D6E07

@mountiny mountiny merged commit 0fa3b40 into main Jun 24, 2025
19 of 25 checks passed
@mountiny mountiny deleted the revert-63853-parasharrajat/travel-update branch June 24, 2025 00:13
@melvin-bot melvin-bot bot added the Emergency label Jun 24, 2025
@melvin-bot
Copy link

melvin-bot bot commented Jun 24, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

mountiny commented Jun 24, 2025

Straight revert

@OSBotify
Copy link
Contributor

OSBotify commented Jun 24, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jun 24, 2025
@mountiny @OSBotify
Merge pull request #64769 from Expensify/revert-63853-parasharrajat/t…
11ff1d3 
…ravel-update

[CP Staging] Revert "Use tripdata payload to get reservations setup"

(cherry picked from commit 0fa3b40)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 24, 2025
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Closed
53 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.70-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@rlinoz
Copy link
Contributor Author

rlinoz commented Jun 24, 2025

Tested here https://expensify.slack.com/archives/C05LX9D6E07/p1750725430831089?thread_ts=1750715484.832909&cid=C05LX9D6E07 and it works.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@cristipaval cristipaval Awaiting requested review from cristipaval

Assignees

No one assigned

Labels

CP Staging marks PRs that have been CP'd to staging Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlinoz @mountiny @OSBotify