Use ReanimatedModal for FULLSCREEN modals by jmusial · Pull Request #64805 · Expensify/App

jmusial · 2025-06-24T13:10:25Z

This PR uses react-native-reanimated based modal for FULLSCREEN type modals.

Same animations as in BOTTOM_DOCKED_MODAL are used (and same as FULLSCREEN was before):

SlideIn / SlideOut for native
FadeIn / FadeOut for web

Explanation of Change

Fixed Issues

$ #64777
$ #64775

PROPOSAL:

https://expensify.slack.com/archives/C05LX9D6E07/p1750147058498549

Tests

Create a new account
Enter name
Skip adding people you already know. Continue.
Select "Manage my team's expenses". Continue.
Select 1 - 10 employees. Continue.
Select "None". Continue.
Select "Start test drive"
Fullscreen test drive demo modal shows and is interactive

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

0023.android.native.mov

Android: mWeb Chrome

0023.android.chrome.mov

iOS: Native

0023.ios.native.mp4

iOS: mWeb Safari

0023.ios.native.mp4

MacOS: Chrome / Safari

0023.desktop.web.mov

MacOS: Desktop

0023.desktop.native.mov

…fullscreen modals

blazejkustra · 2025-06-24T15:02:48Z

src/components/Modal/BaseModal.tsx

+import type ModalProps from './ReanimatedModal/types';
 import type BaseModalProps from './types';

+const ReanimatedModalTypes: Array<ValueOf<typeof CONST.MODAL.MODAL_TYPE>> = [CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED, CONST.MODAL.MODAL_TYPE.FULLSCREEN];


NAB: I think we should use camelCase here or CONST_CASE instead.

melvin-bot · 2025-06-26T10:25:30Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-06-26T10:29:32Z

It's funny that random assigned me here 😅

ZhenjaHorbach · 2025-06-26T10:34:42Z

src/components/Modal/ReanimatedModal/Container/index.tsx

        >
            <Animated.View
-                style={styles.modalAnimatedContainer}
+                style={[style, styles.modalAnimatedContainer]}


Interesting
Shouldn't this lead to issues due to the fact that we use style prop both in the wrapper and in the current component ?

Haven't notice any. The reason for this was that modals that should take full height, animated view wasn't.

But I can probably do it a different way to limit potential side effects

Yeah
I can't find any issue yet either
Maybe it's okay !

Yeah, cos on the web it's just one container. AFAIR there were issues with exit animation and unmounting that's why there is an additional View on native. I pushed uglier, but more verbose way of doing it. Let me know which one you prefer :)

Have a strong feeling this will be refactored when on the next modal type anyways

I think it looks good
And since we're going to refactor this in the future
Let's leave it as is !

ZhenjaHorbach · 2025-06-26T12:41:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-06-30.18.49.17.mov

Android: mWeb Chrome

2025-06-30.18.46.58.mov

iOS: HybridApp

2025-06-30.18.37.59.mov

iOS: mWeb Safari

2025-06-30.18.34.59.mov

MacOS: Chrome / Safari

2025-06-27.19.10.53.mov

MacOS: Desktop

2025-06-30.18.26.31.mov

dubielzyk-expensify · 2025-06-27T16:47:09Z

Videos looking good so far. Let us know if you want when you want a review :)

jmusial · 2025-06-30T08:07:11Z

@dubielzyk-expensify I think it's all done from my side here (depending on @ZhenjaHorbach review ofc)

ZhenjaHorbach · 2025-06-30T08:09:05Z

@dubielzyk-expensify I think it's all done from my side here (depending on @ZhenjaHorbach review ofc)

Good on my part too !
I'lll complete the checklist today !

ZhenjaHorbach · 2025-06-30T16:28:14Z

Minor comment
But on the desktop there is no opening animation, unlike on the web, for example

Although never mind
It's probably just a coincidence and the 2nd and 3rd tries everything is fine

2025-06-30.18.26.31.mov

ZhenjaHorbach · 2025-06-30T16:57:06Z

LGTM !

mountiny

Thanks!

OSBotify · 2025-06-30T22:39:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-02T00:03:17Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.74-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-03T19:43:31Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

rename BottomDockedModal to ReanimatedModal, use ReanimatedModal for …

2fe0da7

…fullscreen modals

jmusial changed the title ~~Use ReanimatedModal for fullscreen modals~~ Use ReanimatedModal for FULLSCREEN modals Jun 24, 2025

fix lint

df56f56

blazejkustra suggested changes Jun 24, 2025

View reviewed changes

change const case

0135627

jmusial requested a review from blazejkustra June 25, 2025 07:40

blazejkustra approved these changes Jun 25, 2025

View reviewed changes

jmusial marked this pull request as ready for review June 26, 2025 10:25

jmusial requested review from a team as code owners June 26, 2025 10:25

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team June 26, 2025 10:25

ZhenjaHorbach reviewed Jun 26, 2025

View reviewed changes

refactor fullscreen modal for native

9a7101f

mountiny assigned jmusial Jun 30, 2025

jmusial mentioned this pull request Jun 30, 2025

Migrate Quickbooks and Xero flow modals to use Reanimated modal #65172

Merged

49 tasks

ZhenjaHorbach approved these changes Jun 30, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny June 30, 2025 16:57

mountiny approved these changes Jun 30, 2025

View reviewed changes

mountiny merged commit 3caba34 into Expensify:main Jun 30, 2025
19 of 21 checks passed

github-actions bot mentioned this pull request Jul 1, 2025

Deploy Checklist: New Expensify 2025-07-01 #65287

Closed

57 tasks

This was referenced Jul 3, 2025

[Due for payment 2025-07-10] Use react-native-reanimated in FULLSCREEN Modals #64777

Closed

[Due for payment 2025-12-16] [Due for payment 2025-09-26] [$250] [Tracking] Use react-native-reanimated in the ModalComponent #64775

Closed

jmusial deleted the feat/use-react-native-reanimated-in-fullscreen-modals branch August 26, 2025 08:11

Conversation

jmusial commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

blazejkustra Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jun 26, 2025

Uh oh!

ZhenjaHorbach commented Jun 26, 2025

Uh oh!

ZhenjaHorbach Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dubielzyk-expensify commented Jun 27, 2025

Uh oh!

jmusial commented Jun 30, 2025

Uh oh!

ZhenjaHorbach commented Jun 30, 2025

Uh oh!

ZhenjaHorbach commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Jun 30, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 30, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jmusial commented Jun 24, 2025 •

edited

Loading

ZhenjaHorbach Jun 30, 2025 •

edited

Loading

ZhenjaHorbach commented Jun 26, 2025 •

edited

Loading

ZhenjaHorbach commented Jun 30, 2025 •

edited

Loading