Migrate Quickbooks and Xero flow modals to use Reanimated modal by jmusial · Pull Request #65172 · Expensify/App

jmusial · 2025-06-30T09:14:31Z

Explanation of Change

This PR uses react-native-reanimated based modal for CENTERED_UNSWIPABLE type modals.

Animations used

slideInRight / slideOutRight for small screens
fadeIn / fadeOut for large screens

Fixed Issues

$ #64776
$ #64775

Depends on

#64805

PROPOSAL:

https://expensify.slack.com/archives/C05LX9D6E07/p1750147058498549

Tests

Feature Training Modal

Only on large screen devices. On small screens Feature Training Modal uses Bottom Docked, which has already beed migrated.

Log in with a new Gmail account.
Tap Skip on work email page.
Select Track and budget expenses.
Enter name > Continue.
"Take us for a test drive" modal appears correctly

Xero and QuickBooks Online Modals

Only on native devices. On desktop and web integrations open in a web browser card.

Log into an account with 2FA
Create a new workspace or use existing one with Accounting enabled
Go to Workspaces -> Your workspace -> Accounting
Click Connect on QuickBooks Online row -> Modal shows
Click Connect on Xero row -> Modal shows

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Xero & Quickbooks Online

0024.xero.quicbooks.android.native.mov

Feature Training

N/A (is another modal type)

Android: mWeb Chrome

Xero & Quickbooks Online

N/A (opens link in another browser tab)

Feature Training

N/A (is another modal type)

iOS: Native

Xero & Quickbooks Online

0024.xero.quickbooks.native.ios.mp4

Feature Training

N/A (is another modal type)

iOS: mWeb Safari

Xero & Quickbooks Online

N/A (opens link in another browser tab)

Feature Training

N/A (is another modal type)

MacOS: Chrome / Safari

Xero & Quickbooks Online

N/A (opens link in another browser tab)

Feature Training

0024.web.chrome.feature.training.mov

MacOS: Desktop

Xero & Quickbooks Online

N/A (opens link in another browser tab)

Feature Training

0024.desktop.native.feature.mov

…quickbooks-modals

blazejkustra · 2025-07-01T09:13:52Z

src/components/Modal/BaseModal.tsx

+    if (type && PARTIAL_REANIMATED_MODAL_TYPES.includes(type) && shouldUseReanimatedModal) {
+        return (
+            <ReanimatedModal
+                // eslint-disable-next-line react/jsx-props-no-spreading
+                {...(props as ReanimatedModalProps)}
+                type={type}
+            />
+        );
+    }


NAB: What if we remove PARTIAL_REANIMATED_MODAL_TYPES and just rely on shouldUseReanimatedModal?

This way we would end up with just one if:

if ((type && REANIMATED_MODAL_TYPES.includes(type)) || shouldUseReanimatedModal)

blazejkustra · 2025-07-01T09:17:46Z

src/components/Modal/ReanimatedModal/utils.ts

+        case 'fadeIn':
+        default:
+            return {
+                from: {opacity: 0},
+                to: {
+                    opacity: 0.72,
+                    easing,
+                },
+            };


NAB: Split 'fadeIn' and default to make the logic clearer and better catch unintended animation types

Suggested change

case 'fadeIn':

default:

return {

from: {opacity: 0},

to: {

opacity: 0.72,

easing,

},

};

case 'fadeIn':

return {

from: {opacity: 0},

to: {

opacity: 0.72,

easing,

},

};

default:

throw ...

blazejkustra · 2025-07-01T09:17:52Z

src/components/Modal/ReanimatedModal/utils.ts

+                },
+            };
+        case 'fadeOut':
+        default:


blazejkustra · 2025-07-01T09:18:21Z

src/components/Modal/ReanimatedModal/utils.ts

Oh this is so much cleaner, good job!

melvin-bot · 2025-07-01T09:44:58Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-07-01T16:05:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

android-web.mov

iOS: HybridApp

ios-1.mov

ios-2.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

2025-07-02.20.58.50.mov

MacOS: Desktop

2025-07-02.20.58.50.mov

ZhenjaHorbach · 2025-07-02T19:02:32Z

Noticed that when we hover over the background, instead of default cursor, we see the selection cursor (on staging we have default cursor )

…quickbooks-modals

jmusial · 2025-07-03T08:38:22Z

@ZhenjaHorbach changed

ZhenjaHorbach · 2025-07-03T11:12:38Z

@ZhenjaHorbach changed

Thanks !

Weird
When I try to open native apps
I'm stuck on splash screens

@mountiny
Could you please trigger adhoc builds ?
while I'm trying to figure out what's going on 😅

…quickbooks-modals

jmusial · 2025-07-03T11:58:55Z

@ZhenjaHorbach merged latest main. I think that should fix the "stuck on splash screens" issue

ZhenjaHorbach · 2025-07-03T14:26:14Z

Interesting issue after finishing onboarding

2025-07-03.16.23.57.mov

jmusial · 2025-07-03T15:12:25Z

Weird, I cannot reproduce it :( What IOS version is that ?

ZhenjaHorbach · 2025-07-03T15:31:23Z

Weird, I cannot reproduce it :( What IOS version is that ?

17.5 😅
But yeah
It's a bit difficult to reproduce

jmusial · 2025-07-04T07:23:04Z

Hmm... I see, are you able to get some repro steps or it was a one time glitch ?

jmusial · 2025-07-04T08:24:49Z

@ZhenjaHorbach I managed to get that behaviour, but on the main branch :(

ZhenjaHorbach · 2025-07-04T08:26:56Z

@ZhenjaHorbach I managed to get that behaviour, but on the main branch :(

Oh
Interesting
I checked it on main yesterday
And couldn't reproduce it

But in that case it's not our issue !

jmusial · 2025-07-04T08:31:08Z

I think I found repro steps. It happens for me on the first account I set up after opening a new emulator, the consecutive accounts are working fine.

Gonna check on real device.

Screen.Recording.2025-07-04.at.10.27.26.mov

jmusial · 2025-07-04T10:02:03Z

I can reproduce it on main on a real device with the same scenario. Gonna post it on slack on bugs channel.

Edit: https://swmansion.slack.com/archives/C049HHMV9SM/p1751623695654159

jmusial · 2025-07-04T10:15:39Z

@ZhenjaHorbach would be awesome if you could check the PR today, we have 3 more lined up depending on this one 😄

ZhenjaHorbach · 2025-07-04T11:01:41Z

I will complete soon !

ZhenjaHorbach · 2025-07-04T11:06:36Z

@jmusial
Do you have this issue ?
When I create a new account and when I reopen the app on splash screen
The app is not responding

2025-07-04.13.04.39.mov

ZhenjaHorbach · 2025-07-04T11:08:26Z

But actually when I press android system back button
The app starts working
So I suppose we have an open invisible modal (I'm pretty sure it's Take us for a test drive modal )

jmusial · 2025-07-04T14:01:12Z

Soo.... I think it's also on main
On android, when creating new account after finishing the onboarding flow app is unresponsive untill
Android back button press.

Can you check if you can get in on main as well ?

Screen.Recording.2025-07-04.at.15.56.57.mov

ZhenjaHorbach · 2025-07-04T14:02:18Z

Yes
Let me check

jmusial · 2025-07-04T14:06:31Z

Prod works fine.
I mean it's unlikely that this PR would cause this, since it's only changing Take us for a test drive (FutureTraining) modal for wide/medium screens. On narrow ones it's a BOTTOM_DOCKED which has been merged months ago :)

ZhenjaHorbach · 2025-07-04T14:14:08Z

Prod works fine. I mean it's unlikely that this PR would cause this, since it's only changing Take us for a test drive (FutureTraining) modal for wide/medium screens. On narrow ones it's a BOTTOM_DOCKED which has been merged months ago :)

Yeah
Looks like we need to report another bug 😅

And good point
I didn't think that this mobile modal doesn't apply to new changes

ZhenjaHorbach · 2025-07-04T14:14:16Z

In this case
LGTM !

jmusial · 2025-07-04T14:28:06Z

@ZhenjaHorbach I can post it later, unless you want it :)
Awesome job testing !

ZhenjaHorbach · 2025-07-04T14:29:30Z

@ZhenjaHorbach I can post it later, unless you want it :) Awesome job testing !

I already did it 😅

And good job !

mountiny

Nice great job on the PR and testing!

mountiny · 2025-07-04T17:18:37Z

src/components/Modal/ReanimatedModal/utils.ts

OSBotify · 2025-07-04T17:29:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-07T11:31:46Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-08T21:01:28Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.77-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

use Reanimated Modal in Xero and Quickbooks modals

c2f869c

jmusial mentioned this pull request Jun 30, 2025

[Due for payment 2025-09-02] [$1750] Use react-native-reanimated in CENTERED Modals #64776

Closed

jmusial added 5 commits June 30, 2025 11:37

Future training centered modal migration

c15785a

fix tsc

4b19fe7

Merge branch 'main' into feat/use-reac-native-reanimated-in-xero-and-…

eb0d0ff

…quickbooks-modals

Merge branch 'main' into feat/use-reac-native-reanimated-in-xero-and-…

ac5791f

…quickbooks-modals

Merge branch 'main' into feat/use-reac-native-reanimated-in-xero-and-…

7329db4

…quickbooks-modals

blazejkustra approved these changes Jul 1, 2025

View reviewed changes

jmusial marked this pull request as ready for review July 1, 2025 09:44

jmusial requested review from a team as code owners July 1, 2025 09:44

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team July 1, 2025 09:44

fix PR comments

a952677

jmusial force-pushed the feat/use-reac-native-reanimated-in-xero-and-quickbooks-modals branch from 037b3c5 to a952677 Compare July 1, 2025 15:06

jmusial added 2 commits July 3, 2025 09:53

Merge branch 'main' into feat/use-reac-native-reanimated-in-xero-and-…

c9619bb

…quickbooks-modals

change overlay cursor to auto

3c6d0cf

Merge branch 'main' into feat/use-reac-native-reanimated-in-xero-and-…

3a85ac5

…quickbooks-modals

jmusial mentioned this pull request Jul 3, 2025

Use ReanimatedModal in Search Router Modal #65250

Merged

49 tasks

mhawryluk mentioned this pull request Jul 4, 2025

Migrate YearPickerModal & more to use Reanimated modal #65255

Merged

49 tasks

ZhenjaHorbach approved these changes Jul 4, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny July 4, 2025 14:14

ZhenjaHorbach approved these changes Jul 4, 2025

View reviewed changes

mountiny assigned jmusial Jul 4, 2025

mountiny approved these changes Jul 4, 2025

View reviewed changes

src/components/Modal/ReanimatedModal/utils.ts

Copy link
Copy Markdown

Contributor

mountiny Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mountiny merged commit 3eca548 into Expensify:main Jul 4, 2025
20 of 21 checks passed

github-actions bot mentioned this pull request Jul 7, 2025

Deploy Checklist: New Expensify 2025-07-07 #65549

Closed

54 tasks

melvin-bot bot mentioned this pull request Jul 8, 2025

[Due for payment 2025-12-16] [Due for payment 2025-09-26] [$250] [Tracking] Use react-native-reanimated in the ModalComponent #64775

Closed

jmusial deleted the feat/use-reac-native-reanimated-in-xero-and-quickbooks-modals branch August 26, 2025 08:11

Conversation

jmusial commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Depends on

Tests

Feature Training Modal

Xero and QuickBooks Online Modals

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Xero & Quickbooks Online

Feature Training

Xero & Quickbooks Online

Feature Training

Xero & Quickbooks Online

Feature Training

Xero & Quickbooks Online

Feature Training

Xero & Quickbooks Online

Feature Training

Xero & Quickbooks Online

Feature Training

Uh oh!

blazejkustra Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

blazejkustra Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

blazejkustra Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

blazejkustra Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jul 1, 2025

Uh oh!

ZhenjaHorbach commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Jul 3, 2025

Uh oh!

ZhenjaHorbach commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Jul 3, 2025

Uh oh!

ZhenjaHorbach commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Jul 3, 2025

Uh oh!

ZhenjaHorbach commented Jul 3, 2025

Uh oh!

jmusial commented Jul 4, 2025

Uh oh!

jmusial commented Jul 4, 2025

Uh oh!

ZhenjaHorbach commented Jul 4, 2025

Uh oh!

jmusial commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmusial commented Jul 4, 2025

Uh oh!

ZhenjaHorbach commented Jul 4, 2025

jmusial commented Jun 30, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 1, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 2, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 3, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 3, 2025 •

edited

Loading

jmusial commented Jul 4, 2025 •

edited

Loading

jmusial commented Jul 4, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 4, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 4, 2025 •

edited

Loading

jmusial commented Jul 4, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 4, 2025 •

edited

Loading