Use ReanimatedModal in Search Router Modal by jmusial · Pull Request #65250 · Expensify/App

jmusial · 2025-07-01T12:30:47Z

Explanation of Change

This PR uses react-native-reanimated based modal for SearchRouter modal. It also introduces swipe dismissal to new modals and fixes swipe navigation on SearchRouter modal. Change is relevant for narrow screens. On large screens SearchRouterModal is a POPOVER type.

Animation is always slideInRight / slideOutRight

Fixed Issues

$ #64776

PROPOSAL:

https://expensify.slack.com/archives/C05LX9D6E07/p1750147058498549

Depends on

#65172

Tests

Log into the app
Open search modal by clicking "Magnifying glass" icon in the top right.
Interact with it. The experience should not degrade from prev version. At least:

User can search.
User can unfocus input by clicking on modal outside input.
User can dismiss the modal by clicking arrow back.
User can dismiss the modal by swiping.

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

0025.android.native.mov

Android: mWeb Chrome

0025.android.chrome.mov

iOS: Native

0025.ios.safari.mp4

0025.native.ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

…outer, fix search router swipe

…odal-in-search-router-modal

…odal

melvin-bot · 2025-07-07T08:56:06Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-07-08T07:31:11Z

src/components/Modal/ReanimatedModal/Container/GestureHandler.tsx

+        [initialTranslationX, initialTranslationY, onSwipeComplete, swipeDirection, swipeThreshold],
+    );
+
+    if (!swipeDirection || !onSwipeComplete) {


Maybe we should also add !swipeDirection?.length ?
because I think this is also not a valid case for GestureDetector

ZhenjaHorbach · 2025-07-08T07:33:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

android-web.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

…odal

ZhenjaHorbach · 2025-07-08T16:53:47Z

Minor comment
Which reproduces on staging also
That we reset the first line on a search modal when we close this modal

2025-07-08.18.52.45.mov

ZhenjaHorbach · 2025-07-08T21:49:38Z

Changes look good !
Only found an app crash
But as I remember this is a known issue

2025-07-08.23.46.08.mov

jmusial · 2025-07-09T08:27:21Z

Minor comment Which reproduces on staging also That we reset the first line on a search modal when we close this modal

2025-07-08.18.52.45.mov

On desktop this is a POPOVER type. This PR does not touch it.

Changes look good ! Only found an app crash But as I remember this is a known issue

2025-07-08.23.46.08.mov

This is connected to
#65461
and
#65268

ZhenjaHorbach · 2025-07-09T08:34:08Z

In this case no more questions from my side
LGTM !

mountiny

Thank you!

github-actions · 2025-07-10T07:26:18Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-11T17:38:21Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

suneox · 2025-08-13T14:54:12Z

src/components/Search/SearchRouter/SearchRouterModal.tsx

            onModalShow={() => setShouldHideInputCaret(false)}
            shouldApplySidePanelOffset={!shouldUseNarrowLayout}
            enableEdgeToEdgeBottomSafeAreaPadding
+            shouldUseReanimatedModal={shouldUseNarrowLayout}


Coming from the #66065 checklist, this option doesn’t work on mWeb, so we have temporarily disabled it on mobile web.

jmusial added 2 commits July 1, 2025 11:36

fix PR comments

037b3c5

add swipability to reanimated modal, use reanimated modal in search r…

470e4b9

…outer, fix search router swipe

jmusial mentioned this pull request Jul 1, 2025

[Due for payment 2025-09-02] [$1750] Use react-native-reanimated in CENTERED Modals #64776

Closed

jmusial added 3 commits July 1, 2025 15:39

only enable ReanimatedModal on small screens

65a6105

use animation utils for web backdrop

bbd5c04

Merge remote-tracking branch 'origin/main' into feat/use-reanimated-m…

8000941

…odal-in-search-router-modal

jmusial mentioned this pull request Jul 3, 2025

Use reanimated modal in Help modal #65409

Merged

49 tasks

jmusial added 3 commits July 3, 2025 15:21

Merge branch 'main' into feat/use-reanimated-modal-in-search-router-m…

daf3b2d

…odal

was crashing otherwise

30e17af

Merge branch 'main' into feat/use-reanimated-modal-in-search-router-m…

8b4cc7e

…odal

DylanDylann mentioned this pull request Jul 4, 2025

[$250] The swipe right to dismiss SearchModal stopped working. #65280

Closed

16 tasks

Merge branch 'main' into feat/use-reanimated-modal-in-search-router-m…

ad2647b

…odal

jmusial marked this pull request as ready for review July 7, 2025 08:56

jmusial requested a review from a team as a code owner July 7, 2025 08:56

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team July 7, 2025 08:56

ZhenjaHorbach reviewed Jul 8, 2025

View reviewed changes

jmusial added 3 commits July 8, 2025 16:09

Merge branch 'main' into feat/use-reanimated-modal-in-search-router-m…

0ec5424

…odal

fix PR comments

c7fa33e

remove typo

cff2bd9

mountiny assigned jmusial Jul 8, 2025

ZhenjaHorbach approved these changes Jul 9, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny July 9, 2025 08:33

mountiny approved these changes Jul 9, 2025

View reviewed changes

mountiny merged commit 9356aa6 into Expensify:main Jul 9, 2025
19 checks passed

This was referenced Jul 9, 2025

Investigate workflow job failing on main: test / test (job 3) #65787

Closed

Deploy Checklist: New Expensify 2025-07-10 #65809

Closed

mitarachim mentioned this pull request Jul 10, 2025

[Due for payment 2025-07-22] [Due for payment 2025-07-18] Search - Search field is not focused after selecting a suggestion via keyboard #65815

Closed

8 tasks

jponikarchuk mentioned this pull request Jul 10, 2025

[Due for payment 2025-07-22] [Due for payment 2025-07-18] Search - Cursor automatically moves to the end after moving the cursor elsewhere #65816

Closed

8 tasks

rohit9625 mentioned this pull request Jul 10, 2025

[Due for payment 2025-10-27] [Due for payment 2025-08-20] [$250] Android - Search - Keyboard is not automatically opened despite input being focused. #65855

Closed

8 tasks

jmusial mentioned this pull request Jul 15, 2025

[Due for payment 2025-06-24] [$250] Android - Search - Search focus is not lost by tapping outside. #63418

Closed

8 tasks

suneox mentioned this pull request Jul 27, 2025

[Due for payment 2025-08-11] [$250] mWeb/Chrome - Search - App stuck when navigating to search and tap enter #66065

Closed

16 tasks

huult mentioned this pull request Aug 12, 2025

[Due for payment 2025-09-09] [$250] mWeb-Keyboard appear briefly when press device back button on selector #68191

Closed

8 tasks

suneox reviewed Aug 13, 2025

View reviewed changes

jmusial deleted the feat/use-reanimated-modal-in-search-router-modal branch August 26, 2025 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ReanimatedModal in Search Router Modal#65250

Use ReanimatedModal in Search Router Modal#65250
mountiny merged 12 commits intoExpensify:mainfrom
software-mansion-labs:feat/use-reanimated-modal-in-search-router-modal

jmusial commented Jul 1, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jul 7, 2025

Uh oh!

ZhenjaHorbach Jul 8, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach commented Jul 8, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach commented Jul 8, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach commented Jul 8, 2025

Uh oh!

jmusial commented Jul 9, 2025

Uh oh!

ZhenjaHorbach commented Jul 9, 2025

Uh oh!

mountiny left a comment

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

suneox Aug 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jmusial commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Depends on

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 7, 2025

Uh oh!

ZhenjaHorbach Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Jul 8, 2025

Uh oh!

jmusial commented Jul 9, 2025

Uh oh!

ZhenjaHorbach commented Jul 9, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

suneox Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmusial commented Jul 1, 2025 •

edited

Loading

ZhenjaHorbach Jul 8, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 8, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 8, 2025 •

edited

Loading