Enable multiple receipts by koko57 · Pull Request #64941 · Expensify/App

koko57 · 2025-06-25T15:54:53Z

Explanation of Change

Fixed Issues

$ #59441
PROPOSAL: -

Tests

WEB / DESKTOP

FAB -> Create Expense -> Scan
Drop several files on the drop zone
Verify that you're redirected to the participant step
Choose a participant, go to confirmation
Verify that on the confirmation step you see the carousel for the receipts and the transactions count is equal to the receipts count
Click "Create expenses" - verify that the transactions are created

Adding a new file

Repeat steps 1-5
Go back to the Scan step
Drop a few more files
Go to the confirmation
Verify that the transaction count is equal to the count of the files you've dropped in at the beginning and the files you've dropped later.

Starting the flow from the Chat

Go to a DM or Workspace Chat
Drop several files on the drop zone
Verify that you're redirected to the confirmation step
Verify that the participant is displayed correctly
Click "Create expenses" - verify that the transactions are created

Error handling

Start the IOU flow either from the FAB or the chat
Drop several files - choose some that exceed size limit (10MB), doesn't have a supported type or drop more than 30 files
Verify that the error modal appears with a correct message
Click Continue - verify that you are navigated to the next step
On confirmation step verify that only valid files were added
If all the files were not valid, verify that instead of continuing the flow, the flow was cancelled

Disable BETA

Verify that the drop zones that are currently used (not the new ones) are working as before

MOBILE

FAB -> Create Expense -> Scan
Click Gallery button -> Choose FIles / Choose from Gallery
Verify that you can select several files
Verify that you're redirected to the participant step
Choose a participant, go to confirmation
Verify that on the confirmation step you see the carousel for the receipts and the transactions count is equal to the receipts count
Click "Create expenses" - verify that the transactions are created

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

same as above, but skip DISABLE BETA part

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-06-25.at.21.32.27.mov

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.-.2025-06-26.at.07.27.25.mp4

Simulator.Screen.Recording.-.iPhone.15.-.2025-06-26.at.07.26.37.mp4

Simulator.Screen.Recording.-.iPhone.15.-.2025-06-26.at.07.51.34.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.-.2025-06-26.at.07.48.39.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-06-25.at.18.47.04.mov

Screen.Recording.2025-06-25.at.18.42.18.mov

MacOS: Desktop

Screen.Recording.2025-06-26.at.07.35.32.mp4

Screen.Recording.2025-06-26.at.07.33.48.mp4

…-files-attachments

koko57 · 2025-07-04T14:32:20Z

Screen.Recording.2025-07-04.at.16.25.12.mp4

@shubham1206agra the problem with [object Object] - fixed!

I don't see the problem with report IDs - it creates expense in the report I selected

May I ask you for re-review?

…eta is not enabled

shubham1206agra · 2025-07-04T16:38:33Z

@koko57 Can you look into this please https://expensify.slack.com/archives/C093V8SRYVA/p1751646134397659?

shubham1206agra · 2025-07-04T19:01:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-07-05.at.12.26.04.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-07-04.at.11.38.29.PM.mov

iOS: HybridApp

NA since Picker is broken in HybridApp

iOS: mWeb Safari

Screen.Recording.2025-07-04.at.11.19.05.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-04.at.11.09.40.PM.mov

MacOS: Desktop

Screen.Recording.2025-07-04.at.11.45.18.PM.mov

melvin-bot · 2025-07-04T19:02:27Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #59441 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2025-07-04T19:19:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

danieldoglas

👍🏾

kavimuru · 2025-07-07T11:00:10Z

@lakchote How should we disable BETA and which domain is BETA?

Disable BETA

getusha · 2025-07-07T11:12:17Z

I think it means an account without the beta (newDotMultiFilesDragAndDrop) enabled @kavimuru

github-actions · 2025-07-07T11:31:25Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

kavimuru · 2025-07-07T20:11:46Z

I think it means an account without the beta (newDotMultiFilesDragAndDrop) enabled @kavimuru

Is applause.expensifail.com domain under Beta and public domain not under beta?

koko57 · 2025-07-08T12:27:17Z

@lakchote How should we disable BETA and which domain is BETA?

Disable BETA

@kavimuru if you could add several files and handle multiple transactions you can skip this DISABLE BETA check, please test the rest of the flow

github-actions · 2025-07-08T21:01:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.77-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

QichenZhu · 2025-10-01T14:03:03Z

src/hooks/useFilesValidation.tsx

+                if (otherFiles.some((file) => isHeicOrHeifImage(file))) {
+                    setIsLoaderVisible(true);
+
+                    return Promise.all(otherFiles.map((file) => convertHeicImageToJpegPromise(file))).then((convertedImages) => {


HEIC conversion could fail, but the error was not caught and blocked the UI (issue: #68778). We fixed it in PR #70273.

koko57 added 30 commits June 2, 2025 13:35

feat: allow multiple files

8b72a83

fix: resolve conflicts

cbaf882

feat: create a new function for multiple files

19fa998

feat: create validation utils

bcd9dd1

feat: exctract isValidReceiptExtension

d0190be

fix: minor fix

18fdcae

feat: refactor error handling for the attachment modal

2d963f5

fix: resolve naming conflict

7fdda7e

feat: add translations

186a45f

feat: show error modal when max file limit exceeded

3e9b09a

fix: minor translation improvement

18e7db1

fix: resolve conflicts

0e039f6

feat: validate multiple files

9b55b87

feat: show error modal

18fc660

feat: add other error cases

5e76042

fix: resolve conflicts

f762127

fix: minor fix

fcb66ec

Merge branch 'main' into feat/59443-multi-files-attachments

da2224c

fix: resolve conflicts

eebdcbe

Merge branch 'feat/59442-split-screen-dropzone' into feat/59443-multi…

3cd6658

…-files-attachments

feat: add protected file validation error

92a0837

feat: handle PDF validation inside a hook

b64b63b

fix: resolve conflicts

a74199c

feat: file validation for mixed files

4a449c2

Merge branch 'main' into feat/59443-multi-files-attachments

4039bf8

feat: move confirmation error modal to the hook

817d8c9

refactor: change getFileValidationErrorText to return translated paths

5ac67a6

feat: display invalid file type

69716b9

fix: show link

a41837d

fix: resolve conflicts

8567d25

koko57 added 2 commits July 4, 2025 10:06

Merge branch 'main' into feat/59441-multiple-receipts

7e7f50a

fix: preserve file when cloning request

2177bb7

koko57 added 2 commits July 4, 2025 16:37

fix: prettier

e10e824

fix: prevent from adding more receipts when going back to scan when b…

dda0173

…eta is not enabled

shubham1206agra approved these changes Jul 4, 2025

View reviewed changes

melvin-bot bot requested a review from danieldoglas July 4, 2025 19:02

lakchote approved these changes Jul 4, 2025

View reviewed changes

lakchote merged commit 3d79946 into Expensify:main Jul 4, 2025
19 of 21 checks passed

danieldoglas reviewed Jul 4, 2025

View reviewed changes

github-actions bot mentioned this pull request Jul 7, 2025

Deploy Checklist: New Expensify 2025-07-07 #65549

Closed

54 tasks

mitarachim mentioned this pull request Jul 7, 2025

[Due for payment 2025-07-18] [Multi-Files Drag-and-Drop] Scan - Missing To field on confirm page when drag and drop photos to replace receipt #65552

Closed

8 tasks

mitarachim mentioned this pull request Jul 8, 2025

[Due for payment 2025-07-18] [Multi-Files Drag-and-Drop] Scan - First step of scan flow reopens after changing To field and adding another receipt #65599

Closed

8 tasks

marcaaron mentioned this pull request Jul 8, 2025

[Due for payment 2025-07-18] [Multi-Files Drag-and-Drop] Expense- Unable to add receipt on confirm page when submitting track expense to workspace chat #65598

Closed

8 tasks

mitarachim mentioned this pull request Jul 8, 2025

[Due for payment 2025-07-18] [Multi-Files Drag-and-Drop] Expense - 2 photos can be picked when adding receipt in expense thread, but only 1 is added #65621

Closed

8 tasks

This was referenced Jul 9, 2025

[Due for payment 2025-08-05] [Due for payment 2025-07-30] [Due for payment 2025-07-25] [Due for payment 2025-07-22] [Multi-Files Drag-and-Drop] Follow-ups and code cleanup #65722

Closed

Chore: follow ups and cleanup pt 1 #65847

Merged

danieldoglas assigned koko57 Aug 7, 2025

QichenZhu reviewed Oct 1, 2025

View reviewed changes

QichenZhu mentioned this pull request Oct 1, 2025

[Due for payment 2025-10-03] [$250] mWeb - Scan - Can't upload a receipt in HEIC format, page reloads or loads infinitely #68778

Closed

8 tasks

Conversation

koko57 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

koko57 commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Jul 4, 2025

Uh oh!

shubham1206agra commented Jul 4, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 4, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 4, 2025

Uh oh!

danieldoglas left a comment

Choose a reason for hiding this comment

Uh oh!

kavimuru commented Jul 7, 2025

Uh oh!

getusha commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 7, 2025

Uh oh!

kavimuru commented Jul 7, 2025

Uh oh!

koko57 commented Jul 8, 2025

Uh oh!

github-actions bot commented Jul 8, 2025

Uh oh!

QichenZhu Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

koko57 commented Jun 25, 2025 •

edited

Loading

koko57 commented Jul 4, 2025 •

edited

Loading

getusha commented Jul 7, 2025 •

edited

Loading