Heic conversion infinitie loader on mWeb by rinej · Pull Request #70273 · Expensify/App

rinej · 2025-09-10T13:00:13Z

Explanation of Change

It fixes an issue where some HEIC files cannot be converted properly, causing users to see an infinite loader. To address this, we introduced the following improvements:

Added validation to check whether the file extension matches the actual file type. If not, we correct the extension.
For some Safari versions where our HEIC conversion library is not supported, we implemented a fallback that uses canvas-based conversion.

Fixed Issues

$ #68778
PROPOSAL: #68778 (comment)

Tests

Open the app on iOS Safari
Download the .heic file (It can be taken from QA team -> [Due for payment 2025-10-03] [$250] mWeb - Scan - Can't upload a receipt in HEIC format, page reloads or loads infinitely #68778 (comment) )
Create Expense
Select choose file
Select the file from step 1
The expense should be successfully created

withCanvasFallback.mp4

Offline tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-15T14:00:43Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

QichenZhu · 2025-09-16T06:42:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
This PR only focues iOS mWeb.
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
  N/A. See Heic conversion infinitie loader on mWeb #70273 (comment).
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
https://github.com/Expensify/App/issues/70612, https://github.com/Expensify/App/pull/69146#discussion_r2344613020
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp (N/A)

android-native-bug.webm

Android: mWeb Chrome

android-web.mov

iOS: HybridApp

ios-native.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

mac-web.mov

MacOS: Desktop

mac-desktop.mov

QichenZhu · 2025-09-16T12:28:09Z

src/libs/fileDownload/heicConverter/index.ts

+
+                        return verifyPngFormat(fileFromBlob).then((isPng) => {
+                            if (isPng) {
+                                const correctedFile = Object.assign(new File([blob], fileName.replace(/\.(heic|heif)$/i, '.png'), {type: CONST.IMAGE_FILE_FORMAT.PNG}), {


I noticed the JPEG and PNG format detection is only used to rename files. Does the filename actually matter for the server? If not, we could probably simplify this by skipping the JPEG/PNG detection and only detecting HEIC format.

This conversion (renaming the extension in the file name) is needed only in cases where the user provides a mismatched image (e.g., a JPG file labeled with a .HEIC extension). We need this detection to correctly change the extension.

Without it, we end up with an empty placeholder instead of the image:

I found the frontend doesn't display it because expensify-common's isImage() function doesn't recognize the file extension. The backend can still scan it.

If I simply give the fake HEIC image a .png extension (even if it's actually a JPEG image), both the frontend and backend accept it just fine.

So it looks like neither the frontend nor backend cares about whether PNG or JPEG files have the right extension, so we don't really need to distinguish between them.

Ok, I will double check it and remove that part, it might be that with the fallback it is not necessary anymore

I revisited it and cleaned up the logic.
You are right, after adding the fallback we don't need the additional checks for png and jpg. In that scenario the canvas fallback will do the proper conversion

QichenZhu · 2025-09-18T15:19:53Z

I noticed HEIC failed to upload on Android Native. It's not caused by this PR since it also fails on main.

We should fix it ourselves or wait until it's fixed on main, otherwise this PR won't pass QA.

rinej · 2025-09-19T11:13:59Z

It shouldn’t be related to our changes, since for the native parts we use a different file and a different approach (ImageManipulator).

That said, it would still be good to fix it - I’ll look into it.

rinej · 2025-09-19T11:36:28Z

I could reproduce it on Android and have the following error. I am working on the fix

rinej · 2025-09-19T11:56:41Z

@QichenZhu Could you verify now? I created the variable for image context. It fixes the android upload for me:

Screen.Recording.2025-09-19.at.13.50.51.mp4

QichenZhu · 2025-09-22T09:33:40Z

@rinej, I'm still seeing that error on the PR branch (and on main).

Also noticed the chat was in an infinite loading state, so it may be related to https://expensify.slack.com/archives/C05LX9D6E07/p1757575934291339.

android-native-bug.webm

However, the upload succeeded if I sent a message first.

rinej · 2025-09-22T10:21:03Z

After applying the fix on that branch, I’m no longer able to reproduce the issue on Android Native, it is how it looks:

Android.mp4

When you encountered the infinite loader, it was likely a sign that something else in the app was off, so that might have been the root cause.

What do you think about moving forward with the HEIC for web fix? Since using HEIC on Android is not very common, It is a lower priority.

cc @mountiny

rinej · 2025-09-22T10:21:59Z

I’ve just resolved the conflicts with the main after the Windows fix.

mountiny · 2025-09-22T11:40:45Z

Yeah i think if that is already on main we can treat it as a separate issue, can you please complete the review and checklist? @QichenZhu

mountiny

Asked for unit tests but I dont want to block on this, we can follow up with these

mountiny · 2025-09-22T14:13:04Z

src/libs/fileDownload/heicConverter/index.ts

+/**
+ * Canvas fallback for converting HEIC to JPEG in web browsers
+ */
+const canvasFallback = (blob: Blob, fileName: string): Promise<File> => {


@rinej can you think of ways to add unit test for this logic please?

sure, I will make some units for it

OSBotify · 2025-09-22T14:25:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

rinej · 2025-09-23T11:28:19Z

I created the follow up PR with the unit tests -> #71052
@mountiny @QichenZhu

OSBotify · 2025-09-23T19:58:39Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.17-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-24T22:48:32Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.17-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

add additional signatures check for heic files

cadb1ba

melvin-bot bot assigned rinej Sep 10, 2025

rinej mentioned this pull request Sep 10, 2025

[Due for payment 2025-10-03] [$250] mWeb - Scan - Can't upload a receipt in HEIC format, page reloads or loads infinitely #68778

Closed

8 tasks

rinej added 5 commits September 11, 2025 11:59

Merge branch 'main' into heic-convert-infinite-loader

5f77f8b

add canvas fallback strategy with canvas scaling

ffbce27

refactor async to promise base logic

0da96b9

create const from variables

d82e2e4

remove todos

7487546

rinej changed the title ~~add additional signatures check for heic files~~ Heic converts infinitie loader on mWeb Sep 15, 2025

rinej added 2 commits September 15, 2025 15:43

lint fix

7ba1aaa

cleanup comments

85ab493

rinej marked this pull request as ready for review September 15, 2025 14:00

rinej requested a review from a team as a code owner September 15, 2025 14:00

melvin-bot bot requested review from QichenZhu and removed request for a team September 15, 2025 14:00

Merge branch 'main' into heic-convert-infinite-loader

30971bc

rinej changed the title ~~Heic converts infinitie loader on mWeb~~ Heic conversion infinitie loader on mWeb Sep 16, 2025

QichenZhu reviewed Sep 16, 2025

View reviewed changes

rinej added 2 commits September 18, 2025 12:40

remove manual extention validation

8ee1ce8

simplify fallback logic

f84db45

create context variable for android issue

2d77819

QichenZhu mentioned this pull request Sep 19, 2025

fix: heic converter breaks on Windows #70866

Merged

51 tasks

Merge branch 'main' into heic-convert-infinite-loader

0766245

QichenZhu approved these changes Sep 22, 2025

View reviewed changes

melvin-bot bot requested a review from inimaga September 22, 2025 14:01

mountiny approved these changes Sep 22, 2025

View reviewed changes

mountiny merged commit 090ef33 into Expensify:main Sep 22, 2025
23 checks passed

rinej mentioned this pull request Sep 23, 2025

Tests for canvas fallback heic converter #71052

Merged

49 tasks

OSBotify mentioned this pull request Sep 23, 2025

Deploy Checklist: New Expensify 2025-09-23 #71102

Closed

84 tasks

QichenZhu mentioned this pull request Oct 1, 2025

Enable multiple receipts #64941

Merged

50 tasks

Conversation

rinej commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 15, 2025

Uh oh!

QichenZhu commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

rinej Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

rinej Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

rinej Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rinej commented Sep 19, 2025

Uh oh!

rinej commented Sep 19, 2025

Uh oh!

rinej commented Sep 19, 2025

Uh oh!

QichenZhu commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rinej commented Sep 22, 2025

Uh oh!

rinej commented Sep 22, 2025

Uh oh!

mountiny commented Sep 22, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

rinej Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 22, 2025

Uh oh!

rinej commented Sep 23, 2025

Uh oh!

OSBotify commented Sep 23, 2025

Uh oh!

OSBotify commented Sep 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rinej commented Sep 10, 2025 •

edited

Loading

QichenZhu commented Sep 16, 2025 •

edited

Loading

QichenZhu commented Sep 18, 2025 •

edited

Loading

QichenZhu commented Sep 22, 2025 •

edited

Loading