fix: Android & iOS - Text is cut off in the search field when device font size is minimum. #65071

Krishna2323 · 2025-06-27T08:58:40Z

Explanation of Change

Fixed Issues

$ #62907
PROPOSAL:

Tests

Precondition:

Set device font size to the minimum
Kill the app then relaunch Expensify app

Open FAB > Start chat
Tap on the search field
Enter "hello google"
4 Verify the text is shown without any cutoff

Verify that no errors appear in the JS console

Offline tests

Precondition:

Set device font size to the minimum
Kill the app then relaunch Expensify app

Open FAB > Start chat
Tap on the search field
Enter "hello google"
4 Verify the text is shown without any cutoff

QA Steps

Precondition:

Set device font size to the minimum
Kill the app then relaunch Expensify app

Open FAB > Start chat
Tap on the search field
Enter "hello google"
4 Verify the text is shown without any cutoff

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_natvie.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…font size is minimum. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-06-27T09:32:12Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-06-27T09:41:36Z

The loading indicator looks way off in this video?

Perhaps you can also share a quick before & after set of screenshots? Thanks!

Krishna2323 · 2025-06-27T09:43:37Z

The loading indicator will be fixed in this PR.

shawnborton · 2025-06-27T09:44:24Z

Ah okay, thanks for confirming. Would still love a quick before/after of the two mobile platforms just for posterity. Thanks!

Krishna2323 · 2025-06-27T09:54:25Z

BEFORE:

AFTER:

shawnborton · 2025-06-27T10:07:48Z

That's good for the indicator. But I mean before/after of what you are fixing in this specific PR.

Krishna2323 · 2025-06-27T11:41:22Z

Before (The letter 'g' is half-visible):

before.mp4

After:

after.mp4

shawnborton · 2025-06-27T13:08:12Z

Perfect, that looks pretty good to me 👍 I say we get this into final review then.

Krishna2323 · 2025-06-27T16:41:54Z

@dominictb, please review this when you get a chance. Thanks!

dominictb · 2025-06-30T12:18:37Z

BUG: On native, the currency and value are misaligned:

dominictb · 2025-06-30T12:19:18Z

BUG: Room description field label is misaligned

dominictb · 2025-06-30T12:21:56Z

BUG: Private notes field has large bottom padding:

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-07-01T01:17:04Z

@dominictb, all the above issues have been fixed.

Note: All the issues were also reproducible without the original PR changes.

Fixed

Monosnap.screencast.2025-07-01.06-42-18.mp4

Reproducible without input update PR

Monosnap.screencast.2025-06-30.22-27-00.mp4

dominictb · 2025-07-02T00:58:15Z

src/components/TextInput/BaseTextInput/implementation/index.native.tsx

                                        tabIndex={-1}
                                        style={[styles.textInputPrefix, !hasLabel && styles.pv0, styles.pointerEventsNone, prefixStyle]}
                                        dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
+                                        shouldUseDefaultLineHeight={!Object.keys(StyleSheet.flatten(prefixStyle)).includes('lineHeight') && !shouldApplyHeight}


This is something I asked to fix earlier https://github.com/Expensify/App/pull/63034/files#r2143503208. We should not assume it this way.

Sorry for missing that. I think this is the right way to handle it because if we introduce a prop for this, we’d need to pass both the prop and lineHeight: undefined to make it work. But with this approach, we can simply pass lineHeight: undefined without any extra steps. Do you still think we should add a prop?

Yes I think we still need the prop. There might be cases where we intentionally set the lineHeight to undefined just to reset a previously-set lineHeight value but still want to use the default lineHeight in Text component.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dominictb · 2025-07-07T11:00:14Z

Testing again

dominictb · 2025-07-07T22:38:20Z

BUG: Tax value page is misaligned

Krishna2323 · 2025-07-21T07:55:04Z

@dominictb friendly bump ^

dominictb · 2025-07-21T20:05:22Z

This is not fixed for me #65071 (comment). I THINK it has the same root cause with this one #63034 (comment) which I could but you couldn't reproduce. It was fixed in this commit 05f020d.

It would be much much better if you could find out consistent reliable reproducible steps on your device too so we can early spot similar issues.

Krishna2323 · 2025-07-22T12:38:32Z

I'll try to find reliable reproduction steps.

dominictb · 2025-07-24T01:25:01Z

@Krishna2323 Any update?

Krishna2323 · 2025-07-24T18:09:23Z

@dominictb, sorry for delay, I'll try to finish this within 24h. Still trying to reproduce the issue on my end.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-07-25T18:32:56Z

@dominictb, could you please check this again? The issue occurred because we were using extraSymbol without applying styles.lineHeightUndefined to it.

App/src/pages/workspace/taxes/ValuePage.tsx

Line 98 in db267d0

extraSymbol={<Text style={styles.iouAmountText}>%</Text>}

dominictb · 2025-07-28T15:30:16Z

BUG: Right icon is misaligned

simulator_screenshot_6299182E-AA05-4285-A8D0-B3062E72D850

This seems to be the last bug.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-07-28T19:49:47Z

BUG: Right icon is misaligned

@dominictb fixed.

dominictb · 2025-07-29T03:59:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator Screenshot - iPhone 16 - 2025-07-29 at 11 13 06

iOS: mWeb Safari

simulator_screenshot_23621AE9-63A7-41BF-B25F-E5BEFCD78513

MacOS: Chrome / Safari

MacOS: Desktop

dominictb · 2025-07-29T04:12:33Z

src/styles/utils/index.ts

+            marginTop: -(inputPaddingTop / 2),
+            height: '100%',
+            justifyContent: 'center',


Can you elaborate these changes?

I’ve updated the logic to dynamically center the icon instead of using a fixed marginTop.
Let’s say the input container is 52px tall with:

paddingTop = 8px paddingBottom = 0px

Normally, the icon container takes the full height after top padding, so its height becomes:

icon height = 52px - 8px = 44px

But visually, we want the icon to look centered within the full 52px height, not just the 44px.
To achieve that, we calculate the vertical padding difference:

paddingTop - paddingBottom = 8px - 0px = 8px

We then divide this difference by 2 to get the offset needed for centering:

8px / 2 = 4px

Now, we apply a negative marginTop of -4px to the icon container:

marginTop: -(verticalPaddingDiff / 2)

This pulls the icon upward just enough to make it visually centered in the full height, regardless of uneven padding.

But from the implementation I see that you're summing up the vertical paddings, right? Also the param name should be verticalPaddingDiff or something else, inputPaddingTop is not correct.

oops, sorry I forgot to push the local commit.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dominictb

Krishna2323 · 2025-07-29T22:22:07Z

@dominictb The checklist isn’t checked off. 😅

github-actions · 2025-07-31T12:16:38Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.1.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-04T19:23:33Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Android & iOS - Text is cut off in the search field when device …

e2f4dda

…font size is minimum. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review June 27, 2025 09:32

Krishna2323 requested review from a team as code owners June 27, 2025 09:32

melvin-bot bot requested review from dominictb and removed request for a team June 27, 2025 09:32

Krishna2323 added 4 commits July 1, 2025 03:30

Merge branch 'Expensify:main' into krishna2323/issue/62907

693f6ac

fix input alignment.

b8c80e3

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix multiline input.

4373ddd

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix prefix and suffix characters alignment.

936a8f8

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 mentioned this pull request Jul 2, 2025

[Due for payment 2025-06-05] [$250] Update visual style of our text inputs for better consistency #59518

Closed

dominictb suggested changes Jul 2, 2025

View reviewed changes

Krishna2323 mentioned this pull request Jul 2, 2025

[HOLD] [$250] Login - The entered email appears cut on sign in screen #65294

Closed

8 tasks

Krishna2323 added 2 commits July 4, 2025 22:22

Merge branch 'Expensify:main' into krishna2323/issue/62907

2db860c

add prop for using default line height for prefix character.

a2fda2b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/62907

9350c86

Krishna2323 added 2 commits July 25, 2025 23:05

Merge branch 'Expensify:main' into krishna2323/issue/62907

9b59c60

fix tax amount picker alignment.

2b72873

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 3 commits July 28, 2025 23:48

Merge branch 'Expensify:main' into krishna2323/issue/62907

677bdda

fix input icon alignment.

c20b236

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix activity indicator alignment.

8273b1e

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dominictb reviewed Jul 29, 2025

View reviewed changes

Krishna2323 added 2 commits July 29, 2025 12:33

centre icon based on input vertical padding diff.

2447260

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix spell check.

01181e7

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dominictb approved these changes Jul 29, 2025

View reviewed changes

melvin-bot bot requested a review from techievivek July 29, 2025 22:05

dominictb approved these changes Jul 29, 2025

View reviewed changes

techievivek assigned Krishna2323 Jul 30, 2025

techievivek approved these changes Jul 30, 2025

View reviewed changes

techievivek merged commit 5de4e79 into Expensify:main Jul 30, 2025
19 of 20 checks passed

This was referenced Jul 30, 2025

Investigate workflow job failing on main: lint / ESLint check Expensify/App-Test-Fork#80

Open

Deploy Checklist: New Expensify 2025-07-31 #67499

Closed

lanitochka17 mentioned this pull request Jul 31, 2025

Android - Expense-Amount and currency are not on the same line when device font size is minimum #67585

Closed

16 tasks

fix: Android & iOS - Text is cut off in the search field when device font size is minimum. #65071

fix: Android & iOS - Text is cut off in the search field when device font size is minimum. #65071

Uh oh!

Conversation

Krishna2323 commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 27, 2025

Uh oh!

shawnborton commented Jun 27, 2025

Uh oh!

Krishna2323 commented Jun 27, 2025

Uh oh!

shawnborton commented Jun 27, 2025

Uh oh!

Krishna2323 commented Jun 27, 2025

Uh oh!

shawnborton commented Jun 27, 2025

Uh oh!

Krishna2323 commented Jun 27, 2025

Before (The letter 'g' is half-visible):

After:

Uh oh!

shawnborton commented Jun 27, 2025

Uh oh!

Krishna2323 commented Jun 27, 2025

Uh oh!

dominictb commented Jun 30, 2025

Uh oh!

dominictb commented Jun 30, 2025

Uh oh!

dominictb commented Jun 30, 2025

Uh oh!

Krishna2323 commented Jul 1, 2025

Fixed

Reproducible without input update PR

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dominictb commented Jul 7, 2025

Uh oh!

dominictb commented Jul 7, 2025

Uh oh!

Krishna2323 commented Jul 21, 2025

Uh oh!

dominictb commented Jul 21, 2025

Uh oh!

Krishna2323 commented Jul 22, 2025

Uh oh!

dominictb commented Jul 24, 2025

Uh oh!

Krishna2323 commented Jul 24, 2025

Uh oh!

Krishna2323 commented Jul 25, 2025

Uh oh!

dominictb commented Jul 28, 2025

Uh oh!

Krishna2323 commented Jul 28, 2025

Uh oh!

dominictb commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Krishna2323 commented Jun 27, 2025 •

edited

Loading

dominictb commented Jul 29, 2025 •

edited

Loading