fix: Update visual style of our text inputs for better consistency.

[Krishna2323]

Explanation of Change

The original PR was reverted due to regressions. This PR reintroduces the original changes and also includes fixes for the regressions.

Fixed Issues

$ #59518
$ #62931
$ #62947
$ #62971
$ #62969
$ #62982
$ #63010
PROPOSAL: #59518 (comment)

Tests

1. Go to Settings > Profile > Display name
2. Verify border bottom on inputs is 1px
3. Focus an input > Verify highlighted border bottom is also 1px

• Verify that no errors appear in the JS console

Offline tests

1. Go to Settings > Profile > Display name
2. Verify border bottom on inputs is 1px
3. Focus an input > Verify highlighted border bottom is also 1px

QA Steps

Test 1

1. Go to Settings > Profile > Display name
2. Verify border bottom on inputs is 1px
3. Focus an input > Verify highlighted border bottom is also 1px

Test 2

1. Log in as applausetester+ccardfeed@applause.expensifail.com
2. Go to workspace settings > Company cards.
3. Click Assign card.
4. Select a user > Next.
5. Select a card > Next.
6. Click Custom start date.
7. Click Date.
8. Verify the clear/calendar button is aligned in the middle of the input modal.

Test 3

1. Go to Account > Profile > Status.
2. Click Clear after.
3. Click Custom > Time.
4. Verify there is no spacing after the hours.

Test 4

1. Onboard with private domain email (Domain used should have existing account)
2. Observe the private domain (People you may know) modal displayed
3. Verify there is padding between the subtitle & the text inputs

Test 5

1. Sign up with a new account
2. Skip "What's your work email?"
3. Tap "Something else"
4. Add something in "First name?"
5. Verify placeholders for the new text inputs are centered in test drive screen

Test 6

1. Go to search > Filter > From
2. Select an account that has no display name, only email; or an account whose name contains no space and is long (e.g., "LoremIpsumDummyText" (create one if needed)
3. Verify search input contains the "from:" query

Test 7

1. Open FAB > Create expense > Manual.
2. Enter 88888888.
3. Verify the alignment of amount input is same on staging and production.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[Krishna2323]

@Krishna2323 Text input with currency prefix is misaligned, only on mWeb Chrome.

@dominictb, the amount input looks centred to me on android chrome also:

[Krishna2323]

another quick thing - can you check the border color on the input of the reports page? It feels quite light to me, almost as if it's using the wrong value - it should use our theme value for borders:

@shawnborton, the issue was different here—the input on the reports page should have a background color and a transparent border when it's not focused.

I've fixed that now:

Monosnap.screencast.2025-05-30.06-26-47.mp4

[Krishna2323]

@dominictb, this issue is also reproducible on main. I'm already assigned to that issue, I think we can handle it after this is merged.

[melvin-bot]

@shawnborton @dominictb One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

[shawnborton]

Not a blocker, but I think we should add a little more padding to the top of the emoji picker popover so that the padding on the top is equal to the padding on the sides:

[shawnborton]

We're missing the new styles on the Reports page search query bar:

[dannymcclain]

Not a blocker, but I think we should add a little more padding to the top of the emoji picker popover so that the padding on the top is equal to the padding on the sides:

Agree!

[Krishna2323]

We're missing the new styles on the Reports page search query bar:

@shawnborton, are you saying it should match the other inputs, with no background and just a border?

[dannymcclain]

are you saying it should match the other inputs, with no background and just a border?

Correct!

[Krishna2323]

@dominictb, could you please check this issue again? I'm not able to reproduce this after pulling main.

Monosnap.screencast.2025-06-19.18-07-02.mp4

[dominictb]

BUG Input with prefix is misaligned, happen on mWeb Chrome only:

[Krishna2323]

@dominictb, the bug mentioned above is also not reproducible on my side:

Monosnap.screencast.2025-06-21.00-02-49.mp4

[dominictb]

Peer-reviewing via Slack DM with Krishna to speed this up as he couldn't reproduce the issue.

[dominictb]

[MonilBhavsar]

Thank you for through testing!
Can we please expand QA section for QA team to verify that all issues have been fixed

[shawnborton]

Woo thanks team, we're so close!

[Krishna2323]

@MonilBhavsar, QA test section has been updated.

[dominictb]

@Krishna2323 Please remove "3. Observe that the search input does not contain the "from:" query" from Test 6.

[MonilBhavsar]

Thanks!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌