fix: Clear/calendar button is aligned to top instead of in the middle of input modal. #62976

Krishna2323 · 2025-05-28T16:23:41Z

Explanation of Change

Fixed Issues

$ #62931
$ #62947
$ #62971
$ #62969
$ #62982
PROPOSAL:

Tests

Test 1

Go to /settings/workspaces/AE7DCE11CDAF1CAF/company-cards/vcf/assign-card/transaction-start-date
Select a date > Verify the clear button is centred
Clear the date > Verify the calendar icon is centred

Test 2

Go to Account > Profile > Status.
Click Clear after.
Click Custom > Time.
Verify there is no spacing after hours input

Test 3
Onboard with private domain email (Domain used should have existing account)
Observe the private domain (People you may know) modal displayed
Verify there is padding between the subtitle & the text inputs in people you may know modal
Test 4

Sign up with a new account
Skip "What's your work email?"
Tap "Something else"
Add something in "First name?"
Verify placeholders for the new text inputs are centered in test drive screen

Test 5

Go to search > Filter > From
Select an account that has no display name, only email; or an account whose name contains no space and is long (e.g., "LoremIpsumDummyText" (create one if needed)
Observe that the search input does not contain the "from:" query
Verify search input contains the "from:" query

Verify that no errors appear in the JS console

Offline tests

Same as tests, some of the tests requires internet.

QA Steps

Same as tests.
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop-app.mp4

… of input modal. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-05-28T16:23:46Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-05-28T16:23:47Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…may know modal. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dominictb · 2025-05-28T16:45:18Z

@Krishna2323 FYI we can combine all the regressions fixes into 1 PR for better follow-ups.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…ive screen. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-05-28T18:22:46Z

@dominictb, all the linked issues are fixed. This one is the only one remaining, which I’ve planned to fix separately.

cc: @Expensify/design

shawnborton · 2025-05-28T18:47:02Z

Thanks Krishna! @dominictb let's get this into final review when you get a moment, thanks!

github-actions · 2025-05-28T18:48:02Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-28T19:19:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/62976-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62976-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62976/NewExpensify.dmg	https://62976.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dannymcclain · 2025-05-28T20:29:58Z

I mean... How nit picky should I get? It looks like it's 1px off center 😅

Beamanator · 2025-05-28T20:55:36Z

In my opinion, 1px off center = not a deploy blocker anymore, then we can take our time getting to 0 px off center 😬 thoughts??

Krishna2323 · 2025-05-28T20:58:39Z

@Beamanator, yes I don't think we should block on that.

EDIT: BTW that isn't caused by this or the original PR, it's the icon size due to which we see difference between both icons.

Monosnap.screencast.2025-05-29.02-27-21.mp4

dannymcclain · 2025-05-28T20:59:57Z

In my opinion, 1px off center = not a deploy blocker anymore, then we can take our time getting to 0 px off center 😬 thoughts??

Definitely agree! Not a deploy blocker!

Beamanator · 2025-05-28T22:13:49Z

Any updates @dominictb ? 🙏

dominictb · 2025-05-28T21:40:05Z

src/styles/utils/index.ts

        return maxAutoGrowHeight ? {maxHeight: maxAutoGrowHeight - styles.textInputMultilineContainer.paddingTop - styles.textInputContainer.borderWidth * 2} : {};
    },

+    getTextInputIconContainerStyles: (hasLabel: boolean, includePadding = true) => {


Add a comment here explaining WHY and WHEN we need this; and the params' meaning

dominictb · 2025-05-28T21:41:49Z

src/components/AmountTextInput.tsx

            disableKeyboard={disableKeyboard}
            inputStyle={style}
-            textInputContainerStyles={[styles.p0, containerStyle]}
+            textInputContainerStyles={[containerStyle]}


Suggested change

textInputContainerStyles={[containerStyle]}

textInputContainerStyles={containerStyle}

dominictb · 2025-05-28T22:02:12Z

src/components/TextInput/BaseTextInput/types.ts

    /** Customize the TextInput container */
    textInputContainerStyles?: StyleProp<ViewStyle>;

+    /** Whether to apply padding to the input */


Add a comment explain WHY and WHEN we need this prop

dominictb · 2025-05-28T22:13:49Z

src/components/TextInput/BaseTextInput/implementation/index.native.tsx

            setWidth((prevWidth: number | null) => (autoGrowHeight ? layout.width : prevWidth));
            setHeight((prevHeight: number) =>
-                !multiline ? layout.height + heightToFitEmojis - (styles.textInputContainer.padding + styles.textInputContainer.borderWidth * 2) : prevHeight,
+                !multiline ? layout.height + heightToFitEmojis - ((hasLabel ? styles.textInputContainer.padding : 0) + styles.textInputContainer.borderWidth * 2) : prevHeight,


Extract variables for these: labelPadding, borderWidth

dominictb · 2025-05-28T22:18:13Z

src/components/TextInput/BaseTextInput/implementation/index.tsx

                            {!!inputProps.secureTextEntry && (
                                <Checkbox
-                                    style={[styles.flex1, styles.textInputIconContainer]}
+                                    style={[styles.flex1, StyleUtils.getTextInputIconContainerStyles(hasLabel)]}


BUG: View password icon is not middle aligned vertically:

On production:

Beamanator · 2025-05-28T22:40:09Z

@Krishna2323 are you online to address the PR review?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-05-28T22:43:09Z

@Beamanator, yep! 🙃 I've addressed all the comments.

Beamanator · 2025-05-28T22:43:56Z

Wow thanks so much @Krishna2323 !

dominictb · 2025-05-29T00:03:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

dominictb · 2025-05-29T00:45:35Z

@Krishna2323 Text input with currency prefix is misaligned, only on mWeb Chrome.

dominictb · 2025-05-29T00:53:21Z

I've tested everywhere and the above bug should be the last one.

Beamanator · 2025-05-29T04:40:45Z

Oofda that's such a small misalignment, i'm tempted to merge 🙈 But i can let this go till morning i guess 😅 (since we have another blocker still open)

shawnborton · 2025-05-29T07:05:34Z

Let's try to address this one too: #63010

shawnborton · 2025-05-29T07:05:58Z

Let's fix the misalignment above if we have some time this morning. cc @Krishna2323 @dominictb what's the overall status here?

shawnborton · 2025-05-29T07:07:15Z

@Krishna2323 another quick thing - can you check the border color on the input of the reports page? It feels quite light to me, almost as if it's using the wrong value - it should use our theme value for borders:

dominictb · 2025-05-29T09:58:43Z

#63010 was already fixed in this PR.

shawnborton · 2025-05-29T13:00:17Z

@Krishna2323 what are the next steps here? Do you plan to make a fresh new PR from your old branch that was reverted?

Krishna2323 · 2025-05-29T22:49:36Z

@shawnborton, the new PR with the reverted changes and the fix for the regressions is here. I'm working on the fix for the last issue, as well as this and this comment. I’ll try to address those within 2 hours so we have a good chance of merging that today.

shawnborton · 2025-05-30T05:56:32Z

Sounds good, let's close this one out then.

fix: Clear/calendar button is aligned to top instead of in the middle…

675c08c

… of input modal. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested review from a team as code owners May 28, 2025 16:23

melvin-bot bot requested a review from dominictb May 28, 2025 16:23

melvin-bot bot removed the request for review from a team May 28, 2025 16:23

Krishna2323 marked this pull request as draft May 28, 2025 16:24

Krishna2323 added 2 commits May 28, 2025 22:01

minor fix.

fcb32ac

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: No padding between the subtitle & the text inputs in people you …

0c90db6

…may know modal. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 2 commits May 28, 2025 22:44

fix: Status - There is spacing after hours in time input page.

bb66248

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: Placeholders for the new text inputs are not centered in Test dr…

76ff95c

…ive screen. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review May 28, 2025 18:17

dominictb suggested changes May 28, 2025

View reviewed changes

minor updates.

e39795f

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dominictb mentioned this pull request May 29, 2025

[Due for payment 2025-06-09] [Due for payment 2025-06-05] Expense - Amount input is aligned to the left compared to production #63010

Closed

8 tasks

mountiny assigned Krishna2323 May 29, 2025

Krishna2323 closed this May 30, 2025

This was referenced May 30, 2025

[No QA] bump fast-equals #62890

Merged

fix: WS - Not here page appears when trying to navigate to Workspaces. #62747

Merged

fix: Invoice - Workspace chat has RBR in LHN after sending invoice without category. #61709

Merged

Krishna2323 mentioned this pull request Jul 2, 2025

[Due for payment 2025-06-05] [$250] Update visual style of our text inputs for better consistency #59518

Closed

	textInputContainerStyles={[containerStyle]}
	textInputContainerStyles={containerStyle}

fix: Clear/calendar button is aligned to top instead of in the middle of input modal. #62976

fix: Clear/calendar button is aligned to top instead of in the middle of input modal. #62976

Uh oh!

Conversation

Krishna2323 commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 28, 2025

Uh oh!

melvin-bot bot commented May 28, 2025

Uh oh!

dominictb commented May 28, 2025

Uh oh!

Krishna2323 commented May 28, 2025

Uh oh!

shawnborton commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

dannymcclain commented May 28, 2025

Uh oh!

Beamanator commented May 28, 2025

Uh oh!

Krishna2323 commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator commented May 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Beamanator commented May 28, 2025

Uh oh!

Krishna2323 commented May 28, 2025

Uh oh!

Beamanator commented May 28, 2025

Uh oh!

dominictb commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator commented May 29, 2025

Uh oh!

shawnborton commented May 29, 2025

Krishna2323 commented May 28, 2025 •

edited

Loading

Krishna2323 commented May 28, 2025 •

edited

Loading

dannymcclain commented May 28, 2025 •

edited

Loading

dominictb commented May 29, 2025 •

edited

Loading

dominictb commented May 29, 2025 •

edited

Loading

dominictb commented May 29, 2025 •

edited

Loading