Skip to content

Conversation

@Krishna2323
Copy link
Contributor

@Krishna2323 Krishna2323 commented May 25, 2025

Explanation of Change

Fixed Issues

$ #62569
PROPOSAL: #62569 (comment)

Tests

  1. As user A, create a workspace and add user B as a member
  2. As user B, click on Workspaces > click on the WS created by user A then navigate back to inbox
  3. As user A, delete the workspace
  4. AS user B, click on Workspaces
  5. Verify workspace lists page opens
  • Verify that no errors appear in the JS console

Offline tests

  • Internet connection is required

QA Steps

  1. As user A, create a workspace and add user B as a member
  2. As user B, click on Workspaces > click on the WS created by user A then navigate back to inbox
  3. As user A, delete the workspace
  4. AS user B, click on Workspaces
  5. Verify workspace lists page opens
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 marked this pull request as ready for review May 26, 2025 09:53
@Krishna2323 Krishna2323 requested a review from a team as a code owner May 26, 2025 09:53
@melvin-bot melvin-bot bot requested a review from QichenZhu May 26, 2025 09:53
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2025

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team May 26, 2025 09:53
@QichenZhu
Copy link
Contributor

QichenZhu commented May 26, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
      N/A. Internet connection is required.
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
    https://expensify.slack.com/archives/C01GTK53T8Q/p1751286039132129
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android-native.mp4
Android: mWeb Chrome
android-web.mp4
iOS: HybridApp
ios-native.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
mac-web.mov
MacOS: Desktop
mac-desktop.mov

@Krishna2323
Copy link
Contributor Author

sorry QichenZhu, please hold on review, I forgot to add the unit tests.

@QichenZhu
Copy link
Contributor

Please ping me when it's ready.

@Krishna2323
Copy link
Contributor Author

I'll finish this before Monday. Sorry for the delay — my recent PR caused a few regressions, which required me to urgently raise a new one. I've been busy fixing those over the past two days:

#62976
#63034

@QichenZhu
Copy link
Contributor

No problem @Krishna2323. Thank you for letting me know.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Copy link
Contributor Author

@QichenZhu, the tests have been added. Could you please take a look when you get a chance?

@QichenZhu
Copy link
Contributor

QichenZhu commented Jun 4, 2025

Bug (NAB): Deleting workspace makes other admin see "Hmm... it's not here" while viewing inbox

Steps:

  1. As user A, create a workspace and add user B as an Admin
  2. As user B, click on Workspaces > click on the WS created by user A > click on Categories, then navigate back to inbox
  3. As user A, delete the workspace

Expected result: User B stays on Inbox screen
Actual result: User B sees "Hmm... it's not here" screen

Screen.Recording.2025-06-04.at.19.33.03.mov

@QichenZhu
Copy link
Contributor

Bug (NAB): Deleting workspace makes other member see "Hmm... it's not here" while viewing workspace settings

Steps:

  1. As user A, create a workspace and add user B as a member
  2. As user B, click on Workspaces > click on the WS created by user A
  3. As user A, delete the workspace

Expected result: User B sees the workspaces list screen
Actual result: User B sees "Hmm... it's not here" screen

Screen.Recording.2025-06-04.at.20.07.47.mov

Comment on lines 145 to 170
switch (navigationAction?.type) {
case 'goBack':
if (navigationAction.route) {
Navigation.goBack(navigationAction.route);
}
break;

let workspacesTabState = lastWorkspacesTabNavigatorRoute.state;
if (!workspacesTabState && lastWorkspacesTabNavigatorRoute.key) {
workspacesTabState = getPreservedNavigatorState(lastWorkspacesTabNavigatorRoute.key);
}
case 'navigate':
if (navigationAction.route) {
Navigation.navigate(navigationAction.route);
}
break;

// If there is a workspace navigator route, then we should open the workspace initial screen as it should be "remembered".
if (lastWorkspacesTabNavigatorRoute.name === NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR) {
const params = workspacesTabState?.routes.at(0)?.params as WorkspaceSplitNavigatorParamList[typeof SCREENS.WORKSPACE.INITIAL];
// Screens of this navigator should always have policyID
if (params.policyID) {
const workspaceScreenName = !shouldUseNarrowLayout ? getLastVisitedWorkspaceTabScreen() : SCREENS.WORKSPACE.INITIAL;
// This action will put settings split under the workspace split to make sure that we can swipe back to settings split.
case 'dispatch':
if (navigationAction.dispatchType && navigationAction.payload) {
navigationRef.dispatch({
type: CONST.NAVIGATION.ACTION_TYPE.OPEN_WORKSPACE_SPLIT,
payload: {
policyID: params.policyID,
screenName: workspaceScreenName,
},
type: navigationAction.dispatchType,
payload: navigationAction.payload,
});
}
return;
}
break;

Navigation.navigate(ROUTES.WORKSPACES_LIST.route);
});
}, [shouldUseNarrowLayout]);
case 'return':
default:
break;
}
Copy link
Contributor

@QichenZhu QichenZhu Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krishna2323, thanks for the refactor! Could you share why you prefer to return the action from the helper and perform it in the component, rather than doing it directly in the helper?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updating this, I think there is no reason to return an action from the helper.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just ping me when it's ready.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QichenZhu, ready for review 😅

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Comment on lines 59 to 61
const workspaceScreenName = !shouldUseNarrowLayout ? getLastVisitedWorkspaceTabScreen() : SCREENS.WORKSPACE.INITIAL;
navigationRef.dispatch({type: CONST.NAVIGATION.ACTION_TYPE.OPEN_WORKSPACE_SPLIT, payload: {policyID: params.policyID, screenName: workspaceScreenName}});
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the comment, reformatting the multiline code, and adding a return don't seem necessary.

Screenshot 2025-06-09 at 16 48 33

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the comment back and removed the return statement. I'm not sure about the formatting cause the updated one is correct according to the prettier rules:

printWidth: 190,

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@QichenZhu
Copy link
Contributor

QichenZhu commented Jun 9, 2025

An issue is blocking this PR. We can either fix it here or wait for it to be fixed on main.

Update: The blocking PR was reverted, so I'll resume the review today.

Copy link
Contributor

@QichenZhu QichenZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krishna2323, it's still possible to see the "not here" page if user B clicks Workspace immediately after user A deletes it. Still, I suggest merging this first since it's a good improvement that fixes the issue in most cases. There might be other causes, and we can keep digging. What do you think? @neil-marcellini

Screen.Recording.2025-06-12.at.20.53.54.mov

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@QichenZhu
Copy link
Contributor

@Krishna2323 I'm having trouble understanding these changes. Please go through the whole PR again and double check all changes are meaningful and have a clear purpose.

For example, the main branch has this code:

const topmostFullScreenRoute = rootState.routes.findLast((route) => isFullScreenName(route.name));

But this PR duplicates it in two places and adds optional chaining. In one place, it's written correctly:

const topmostFullScreenRoute = rootState?.routes?.findLast((route) => isFullScreenName(route.name));

But in the other place, only the first property access is optional, which is wrong:

const topmostFullScreenRoute = rootState?.routes.findLast((route) => isFullScreenName(route.name));

Also, the code below looks repetitive:

const {lastWorkspacesTabNavigatorRoute, workspacesTabState} = getWorkspaceNavigationRouteState();

const {rootState, lastWorkspacesTabNavigatorRoute} = getWorkspaceNavigationRouteState();

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Copy link
Contributor Author

I'm having trouble understanding these changes.

I agree that the changes are a bit difficult to grasp, but it's essentially the same logic that was removed from NavigationTabBar and moved to an action function, just broken into two parts. 😅

But this PR duplicates it in two places and adds optional chaining. In one place, it's written correctly:

You're correct about that—I refactored and removed the re-initialization of topmostFullScreenRoute from one place.

Also, the code below looks repetitive:

It's not repetitive; it's a call to a reusable function made in different files.

@QichenZhu
Copy link
Contributor

@Krishna2323 thanks for the explanation. I'm okay with it now.

@QichenZhu
Copy link
Contributor

@neil-marcellini, could you re-review this please?

@neil-marcellini neil-marcellini requested a review from a team July 3, 2025 21:19
@melvin-bot melvin-bot bot requested review from QichenZhu and removed request for a team July 3, 2025 21:19
@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2025

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@neil-marcellini
Copy link
Contributor

I have not been able to get to this pull request review yet. The past two weeks have been very busy and I've been focusing on internal PR reviews.

I'm going to be out of office July 4th through 16th. Working 0%. I trust that Tim will move it forward while I'm gone. Thank you 🙇

Copy link
Contributor

@QichenZhu QichenZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but another issue still happens: #62747 (review). Since it has a different cause and this PR is already quite big, I suggest making a separate PR.

@melvin-bot melvin-bot bot requested a review from neil-marcellini July 4, 2025 05:52
Comment on lines 66 to 71
const {lastWorkspacesTabNavigatorRoute, workspacesTabState} = getWorkspaceNavigationRouteState();
const params = workspacesTabState?.routes?.at(0)?.params as WorkspaceSplitNavigatorParamList[typeof SCREENS.WORKSPACE.INITIAL];

if (!lastWorkspacesTabNavigatorRoute || lastWorkspacesTabNavigatorRoute.name !== NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR || !params?.policyID) {
return undefined;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this logic need to be inside the selector? It sort of doesn't look like it does, so it's kind of a lot of logic to have run everytime the selector is ran (which is once for every policy in the collection). Can some of it be moved outside the selector?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to move the logic then we would need to set state for lastWorkspacesTabNavigatorRoute, workspacesTabState and update it when navigation is triggered, otherwise it won't work as expected.

Should I implement this?

    const initialNavigationRouteState = getWorkspaceNavigationRouteState();
    const [lastWorkspacesTabNavigatorRoute, setLastWorkspacesTabNavigatorRoute] = useState(initialNavigationRouteState.lastWorkspacesTabNavigatorRoute);
    const [workspacesTabState, setWorkspacesTabState] = useState(initialNavigationRouteState.workspacesTabState);
    const params = workspacesTabState?.routes?.at(0)?.params as WorkspaceSplitNavigatorParamList[typeof SCREENS.WORKSPACE.INITIAL];

    useEffect(() => {
        const newWorkspacesTabState = getWorkspaceNavigationRouteState();
        const newLastRoute = newWorkspacesTabState.lastWorkspacesTabNavigatorRoute;
        const newTabState = newWorkspacesTabState.workspacesTabState;

        setLastWorkspacesTabNavigatorRoute(newLastRoute);
        setWorkspacesTabState(newTabState);
    }, [navigationState]);

    const [lastViewedPolicy] = useOnyx(
        ONYXKEYS.COLLECTION.POLICY,
        {
            canBeMissing: true,
            selector: (val) => {
                if (!lastWorkspacesTabNavigatorRoute || lastWorkspacesTabNavigatorRoute.name !== NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR || !params?.policyID) {
                    return undefined;
                }

                return val?.[`${ONYXKEYS.COLLECTION.POLICY}${params.policyID}`];
            },
        },
        [navigationState],
    );

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so! I like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 🙇🏻


const navigateToWorkspacesPage = ({currentUserLogin, shouldUseNarrowLayout, policy}: Params) => {
const {lastWorkspacesTabNavigatorRoute, topmostFullScreenRoute} = getWorkspaceNavigationRouteState();
if (!topmostFullScreenRoute) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some comments to the code that clearly explains WHY each of these alternate navigation paths are necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments added.

],
});

(PolicyUtils.shouldShowPolicy as jest.Mock).mockReturnValue(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there also be a unit test for when shouldShowPolicy returns false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a test to handle the case when shouldShowPolicy returns false.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…yx selector.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tgolen tgolen merged commit 9e82f02 into Expensify:main Jul 7, 2025
20 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Jul 7, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

🚀 Deployed to staging by https://github.com/tgolen in version: 9.1.78-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.78-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@QichenZhu QichenZhu mentioned this pull request Jul 17, 2025
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants