Skip to content

Conversation

@NikkiWines
Copy link
Contributor

@NikkiWines NikkiWines commented Jun 29, 2025

Explanation of Change

Builds upon the logic added in to add custom IS Templates in New Expensify

Fixed Issues

$ #65111
PROPOSAL: N/A - internal

Tests

Tests

  1. Create a new account and create a workspace on that account
  2. Create a report with two expenses on it
  3. Create another report with one expense on it
  4. Ask @NikkiWines (or another internal engineer) to add an IS Template to your account named "Report Custom Export"
    • Note: this can be done by following these steps, I recommend using a simple template like this:
    Report ID,Merchant,Amount,Category,Expense Date
    <#list reports as report>
        <#list report.transactionList as expense>
            ${report.reportID},<#t>
            ${expense.merchant},<#t>
            ${(expense.amount/100)?string("0.00")},<#t>
            ${expense.category},<#t>
            ${expense.created}<#lt>
        </#list>
    </#list>
    

I'm working on adding a new template that tests expense level attributes and will test that when I've got that done

Reports > Expenses

  1. Navigate to the Reports page > Expenses
  2. Select 1 expense and click the 1 selected button, then Export
  3. Confirm you see the option to export via Report Custom Export
  4. Select all of the transactions and click the x selected button, then Export
  5. Confirm you still see the Report Custom Export option
  6. Select the Report Custom Export option and confirm you see a modal that states your export has begun
  7. Confirm you receive a message from concierge with your export file containing an entry for each of your selected expenses

Reports > Reports

  1. Navigate to the Reports page > Reports
  2. Select one expense from each report and click the 2 selected button, then Export
  3. Confirm you see option to export via Report Custom Export
  4. Select the Report Custom Export option and confirm you see a modal that states your export has begun
  5. Confirm you receive a message from concierge with your export file containing an entry for each of the expenses on your selected reports -- in this case, 2 expenses.

  1. Select one report and click the x selected button, then Export
  2. Confirm you see the option to export via Report Custom Export
  3. Select the Report Custom Export option and confirm you see a modal that states your export has begun
  4. Confirm you receive a message from concierge with your export file containing an entry for each of the expenses on your selected reports -- in this case, all of the expenses on your selected report.

Reports > Single Report View

  1. Click into the report with 2 expenses from the Reports > Reports view
  2. Select one expense and click on the 1 selected button, then Export
  3. Confirm you see the option to export via Report Custom Export
  4. Select the Report Custom Export option and confirm you see a modal that states your export has begun
  5. Confirm you receive a message from concierge with your export file containing an entry for each of the selected expenses on your report -- in this case, 1 expense.

  1. Select both expenses and click on the 2 selected button, then Export
  2. Confirm you see the Report Custom Export options
  3. Select the Report Custom Export option and confirm you see a modal that states your export has begun
  4. Confirm you receive a message from concierge with your export file containing an entry for each of the expenses on your selected report -- in this case, 2 expenses.

Inbox > Report

  1. Navigate to your inbox and find the report with two expenses on it
  2. Select one expense and click on the 1 selected button, then Export
  3. Confirm you see the Report Custom Export options
  4. Select the Report Custom Export option and confirm you see a modal that states your export has begun
  5. Confirm you receive a message from concierge with your export file containing an entry for each of the expenses on your selected report -- in this case 1 expense.

  1. Unselect all expenses, click on the More button, and then Export
  2. Confirm you see the Report Custom Export
  3. Select the Report Custom Export option and confirm you see a modal that states your export has begun
  4. Confirm you receive a message from concierge with your export file containing an entry for each of the expenses on your selected report
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline
  2. Repeat the same steps are you would online and confirm you see the modal notifying you that your export has begun
  3. Go back online
  4. Confirm you get a message from concierge with your exported file

QA Steps

Same as test steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@NikkiWines NikkiWines self-assigned this Jun 29, 2025
@NikkiWines NikkiWines changed the title [Export Templates] Add custom IS Templates to export dropdown [Export Templates][HOLD] Add custom IS Templates to export dropdown Jul 7, 2025
Base automatically changed from nikki-add-export-options to main August 5, 2025 17:41
@NikkiWines NikkiWines changed the title [Export Templates][HOLD] Add custom IS Templates to export dropdown [Export Templates] Add custom IS Templates to export dropdown Aug 5, 2025
@NikkiWines NikkiWines requested a review from francoisl August 5, 2025 19:19
@NikkiWines
Copy link
Contributor Author

@parasharrajat any way you want to also review this PR? 🙏 It's a small follow up to #64616, not as complicated as that one 😅

I'm working on adding the screen recordings now - let me know if you're interested in reviewing and if not I'll ask in the c+ channel 🙇

@parasharrajat
Copy link
Member

Sure @NikkiWines

@NikkiWines NikkiWines marked this pull request as ready for review August 5, 2025 20:36
@NikkiWines NikkiWines requested a review from a team as a code owner August 5, 2025 20:36
@melvin-bot melvin-bot bot requested review from DylanDylann and removed request for a team August 5, 2025 20:36
@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2025

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@NikkiWines NikkiWines removed the request for review from DylanDylann August 5, 2025 21:56
@parasharrajat
Copy link
Member

parasharrajat commented Aug 6, 2025

Screenshots

🔲 iOS / native

The backend is preventing login due to login issues.

🔲 iOS / Safari

06.08.2025_16.33.53_REC.mp4

🔲 MacOS / Desktop

06.08.2025_16.17.12_REC.mp4

🔲 MacOS / Chrome

06.08.2025_16.08.38_REC.mp4

🔲 Android / Chrome

06.08.2025_16.22.34_REC.mp4

🔲 Android / native

06.08.2025_16.19.55_REC.mp4

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@melvin-bot melvin-bot bot requested a review from carlosmiceli August 6, 2025 11:06
@melvin-bot
Copy link

melvin-bot bot commented Aug 6, 2025

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@carlosmiceli carlosmiceli merged commit 3921a4e into main Aug 6, 2025
26 checks passed
@carlosmiceli carlosmiceli deleted the nikki-add-custom-is-templates branch August 6, 2025 11:10
@NikkiWines
Copy link
Contributor Author

@carlosmiceli @parasharrajat thanks for the speedy review 🙌 I noticed one very small bug, so I've fixed it in #68003 if you all could give it a look quickly 🙇

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.90-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants