[Export Templates]Add account level and policy level in-app export options #68044

NikkiWines · 2025-08-06T16:52:41Z

~~HELD on https://github.com/Expensify/Auth/pull/16256/ and https://github.com/Expensify/Auth/pull/16591/~~

~~HELD on https://github.com/Expensify/Auth/pull/16653~~

Explanation of Change

Adds support for exporting reports and expenses via user created in-app export options

Follow up to #64616 and #65149

Fixed Issues

$ #67931
$ #68068

PROPOSAL: N/A internal

Tests

Create a new account and create two workspaces on that account
Create a report with two expenses on it on one expense
Create another report on the other workspace with one expenses on it
In Expensify Classic, navigate to Settings > Account > Preferences > CSV Export Formulas and add a new export template called "Account In-App Export Template" containing any of the following formulas (we're working on new adding more formulas but they're not currently supported)

{user:email} 
{report:id} 
{report:total} 
{report:currency} 
{report:policyname}

In Expensify Classic, navigate to Settings > Workspaces > Group > Your Workspace # 1 > Export Formulas, add a new export template called "Policy In-App Export Template" containing any of the above formulas

Reports > Expenses

Navigate to the Reports page > Expenses
Select one expense from the report that has 2 expenses on it, click the 1 selected button, then Export
Confirm you see the option to export via Account In-App Export Template and 'Policy In-App Export Template`
Select all of the transactions and click the x selected button, then Export
Confirm you see the Account In-App Export Template option only
Select one expense again and then select the Account In-App Export Template option and confirm you see a modal that states your export has begun
Confirm you receive a message from concierge with your export file containing an entry for your selected expense
Select one expense again and then select the Policy In-App Export Template option and confirm you see a modal that states your export has begun
Confirm you receive a message from concierge with your export file containing an entry for your selected expense

Reports > Reports

Navigate to the Reports page > Reports
Select one expense from each report and click the 2 selected button, then Export
Confirm you see the Account In-App Export Template option only
Select the report with 2 expenses on it and click the 2 selected button, then Export
Confirm you see the option to export via Account In-App Export Template and 'Policy In-App Export Template`
Select the Account In-App Export Template option and confirm you see a modal that states your export has begun
Confirm you receive a message from concierge with your export file containing an entry for each expense on the report
Select the same report again and then select the Policy In-App Export Template option and confirm you see a modal that states your export has begun
Confirm you receive a message from concierge with your export file containing an entry for each expense on the report

Reports > Single Expense Report View

Click into the report with 1 expense on it from the Reports > Reports view
Click into the one expense to bring up the Single Expense report view
Click on More and the Export
Confirm you see the option to export via Account In-App Export Template only
Select the Account In-App Export Template option and confirm you see a modal that states your export has begun
Confirm you receive a message from concierge with your export file containing an entry for one expense

Inbox > Report

Navigate to your inbox and find the report with two expenses on it
Select one expense and click on the 1 selected button, then Export
Confirm you see the option to export via Account In-App Export Template and 'Policy In-App Export Template`
Select the Account In-App Export Template option and confirm you see a modal that states your export has begun
Confirm you receive a message from concierge with your export file containing an entry for one expense
Select the same expense again and then select the Policy In-App Export Template option and confirm you see a modal that states your export has begun
Confirm you receive a message from concierge with your export file containing an entry for one expense
Navigate to your inbox and find the report with one expense on it
Select one expense and click on the 1 selected button, then Export
Confirm you see the option to export via Account In-App Export Template only

Verify that no errors appear in the JS console

Offline tests

Go offline
Repeat the same steps are you would online and confirm you see the modal notifying you that your export has begun
Go back online
Confirm you get a message from concierge with your exported file

Verify that no errors appear in the JS console

Offline tests

Go offline
Repeat the same steps are you would online and confirm you see the modal notifying you that your export has begun
Go back online
Confirm you get a message from concierge with your exported file

QA Steps

Same as testing steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-08-07.at.16.08.20.mov

MacOS: Desktop

NikkiWines · 2025-08-07T14:55:46Z

@parasharrajat this is the last one 🙌 it's ready for review though it'll be on hold until the Auth PRs are merged + deployed - but please give this a look through! 🙇

(Adding screen recordings now)

melvin-bot · 2025-08-07T14:55:54Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NikkiWines · 2025-08-07T14:58:15Z

src/components/MoneyReportHeader.tsx

+    const [csvExportLayouts] = useOnyx(ONYXKEYS.NVP_CSV_EXPORT_LAYOUTS, {canBeMissing: true});
+
+    // Collate the list of user-created in-app export templates
+    const customInAppTemplates = useMemo(() => {


The logic for getting export template options ( both IS templates and in-app ones) is pretty duplicated across MoneyReportHeader, useSelectedTransactionsActions, and SearchPage.

I'd like to de-dupe it, but in the interest of speed, let's keep that as a follow-up to this PR when we're not on as much of a time crunch 🙏

Sounds good.

parasharrajat · 2025-08-07T15:00:43Z

Sure

NikkiWines · 2025-08-07T15:08:07Z

thank you!!!

src/types/onyx/CsvExportLayout.ts

NikkiWines · 2025-08-07T15:52:03Z

made one change that fixed the account level export!

…export-options

src/components/MoneyReportHeader.tsx

src/hooks/useSelectedTransactionsActions.ts

src/pages/Search/SearchPage.tsx

NikkiWines · 2025-08-11T20:50:52Z

@parasharrajat i've got a backend PR to fix that issue ⏫ can you confirm if this is ready to go otherwise please 🙇?

Confirmed the backend PR fixes the issue:

NikkiWines · 2025-08-12T11:09:46Z

Backend PR has been merged and should be deployed today so taking this off hold

parasharrajat · 2025-08-12T12:28:49Z

Awesome. I will do the final review when backend is ready.

NikkiWines · 2025-08-12T12:56:59Z

nice, thank you! the backend only fixes that one small bug (policy level templates not appearing on mobile sometimes) so if you have time/wanted to check the other platforms feel free to start on those

francoisl · 2025-08-12T22:08:10Z

src/pages/Search/SearchPage.tsx

+            // If all of the transactions are on the same policy, add the policy-level in-app export templates as export options
+            if (selectedPolicyIDs.length === 1) {


For this, if you have more than 500 expenses and use "Select all matching items", it's possible some of the other non-loaded transactions will be on other policies, even though all the loaded ones are on the same policy.
I don't think it's necessarily a bug though, just putting it out there. I don't think there's an easy solution other than loading all expenses or making a API call that would return the unique policy IDs for a search query, but that's unoptimal.

Oh, yeah, good point... We could probably filter them out in the auth command since the report data we load before processing the formulas should have the policyID

Filter them out in what Auth command?
In the end, I don't think it's an issue if you export an expense or report with a layout that's defined in a different policy, right? Like, nothing can break, and the worst possible case is that your tags / employee custom fields / GL codes are defined differently, and the output is slightly inconsistent.

in ExportSearchWithTemplate but yes agreed it's not an urgent issue - I'll test it tomorrow to see what happens

francoisl · 2025-08-13T00:36:08Z

The last backend PR was just deployed, this should be all set for full review now 🚀

…export-options

parasharrajat · 2025-08-13T09:27:11Z

I will review shortly.

NikkiWines · 2025-08-13T14:29:40Z

@parasharrajat any update here? 🙇

parasharrajat · 2025-08-13T15:56:31Z

Just got back. I will test in 1 hour.

parasharrajat · 2025-08-13T18:21:04Z

Screenshots

🔲 iOS / native

14.08.2025_00.21.56_REC.mp4

🔲 iOS / Safari

14.08.2025_00.27.29_REC.mp4

🔲 MacOS / Desktop

14.08.2025_00.15.57_REC.mp4

🔲 MacOS / Chrome

08.08.2025_22.30.53_REC.mp4

08.08.2025_22.36.28_REC.mp4

🔲 Android / Chrome

14.08.2025_00.10.23_REC.mp4

🔲 Android / native

14.08.2025_00.04.01_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2025-08-13T19:01:00Z

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-08-13T19:01:17Z

It looks good to me.

Pending/not handled tasks.

Background click close on alert.
back button handling for alert.

NikkiWines · 2025-08-13T19:16:28Z

let's gooooooooo 🚀

francoisl · 2025-08-13T20:08:58Z

I can't recall if we already discussed this, but what's the point of displaying that intermediary Export option if it's the only option?

NikkiWines · 2025-08-13T20:32:21Z

I can't recall if we already discussed this, but what's the point of displaying that intermediary Export option if it's the only option?

That was handled as part of an issue before the Export Templates project but maybe @flaviadefaria knows the answer

OSBotify · 2025-08-13T20:32:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-13T22:00:11Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.1.94-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-15T03:42:28Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.94-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

NikkiWines added 2 commits August 6, 2025 17:49

add csvExportLayouts nvp

8c4f835

add account level and policy level export options to report headers

540109c

NikkiWines self-assigned this Aug 6, 2025

NikkiWines added 4 commits August 6, 2025 17:57

update nomenclature, add comments

a29598f

style

52cc6a2

add account and policy level export options to search page

719c37d

add policyName as a description for policy level in-app export tempaltes

b0f6b8a

NikkiWines requested review from francoisl and parasharrajat August 7, 2025 14:21

NikkiWines added 2 commits August 7, 2025 15:54

style/lint/typo

fa553c7

add customInAppTemplates to selectedTransactions

80e1b85

NikkiWines marked this pull request as ready for review August 7, 2025 14:55

NikkiWines requested a review from a team as a code owner August 7, 2025 14:55

melvin-bot bot requested review from eVoloshchak and removed request for a team August 7, 2025 14:55

NikkiWines commented Aug 7, 2025

View reviewed changes

NikkiWines removed the request for review from eVoloshchak August 7, 2025 15:12

update comments

3d5adfd

NikkiWines commented Aug 7, 2025

View reviewed changes

src/types/onyx/CsvExportLayout.ts Outdated Show resolved Hide resolved

conditionally pass policy ID for custom in-app exports

8345eec

NikkiWines added 2 commits August 7, 2025 22:27

Merge branch 'main' of github.com:Expensify/App into nikki-add-inapp-…

e5f7b1f

…export-options

lint fix

3e18a72

parasharrajat reviewed Aug 8, 2025

View reviewed changes

src/components/MoneyReportHeader.tsx Outdated Show resolved Hide resolved

parasharrajat reviewed Aug 8, 2025

View reviewed changes

src/hooks/useSelectedTransactionsActions.ts Outdated Show resolved Hide resolved

parasharrajat reviewed Aug 8, 2025

View reviewed changes

src/pages/Search/SearchPage.tsx Outdated Show resolved Hide resolved

NikkiWines changed the title ~~[Export Templates] Add account level and policy level in-app export options~~ [Export Templates][HOLD] Add account level and policy level in-app export options Aug 11, 2025

francoisl reviewed Aug 12, 2025

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into nikki-add-inapp-…

c45607d

…export-options

parasharrajat approved these changes Aug 13, 2025

View reviewed changes

melvin-bot bot requested a review from Beamanator August 13, 2025 19:00

NikkiWines changed the title ~~[Export Templates][HOLD] Add account level and policy level in-app export options~~ [Export Templates] Add account level and policy level in-app export options Aug 13, 2025

NikkiWines removed the request for review from Beamanator August 13, 2025 19:16

francoisl approved these changes Aug 13, 2025

View reviewed changes

francoisl merged commit 1636ea1 into main Aug 13, 2025
27 of 29 checks passed

francoisl deleted the nikki-add-inapp-export-options branch August 13, 2025 20:22

OSBotify mentioned this pull request Aug 13, 2025

Deploy Checklist: New Expensify 2025-08-13 #68475

Closed

64 tasks

melvin-bot bot mentioned this pull request Aug 15, 2025

[Due for payment 2025-08-22] [Export Templates] Add in-app export templates in New Expensify #67931

Closed

NikkiWines changed the title ~~[Export Templates] Add account level and policy level in-app export options~~ [Export Templates]Add account level and policy level in-app export options Aug 15, 2025

		// If all of the transactions are on the same policy, add the policy-level in-app export templates as export options
		if (selectedPolicyIDs.length === 1) {

[Export Templates]Add account level and policy level in-app export options #68044

[Export Templates]Add account level and policy level in-app export options #68044

Uh oh!

Conversation

NikkiWines commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Reports > Expenses

Reports > Reports

Reports > Single Expense Report View

Inbox > Report

Offline tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

NikkiWines commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Aug 7, 2025

Uh oh!

NikkiWines Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Aug 7, 2025

Uh oh!

NikkiWines commented Aug 7, 2025

Uh oh!

Uh oh!

NikkiWines commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NikkiWines commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NikkiWines commented Aug 12, 2025

Uh oh!

parasharrajat commented Aug 12, 2025

Uh oh!

NikkiWines commented Aug 12, 2025

Uh oh!

francoisl Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

NikkiWines Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francoisl Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

NikkiWines Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

francoisl commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Aug 13, 2025

Uh oh!

NikkiWines commented Aug 13, 2025

Uh oh!

parasharrajat commented Aug 13, 2025

Uh oh!

parasharrajat commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

NikkiWines commented Aug 6, 2025 •

edited

Loading

NikkiWines commented Aug 7, 2025 •

edited

Loading

NikkiWines Aug 7, 2025 •

edited

Loading

NikkiWines commented Aug 11, 2025 •

edited

Loading

NikkiWines Aug 12, 2025 •

edited

Loading

francoisl commented Aug 13, 2025 •

edited

Loading

parasharrajat commented Aug 13, 2025 •

edited

Loading