-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Bump react-native-onyx to 2.0.113 #65161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
|
@ikevin127 Will you review this one? |
This comment was marked as outdated.
This comment was marked as outdated.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
The data is rendered but not visible, weird Screen.Recording.2025-07-01.at.9.42.22.AM.mov |
|
I think it may be related to the recent react navigation upgrade, I will test in a bit (after completing testing on other platforms) |
|
Can you remove the |
|
The above bug seems fixed in #65202 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppBuild issues. NAB. iOS: HybridAppios.movMacOS: Chrome / Safariweb.movweb.2.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.75-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.76-5 🚀
|




Explanation of Change
Changelog:
Expensify/react-native-onyx#645
Expensify/react-native-onyx#640
Expensify/react-native-onyx#642
Fixed Issues
$ #64774
$ #64773
PROPOSAL:
Tests
Precondition: The user has sent a message with an attachment or a link
Precondition: a workspace has an employee with an expense without receipt
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop