Fix - added merge all snapshot config

[FitseTLT]

This pr creates a mergeAllPropsSnapshotKeys config so that the BE response which is member of those collection keys will be directly merged to snapshot data without picking props that only exist in the old snapshot data.

Details

Related Issues

Expensify/App#60116
Expensify/App#63295

Automated Tests

Manual Tests

Use https://github.com/FitseTLT/App/tree/fix-bump-onyx-mergeAllPropsSnapshotKeys to test it.
Precondition: The user has sent a message with an attachment or a link

1. Navigate to the Reports
2. Click on Chats
3. Click on the Status drop-down menu
4. Select Attachments
5. Click on the message item (not over the attachment)
6. The filter is non reset, the user can close RHP with the conversation and see the page with filter results.

Precondition: a workspace has an employee with an expense without receipt

1. From the admin side click on Reports tab
2. From the employee side Click on Reports tab
3. Click on expense without receipt
4. Upload image for this expense
5. From the admin side
6. The uploaded image should be displayed

Author Checklist

• I linked the correct issue in the ### Related Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

2025-06-06.01-37-29.mp4

Android: mWeb Chrome

2025-06-06.01-44-43.mp4

iOS: Native

iOS: mWeb Safari

2025-06-06.00-12-23.mp4

MacOS: Chrome / Safari

2025-06-06.00-07-14.mp4

MacOS: Desktop

2025-06-06.00-11-11.mp4

[FitseTLT]

cc @luacmartins @parasharrajat @iwiznia for review

[parasharrajat]

Small comment updates

[parasharrajat]

lGTM.

🎀 👀 🎀 C+ reviewed

[luacmartins]

@FitseTLT we have a perf test failing

[FitseTLT]

Dealt with the last comments but regarding the performance tests, it doesn't show the specific test that is failing. How can I run it locally, so that I can spot the exact test that is failing? cc @luacmartins @iwiznia TIA

[parasharrajat]

@FitseTLT May be you can open discussion on slack.

[luacmartins]

@FitseTLT you can see the commands run by the test here

These are the failures

🔴 Onyx init one call with 10k records to init > Duration deviation of 144.02 ms (64.12%) exceeded the allowed range of 10.00 ms (20.00%).
🔴 Onyx clear one call with 10k records to clean > Duration deviation of 14.72 ms (57.62%) exceeded the allowed range of 10.00 ms (20.00%).
🔴 Onyx mergeCollection one call with 10k heavy objects > Duration deviation of 76.71 ms (29.24%) exceeded the allowed range of 10.00 ms (20.00%).

[luacmartins]

I retried the tests and they failed with a different error now. Re-running again.

[FitseTLT]

Still failed BTW have you tried runiing it locally? on main

[luacmartins]

BTW have you tried runiing it locally? on main

I haven't. I'm not sure what's causing this. Maybe you can start a discussion in Slack and ping some people you see in the blame for the failing tests

[parasharrajat]

@FitseTLT Let's raise this on Slack and get it resolved as soon as possible. Thanks.

[FitseTLT]

Started

[FitseTLT]

@luacmartins I tested the perf test on a test pr that only adds comment on the main branch and it still failed I think we shouldn't be stuck for flacky tests.

[parasharrajat]

It passed now. 😄

[luacmartins]

@iwiznia do you wanna give this another review before we merge?

[iwiznia]

NAB

[luacmartins]

Perf tests are failing again 😞

[parasharrajat]

These tests 😢

[FitseTLT]

@luacmartins A new issue is created here to fix this flaky tests I think you can proceed.

[os-botify]

🚀 Published to npm in 2.0.112 🎉