Introduce telemetry logging for better CMD+K flow investigation#65183
Conversation
There was a problem hiding this comment.
From code correctness, it looks good.
There are a lot of logging going on and it would be awesome if we could ensure it does not impact performance negatively (these are mostly callback-driven logs, so there is a low chance they will flood the monitoring system but still).
Also, do we have a document where this telemetry values can be viewed as well in some more high level view than the code? It would be nice to have a bigger picture understanding of what we are introducing here and what is their purpose.
Thanks for the PR!
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-07-01.12.30.13.movAndroid: mWeb Chrome2025-07-01.12.27.36.moviOS: HybridApp2025-07-01.12.24.58.moviOS: mWeb Safari2025-07-01.12.22.32.movMacOS: Chrome / Safari2025-07-01.12.19.48.movMacOS: Desktop2025-07-01.12.19.48.mov |
|
LGTM ! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.74-2 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀
|
PR for
#expensify
Explanation of Change
This PR introduces additional profiling logs to catch information about app freezes during search usage.
Fixed Issues
Part of #64685
PROPOSAL: #64685 (comment)
Tests
Search modal A
Search modal B (Destkop / Desktop Web)
Reports sceen
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A - no QA tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop