Skip to content

[CP-stag] Revert "Bring back new sign-in page"#65374

Merged
chiragsalian merged 1 commit intomainfrom
revert-64786-bring-back-new-sign-in-page
Jul 2, 2025
Merged

[CP-stag] Revert "Bring back new sign-in page"#65374
chiragsalian merged 1 commit intomainfrom
revert-64786-bring-back-new-sign-in-page

Conversation

@chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Jul 2, 2025

Reverts #64786

Fixes

$ #65295
$ #65297
$ #65365
$ #65369

@chiragsalian chiragsalian self-assigned this Jul 2, 2025
@chiragsalian chiragsalian requested a review from a team as a code owner July 2, 2025 18:32
@melvin-bot melvin-bot bot requested review from Beamanator and removed request for a team July 2, 2025 18:32
@melvin-bot
Copy link

melvin-bot bot commented Jul 2, 2025

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@luacmartins
Copy link
Contributor

@chiragsalian It seems like this PR has a companion PR in Mobile-E, so following this SO I think the steps here should be:

  1. Merge Mobile-E PR
  2. Get the merge commit and bump the submodule in this PR to point to that commit
  3. Merge and CP this PR in App

@chiragsalian chiragsalian changed the title Revert "Bring back new sign-in page" [CP-stag] Revert "Bring back new sign-in page" Jul 2, 2025
@chiragsalian chiragsalian merged commit 5905c39 into main Jul 2, 2025
24 of 34 checks passed
@chiragsalian chiragsalian deleted the revert-64786-bring-back-new-sign-in-page branch July 2, 2025 20:14
@melvin-bot melvin-bot bot added the Emergency label Jul 2, 2025
@melvin-bot
Copy link

melvin-bot bot commented Jul 2, 2025

@chiragsalian looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@chiragsalian
Copy link
Contributor Author

Not a emergency. Its a straight revert since the PR has bugs found during testing.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 2, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jul 2, 2025
…sign-in-page

[CP-stag] Revert "Bring back new sign-in page"

(cherry picked from commit 5905c39)

(cherry-picked to staging by puneetlath)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.1.74-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants