Skip to content

[CP Staging] Revert "fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals" #65521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mountiny merged 1 commit into from
Jul 5, 2025
Merged

[CP Staging] Revert "fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals" #65521

mountiny merged 1 commit into from
Jul 5, 2025

Conversation

@mountiny
Copy link
Contributor

@mountiny mountiny commented Jul 5, 2025 •
edited
Loading

Reverts #61492

Staright revert

Fixes #65451
Fixes #65452

QA steps

Please tests based on the instructions from the issues linked above

ScreenRecording_07-05-2025.08-03-06_1.MP4
ScreenRecording_07-05-2025.08-01-06_1.MP4

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

This was referenced Jul 5, 2025
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #65521.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/65521/index.html
The build for Android was skipped iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/65521/NewExpensify.dmg https://65521.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@mountiny mountiny changed the title Revert "fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals" [CP Staging] Revert "fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals" Jul 5, 2025
@mountiny mountiny self-assigned this Jul 5, 2025
@mountiny mountiny marked this pull request as ready for review July 5, 2025 06:06
@mountiny mountiny requested a review from a team as a code owner July 5, 2025 06:06
@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team July 5, 2025 06:06
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2025

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi
srikarparsi approved these changes Jul 5, 2025
View reviewed changes
Copy link
Contributor

@srikarparsi srikarparsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight revert

@mountiny
Copy link
Contributor Author

mountiny commented Jul 5, 2025

This is a straight revert the lint failures are from the optional rules

@mountiny mountiny merged commit 5a371d3 into main Jul 5, 2025
26 of 32 checks passed
@mountiny mountiny deleted the revert-61492-@chrispader/fix-keyboard-opening-before-emoji-reaction-picker branch July 5, 2025 06:16
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jul 5, 2025
@mountiny mountiny removed the Emergency label Jul 5, 2025
OSBotify pushed a commit that referenced this pull request Jul 5, 2025
@mountiny @OSBotify
Merge pull request #65521 from Expensify/revert-61492-@chrispader/fix…
9962a97 
…-keyboard-opening-before-emoji-reaction-picker

[CP Staging] Revert "fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals"

(cherry picked from commit 5a371d3)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 5, 2025
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
Closed
63 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jul 5, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.76-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.76-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srikarparsi srikarparsi srikarparsi approved these changes

@amyevans amyevans Awaiting requested review from amyevans

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

4 participants

@mountiny @OSBotify @srikarparsi