fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals #61492

chrispader · 2025-05-06T14:34:59Z

Explanation of Change

Fixes an issue with the React Native TextInput component in combination with handling modals. By default, the composer on the ReportScreen would get re-focussed once a modal hides, because it becomes the "first responder" on iOS. This is not something that is handled by React Native directly, but is rather an internal logic in UIKit.

When we show two modals right after each other, we want to prevent the keyboard from opening, because it seems like a "flicker". This can only be achieved with a native fix in the React Native codebase directly.

This PR adds the necessary functionality to the React Native TextInput component, which let's us (explicitly) prevent re-focusing in specific scenarios. The following things have been added:

A command/ref function called prevenAutoFocusOnFirstResponderOnce, which let's us prevent the re-focus once (on the next focus)
A prop called preventFocusOnFirstResponder, which let's us set this behavior permanently. This can also be toggled to achieve the same effect as the command.

Because we're handling two modals after each other, the re-focusing of the TextInput after we close all modals will not work out-of-the-box, once we prevent the re-focusing after the first modal. Therefore, i added the necessary logic in JavaScript to achieve the same effect manually.

Fixed Issues

$ #54813
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open app
Go to report/chat
Focus composer by pressing on the text input
Long-press a message
Press "Add emoji reaction" bubble
Make sure that the keyboard doesn't open in-between modals
Select emoji or press on backdrop
Make sure that the composer is focused again.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_Recording_20250507_182945_New.Expensify.Dev.mp4

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-05-06.at.16.50.53.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-05-06.at.16.51.04.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-05-06T14:35:11Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2025-05-06T14:35:31Z

@francoisl Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-05-06T15:36:07Z

I will get the review going.

francoisl · 2025-05-06T16:40:06Z

It’s 845 commits behind (base commit: 1082941)

Can we also pull main into the branch so it's more up-to-date please? We've had issues in the past with super outdated branches that used code that was removed or modified in other files and didn't cause conflicts.

…i-reaction-picker

chrispader · 2025-05-08T10:09:18Z

@francoisl @parasharrajat merged main and just tested this PR in HybridApp as well, everthing works there as well! 🚀

parasharrajat · 2025-05-08T12:22:40Z

@chrispader I am trying to understand the solution here. We call focus manually on the composer after a modal hides

App/src/components/Modal/BaseModal.tsx

Line 130 in ac9a1b9

    
           ComposerFocusManager.refocusAfterModalFullyClosed(uniqueModalId, restoreFocusType);

.

So why can't we control this part to fix this issue? Just don't call this when we already know that a new modal is about to open. Have you already tried this?

chrispader · 2025-05-08T13:08:45Z

@chrispader I am trying to understand the solution here. We call focus manually on the composer after a modal hides

So why can't we control this part to fix this issue? Just don't call this when we already know that a new modal is about to open. Have you already tried this?

Yes i've tried this right in the beginning, but unfortunately the ComposerFocusManager is not what's causing the issue here. Even if you comment out this line or disable all the logic around this the keyboard is still opening between the two modals, because of the UIResponder's "first responder chain" logic in the native implementation of UITextField and UITextView.

You can test it out and see that the keyboard will still open when you comment out this line

…i-reaction-picker

parasharrajat · 2025-05-08T15:51:29Z

Yeah, I tested and it does. So first responder theory seems correct. I will test out this PR shortly.

…i-reaction-picker

francoisl · 2025-05-12T20:32:36Z

@parasharrajat did you have a chance to start reviewing?

parasharrajat · 2025-05-12T20:33:46Z

Yes. I will post updates after few hours.

src/libs/ReportActionComposeFocusManager.ts

chrispader · 2025-06-26T08:13:33Z

Build is taking forever, I tried a few times and it takes about an hour and fails.

@parasharrajat hmm weird, but i don't think it's related to this PR. I could build successfully

…i-reaction-picker

github-actions · 2025-06-26T16:52:43Z

🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here.

parasharrajat · 2025-06-26T17:11:01Z

Thanks @francoisl. I have been struggling to build since yesterday 🥹

francoisl · 2025-06-26T17:18:00Z

Haha no worries, feel free to ask anytime.

github-actions · 2025-06-26T17:36:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #61492.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61492/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61492/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61492/NewExpensify.dmg	https://61492.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

parasharrajat · 2025-06-28T10:02:12Z

BUG: mWeb Chrome: No Focus return to the composer after emoji picker is hidden. it works on staging.

28.06.2025_15.31.16_REC.mp4

…i-reaction-picker

chrispader · 2025-06-28T14:04:32Z

BUG: mWeb Chrome: No Focus return to the composer after emoji picker is hidden. it works on staging.

Cannot reproduce this one :/

XRecorder_20250628_01.mp4

XRecorder_20250628_04.mov

parasharrajat · 2025-06-29T08:03:07Z

I can reproduce this on real device as well as simulator. Please clear your cache and try with https://61492.pr-testing.expensify.com/

Steps:

Open any chat.
Click on composer to focus it.
Now click on the emoji picker sign on the composer.
Close the picker by clicking the the background area.
No focus on the composer.

github-actions · 2025-07-01T17:50:36Z

🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-07-01T18:34:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #61492.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61492/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61492/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61492/NewExpensify.dmg	https://61492.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

francoisl · 2025-07-02T04:19:34Z

I can reproduce this on real device as well as simulator. Please clear your cache and try with 61492.pr-testing.expensify.com

Steps:

I'm also unable to reproduce this with a physical device and with Browserstack, via https://61492.pr-testing.expensify.com/.

Rajat, does this happen 100% of the time for you? I tried to repro from different views where the composer is used, but I wonder if there's some additional requirement for the issue to happen that we're not seeing.
Otherwise, maybe let's not block on this and see if it pops up again in the future.

screen-20250701-205832.mp4

Screen.Recording.2025-07-01.at.21.12.33.mov

parasharrajat · 2025-07-02T05:14:47Z

Let me look at it again but if you can't reproduce this either then I think we can move ahead and see of QA finds it.

francoisl · 2025-07-03T06:34:02Z

Sounds good. Let us know how it goes. Other than that I think this is ready to merge? 🙏

parasharrajat · 2025-07-03T07:50:29Z

Screenshots

🔲 iOS / native

ScreenRecording_06-28-2025.14-37-26_1.MP4

🔲 iOS / Safari

ScreenRecording_06-28-2025.14-48-51_1.MP4

🔲 MacOS / Desktop

28.06.2025_14.41.06_REC.mp4

🔲 MacOS / Chrome

28.06.2025_14.36.13_REC.mp4

🔲 Android / Chrome

Screenrecorder-2025-07-03-12-02-04-856.mp4

🔲 Android / native

Screenrecorder-2025-07-03-12-27-34-363.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2025-07-03T07:51:38Z

Ready @francoisl

github-actions · 2025-07-03T19:44:37Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.1.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

github-actions · 2025-07-07T10:56:16Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.76-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

chrispader added 5 commits April 30, 2025 14:55

fix: display name of MarkdownTextInput

17b0c0d

fix: extract onFocus callback to memo function

f6409aa

fix: create RN patch

7520b6c

feat: allow closing non-top modals

9d5710e

fix: prevent keyboard from opening between modals

32fe391

chrispader requested a review from a team as a code owner May 6, 2025 14:35

chrispader mentioned this pull request May 6, 2025

[Due for payment 2025-11-06] [$500] Keyboard shows up briefly while switching to reaction emoji picker from context menu causing flickering #54813

Closed

8 tasks

melvin-bot bot requested review from francoisl and removed request for a team May 6, 2025 14:35

chrispader added 4 commits May 6, 2025 16:38

add comment explaining some of the close modal logic

3f6ee7a

fix: update patch

e39c07a

update patch

a502e10

only prevent textinput focus if composer was focused

9f59e61

fix: extract modal hide callback

5eed4a6

francoisl requested a review from parasharrajat May 6, 2025 16:36

Merge branch 'main' into @chrispader/fix-keyboard-opening-before-emoj…

ec1b36f

…i-reaction-picker

chrispader added 2 commits May 8, 2025 15:14

Merge branch 'main' into @chrispader/fix-keyboard-opening-before-emoj…

31eee5d

…i-reaction-picker

Merge branch 'main' into @chrispader/fix-keyboard-opening-before-emoj…

2ea921b

…i-reaction-picker

Merge branch 'main' into @chrispader/fix-keyboard-opening-before-emoj…

3daa5dd

…i-reaction-picker

francoisl reviewed May 14, 2025

View reviewed changes

src/libs/ReportActionComposeFocusManager.ts Outdated Show resolved Hide resolved

Merge branch 'main' into @chrispader/fix-keyboard-opening-before-emoj…

ce4d493

…i-reaction-picker

Merge branch 'main' into @chrispader/fix-keyboard-opening-before-emoj…

588cb7c

…i-reaction-picker

parasharrajat approved these changes Jul 3, 2025

View reviewed changes

melvin-bot bot requested a review from nkuoch July 3, 2025 07:51

francoisl approved these changes Jul 3, 2025

View reviewed changes

francoisl merged commit 9494e08 into Expensify:main Jul 3, 2025
26 checks passed

github-actions bot mentioned this pull request Jul 3, 2025

Deploy Checklist: New Expensify 2025-07-03 #65447

Closed

63 tasks

This was referenced Jul 3, 2025

iOS - Chat - Gap between sent message and composer after reacting to message with emoji #65451

Closed

iOS- Chat - When context menu is opened while in edit mode, message is hidden and report jumps #65452

Closed

BlameGPT mentioned this pull request Jul 4, 2025

App crash when doing basic export from Report Actions #65466

Closed

8 tasks

mountiny mentioned this pull request Jul 5, 2025

[CP Staging] Revert "fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals" #65521

Merged

perunt mentioned this pull request Aug 18, 2025

fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals #68640

Merged

54 tasks

cretadn22 mentioned this pull request Dec 17, 2025

[Due for payment 2026-01-06] [$375] mweb - Chat - Emoji picker not open if tap on the react button while composer is focused #74593

Closed

16 tasks

fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals #61492

fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals #61492

Uh oh!

Conversation

chrispader commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

melvin-bot bot commented May 6, 2025

Uh oh!

parasharrajat commented May 6, 2025

Uh oh!

francoisl commented May 6, 2025

Uh oh!

chrispader commented May 8, 2025

Uh oh!

parasharrajat commented May 8, 2025

Uh oh!

chrispader commented May 8, 2025

Uh oh!

parasharrajat commented May 8, 2025

Uh oh!

francoisl commented May 12, 2025

Uh oh!

parasharrajat commented May 12, 2025

Uh oh!

Uh oh!

chrispader commented Jun 26, 2025

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

parasharrajat commented Jun 26, 2025

Uh oh!

francoisl commented Jun 26, 2025

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

parasharrajat commented Jun 28, 2025

Uh oh!

chrispader commented Jun 28, 2025

Uh oh!

parasharrajat commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

francoisl commented Jul 2, 2025

Uh oh!

parasharrajat commented Jul 2, 2025

Uh oh!

francoisl commented Jul 3, 2025

Uh oh!

parasharrajat commented Jul 3, 2025

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

parasharrajat commented Jul 3, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

chrispader commented May 6, 2025 •

edited

Loading

parasharrajat commented Jun 29, 2025 •

edited

Loading