-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals #68640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Keyboard opens briefly between ReportActionContextMenu and EmojiPicker modals #68640
Conversation
…xtMenu and EmojiPicker modals"" This reverts commit cf8bf31.
|
|
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…fix-keyboard-opening-before-emoji-picker-opened-from-context-menu
|
Apologies for delay. I will take a look today. |
src/components/ActionSheetAwareScrollView/ActionSheetKeyboardSpace.tsx
Outdated
Show resolved
Hide resolved
src/components/ActionSheetAwareScrollView/useActionSheetKeyboardSpace.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are warnings on hideEmojiPicker
|
I will post testing results tomorrow morning. |
|
Seems to be working great. Still testing some special cases. |
Screenshots🔲 iOS / native12.09.2025_17.28.05_REC.mp4🔲 iOS / Safari12.09.2025_18.08.46_REC.mp4🔲 MacOS / Desktop12.09.2025_19.06.01_REC.mp4🔲 MacOS / Chrome12.09.2025_18.54.56_REC.mp4🔲 Android / Chrome12.09.2025_18.52.46_REC.mp4🔲 Android / native12.09.2025_18.50.27_REC.mp4 |
|
@perunt PR looks good. Can you please resolve conflicts and there are some suggestions above? |
|
I somehow saw this behaviour only once. But couldn't reproduce this again. 12.09.2025_19.01.00_REC.mp4 |
|
Requesting an ad hoc build here. cc: @nkuoch |
|
I just triggered it https://github.com/Expensify/App/actions/runs/18687193995 |
|
🚧 @nkuoch has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
src/components/ActionSheetAwareScrollView/useActionSheetKeyboardSpacing.ts
Show resolved
Hide resolved
|
@nkuoch Looks like adhoc failed here. Can we please trigger again? |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@parasharrajat @Julesssss i merged main, hopefully this fixes the ad-hoc builds. @Julesssss could you please trigger another one? |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment was marked as outdated.
This comment was marked as outdated.
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
Nice, Android worked on retry 🎉 |
|
Amazing. I will test it asap. |
Screenshots🔲 iOS / nativeScreenRecording_10-28-2025.15-38-08_1.mov🔲 iOS / Safari28.10.2025_16.09.14_REC.mp4🔲 MacOS / Desktop12.09.2025_19.06.01_REC.mp4🔲 MacOS / Chrome28.10.2025_16.02.10_REC.mp4🔲 Android / Chrome28.10.2025_16.06.06_REC.mp4🔲 Android / native28.10.2025_15.07.59_REC.mp428.10.2025_15.41.15_REC.mp4 |
parasharrajat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.40-0 🚀
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.40-0 🚀
|
|
One linked issue was found while testing this PR, will look into it tomorrow but lets try not to revert this if possible |
@Julesssss i'm looking into this! |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.40-1 🚀
|
@maddylewis
Explanation of Change
Fixes an issue with the React Native TextInput component in combination with handling modals. By default, the composer on the ReportScreen would get re-focussed once a modal hides, because it becomes the "first responder" on iOS. This is not something that is handled by React Native directly, but is rather an internal logic in UIKit.
When we show two modals right after each other, we want to prevent the keyboard from opening, because it seems like a "flicker". This can only be achieved with a native fix in the React Native codebase directly.
This PR adds the necessary functionality to the React Native TextInput component, which let's us (explicitly) prevent re-focusing in specific scenarios. The following things have been added:
A command/ref function called prevenAutoFocusOnFirstResponderOnce, which let's us prevent the re-focus once (on the next focus)
A prop called preventFocusOnFirstResponder, which let's us set this behavior permanently. This can also be toggled to achieve the same effect as the command.
Because we're handling two modals after each other, the re-focusing of the TextInput after we close all modals will not work out-of-the-box, once we prevent the re-focusing after the first modal. Therefore, i added the necessary logic in JavaScript to achieve the same effect manually.
This is the second iteration of fixing this bug(#61492). I added better focus management to the patch, updated the padding calculation flow, and fixed a few issues related to the jittery padding animation.
Also i make sure that this bugs is fixed here as well
Fixed Issues
$ #54813
$ #61608
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
1)
2)
3)
4)
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
rq.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop