Expo-av to expo-video migration

[Guccio163]

Explanation of Change

This PR introduces expo-video replacing expo-av Video usages.

Fixed Issues

$ #64846
PROPOSAL:

Tests

Video checklist introduced here below:

Checklist

• Inside chats (inbox):
  • Video can be played
  • Video can be played in chat thread (even nested one)
  • Video can be played after reload/navigating to another route
  • Video stops when changing routes / opening a thread with the video
  • Video works when navigating from other attachments via the arrows (not only from other videos, but also when navigating out of an image)
  • Video works when we enter the fullscreen play the video, leave the fullscreen and play it again
• Inside new report view:
  • Video can be played
  • Video can be played in chat thread (even nested one)
  • Video can be played after reload/navigating to another route
  • Video stops when changing routes / opening a thread with the video
  • Video works when navigating from other attachments via the arrows (not only from other videos, but also when navigating out of an image)
  • Video works when we enter the fullscreen play the video, leave the fullscreen and play it again
• In RHP:
  • Video can be played
  • Video can be played in chat thread (even nested one)
  • Video can be played after reload/navigating to another route
  • Video stops when changing routes / opening a thread with the video
  • Video works when navigating from other attachments via the arrows (not only from other videos, but also when navigating out of an image)
  • Video works when we enter the fullscreen play the video, leave the fullscreen and play it again
• In chats via search:
  • Video can be played
  • Video can be played in chat thread (even nested one)
  • Video can be played after reload/navigating to another route
  • Video stops when changing routes / opening a thread with the video
  • Video works when navigating from other attachments via the arrows (not only from other videos, but also when navigating out of an image)
  • Video works when we enter the fullscreen play the video, leave the fullscreen and play it again
• Video works fine (playing, fullscreen, mobile & desktop) on welcome to Expensify onboarding video (/onboarding/welcome-video url)
• Video works fine (playing, fullscreen, mobile & desktop) in Send Attachment Modal

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.mWeb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

iOS.mWeb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[dubielzyk-expensify]

Getting a bunch of CORS errors:

None of the images seem to working

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #66793.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/66793/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/66793/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/66793/NewExpensify.dmg	https://66793.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[ZhenjaHorbach]

After reloading the page on a full video screen
I don't see a loader

2025-11-06.14.12.35.mov

[mountiny]

@Guccio163 What si the latest here?

[Guccio163]

I'm investigating this bug, it seems like it's not a problem of not showing the loading indicator, but not playing the video when it's readyToPlay.
It goes even deeper, because is seems that the Navigation useEffect from PlaybackContext calls 'resetPlayerData' more than once (after that videoPlayer is set again) and the bug occurs exactly when readyToPlay event is generated after currentVideoPlayer reset and before being set - we are not playing the video because the currentVideoPlayer is not defined and it is not being set afterwards.

The issue is really hard to test, because it's a race condition one, so to notice it I have to reload 10-20 times and it takes some time, but I'm contacting @JakubKorytko who wrote that code - we have to step cautiously not to break something else in the process. I believe that this is the last issue, because @ZhenjaHorbach didn't report anything else.

[Guccio163]

@mountiny good news is that it is not a regression since it is reproducible on staging (still with expo-av of course), so we can potentially demote it to a follow-up and move on with the merge, WDYT? Below a full recording of trying to reproduce, issue at the end on 20th refresh so it's time-consuming, but reachable. I could fix it with @JakubKorytko after I'm done with the merge and potential reverts 💔

stagingRepro.mov

[mountiny]

Thanks! Lets be on a look out for any sort of deploy blockers 🙌

[mountiny]

Could you please always add explanation of why the rule has to be disabled and there is no reasonable way to do it otherwise?

[Guccio163]

It is a default way of initialising player in expo-video, should I write a comment right now?

[mountiny]

You can add it in a follow up.

[mountiny]

We have done extensive testing on this PR, QA has gone through full regression testing and @ZhenjaHorbach @Guccio163 confirmed all the found issues been resolved. Hence I will go ahead and merge, there might be some new edge cases that popped up so revert is possible, but let's keep this on staging for a full regression testing and maybe we will be able to fix them with clinical precision

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.59-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[Guccio163]

As the revert's incoming, we've decided with @mountiny to handle these reported issues at once and then merge them with a ready PR of the new branch. @blazejkustra also noticed that we didn't bump the podfile.lock, so it'll be just handled here then. If my comment is confirmed and the android.permissions issue (and revert cause) was similar to this and that, then expo-video fixes it in the 3.0.12 which I'll also bump in here 👀

Busy week incoming, I'll keep you noticed as I'll be handling these issues 🛠️

[Guccio163]

The draft PR for the changes following the revert: #75270

[OSBotify]

🚀 Deployed to production by https://github.com/grgia in version: 9.2.59-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌