Expo-av to expo-video migration after revert by Guccio163 · Pull Request #75270 · Expensify/App

Guccio163 · 2025-11-16T20:48:05Z

Explanation of Change

This PR introduces expo-video replacing expo-av Video usages. It is a second PR after this one because of the revert. It also aims to fix issues reported during the staging deployment.

Fixed Issues

$ #64846
$ #75203
$ #75206
$ #75207
$ #75212
$ #75214
$ #75215
$ #75216
$ #75234

PROPOSAL:

Tests

Video checklist introduced here below:

Checklist

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-09.at.15.52.16.mov

Android: mWeb Chrome

mWeb_android.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-iOS.mov

MacOS: Chrome / Safari

web480.mov

MacOS: Desktop

Not included, desktop no longer supported

…3-Guccio163/expo-video" This reverts commit 930127c, reversing changes made to 3efe8a0.

github-actions · 2025-11-16T20:48:13Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Guccio163 · 2025-11-16T22:20:27Z

Hi @mountiny this is a draft PR for the expo-video main issue after the revert and also linked subissues.

I already started with a revert of the revert, fixing the android.permission problem (prime cause of the revert) and updating the package.lock; I'll keep you posted with the incoming changes 👀

Also cc-ing @blazejkustra @war-in and @Skalakid who were part of the original PR, feel free to unsubscribe 🔙

codecov · 2025-11-16T22:42:23Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...rc/components/Attachments/AttachmentView/index.tsx	`50.57% <ø> (+0.57%)`	⬆️
src/components/FullscreenLoadingIndicator.tsx	`90.90% <100.00%> (ø)`
src/components/VideoPlayer/index.native.tsx	`100.00% <ø> (ø)`
src/components/VideoPlayer/index.tsx	`0.00% <ø> (ø)`
...ents/VideoPlayerContexts/PlaybackContext/index.tsx	`92.30% <100.00%> (+4.30%)`	⬆️
...xts/PlaybackContext/usePlaybackContextVideoRefs.ts	`100.00% <100.00%> (+25.00%)`	⬆️
...c/components/VideoPlayerContexts/VolumeContext.tsx	`76.92% <ø> (ø)`
src/components/VideoPopoverMenu/index.tsx	`100.00% <ø> (ø)`
src/components/FeatureTrainingModal.tsx	`86.74% <50.00%> (+1.03%)`	⬆️
...ts/VideoPlayerContexts/VideoPopoverMenuContext.tsx	`86.36% <66.66%> (-3.64%)`	⬇️
... and 8 more
... and 8 files with indirect coverage changes

Guccio163 · 2025-11-17T22:04:30Z

I think I've found a correct conditional to display loading spinner and hide controls a little bit longer when video doesn't start playing yet, but also don't trigger it on pausing or ending (occurs when using plain 'idle' status). This way the issue with 'NaN' duration shouldn't be possible to occur since the whole controls panel wouldn't be visible, but I safeguarded it with swapping bullish coalescing for OR operator to also filter NaN and swap it for 0.

…-fork into Guccio163/expo-video-after-revert

Guccio163 · 2025-11-24T22:21:20Z

Next 2 issues look like handled, during the development I think I've stumbled upon a bug originating in sharedElement logic, I'll focus on it next, hopefully with some help from @Skalakid 🙇

…-fork into Guccio163/expo-video-after-revert

…ideo-after-revert

mountiny · 2026-01-26T23:51:38Z

Asked for an update

mountiny

QA confirmed the regression is done, we can move this ahead.

@Guccio163 maybe soon

Guccio163 · 2026-01-27T00:24:54Z

@mountiny I guess that makes you a real wizard then 🪄 Can't wait to see it merged, let's hope for no reverts this time 👀

OSBotify · 2026-01-27T00:36:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

IuliiaHerets · 2026-01-27T19:58:24Z

Hi @Guccio163 and @mountiny. Which QA steps do we need to follow here?

OSBotify · 2026-01-27T20:11:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mountiny · 2026-01-27T23:02:58Z

@IuliiaHerets there are no specific test steps here as this pr changes everything related to video and audio in the app so all the regression tests you might have related to videos

Guccio163 · 2026-01-27T23:05:37Z

There is also a checklist created some time ago to test video player's behaviour; It's pasted in the 'Tests' section in PR's description, maybe it'll help 👀

IuliiaHerets · 2026-01-28T08:18:52Z

@mountiny @Guccio163, accordingly, I will check off this PR from the list, as these steps are already covered by regression tests.

OSBotify · 2026-01-28T22:56:21Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

daledah · 2026-01-29T12:14:06Z

@Guccio163 @mountiny @ZhenjaHorbach My IOS app crashed when I shared a video. It seems this problem was caused by this PR. Could you please check again?

error.mov

ZhenjaHorbach · 2026-01-29T12:15:17Z

@Guccio163 @mountiny @ZhenjaHorbach My IOS app crashed when I shared a video. It seems this problem was caused by this PR. Could you please check again?

error.mov

Did you update the main to the latest version, nodes, pods, and rebuild the iOS app?

blazejkustra · 2026-01-29T13:25:36Z

I can reproduce, and I have a fix. I'll post a PR asap

rojiphil · 2026-03-16T15:11:53Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

+        return isLoading && (!isPlaying || currentTime <= 0) && !isOffline && !hasError;
+    }, [currentTime, hasError, isLoading, isOffline, isPlaying]);
+    const shouldShowOfflineIndicator = useMemo(() => {
+        return isOffline && currentTime + bufferedPosition <= 0;


Relying on isOffline would end up showing offline indicator even for intermittent/slow network conditions. We fixed this in #82779

Guccio163 added 3 commits November 16, 2025 21:44

Revert "Merge pull request Expensify#75219 from Expensify/revert-6679…

66273c1

…3-Guccio163/expo-video" This reverts commit 930127c, reversing changes made to 3efe8a0.

bump expo-video version

3cdde6f

pod install standalone

8d877db

melvin-bot bot assigned Guccio163 Nov 16, 2025

Guccio163 mentioned this pull request Nov 16, 2025

Expo-av to expo-video migration #66793

Merged

84 tasks

fix patch name after expo-video version bump

3297106

Guccio163 added 3 commits November 17, 2025 11:09

comment param-reassign

8064a62

fix displaying spinner and hiding controls

adee8b9

safeguard duration NaN possibility

55ca561

Guccio163 added 10 commits November 18, 2025 13:54

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

415456c

…-fork into Guccio163/expo-video-after-revert

offline state handling issues

bab6e60

offline issues solutions

4aba116

fix for infinite loading

c929be7

setIsFirstLoad cleanup

cff0549

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

743d862

…-fork into Guccio163/expo-video-after-revert

style

c6ced8a

last conflict

27d989e

cleanup

feeca23

dont push Mobile Expensify

9f8f2b2

nyomanjyotisa mentioned this pull request Nov 26, 2025

[HOLD https://github.com/Expensify/App/pull/66793] Fix: Playback speed does not update when changing it in full screen mode #73271

Closed

54 tasks

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

20b8218

…-fork into Guccio163/expo-video-after-revert

mountiny mentioned this pull request Nov 30, 2025

[Due for payment 2026-02-04] Attachment - "You appear to be offline is displayed" as a watermark uploading video offline #75234

Closed

16 tasks

Guccio163 added 3 commits December 1, 2025 15:12

fixed playing after offline bugs and no autoplay when local source

6e9db16

play not working for first time

b9165d2

loading logic refactor

8dcd39b

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

8dd811b

…-fork into Guccio163/expo-video-after-revert

blazejkustra approved these changes Jan 22, 2026

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into Guccio163/expo-v…

fef0724

…ideo-after-revert

mountiny approved these changes Jan 27, 2026

View reviewed changes

mountiny merged commit 3a61f36 into Expensify:main Jan 27, 2026
38 checks passed

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

lanitochka17 mentioned this pull request Jan 27, 2026

[$250] Attachment - Unable to see the playback control to pause or playback a video #80678

Closed

7 tasks

marcochavezf mentioned this pull request Jan 28, 2026

Share - iOS app crashes when attempting to share an image #80710

Closed

7 tasks

daledah mentioned this pull request Jan 29, 2026

[Due for payment 2026-03-19] [$250] Web - Attachment - Can't play video on a narrow viewport size on IOU report #80421

Closed

7 tasks

blazejkustra mentioned this pull request Jan 29, 2026

[CP Staging] Fix app crashing when sharing videos on iOS #80884

Merged

52 tasks

rojiphil reviewed Mar 16, 2026

View reviewed changes

Conversation

Guccio163 commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Nov 16, 2025

Uh oh!

Guccio163 commented Nov 16, 2025

Uh oh!

codecov bot commented Nov 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Guccio163 commented Nov 17, 2025

Uh oh!

Guccio163 commented Nov 24, 2025

Uh oh!

mountiny commented Jan 26, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Guccio163 commented Jan 27, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

IuliiaHerets commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

mountiny commented Jan 27, 2026

Uh oh!

Guccio163 commented Jan 27, 2026

Uh oh!

IuliiaHerets commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

daledah commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Jan 29, 2026

Uh oh!

rojiphil Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Guccio163 commented Nov 16, 2025 •

edited

Loading

codecov bot commented Nov 16, 2025 •

edited by github-actions bot

Loading

daledah commented Jan 29, 2026 •

edited

Loading

ZhenjaHorbach commented Jan 29, 2026 •

edited

Loading