Improve navigation behavior when opening expenses from report #66852

huult · 2025-07-22T08:10:31Z

Details

Fixed Issues

$ #64012
PROPOSAL: #64012 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the Expensify app.
Navigate to Reports → Reports.
Tap on an expense.
Verify that tapping an expense or the Review button from the Reports view loads the top of the expense thread.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-07-22.at.15.01.11.mov

Android: mWeb Chrome

Screen.Recording.2025-07-22.at.15.02.14.mov

iOS: Native

Screen.Recording.2025-07-22.at.15.03.45.mov

iOS: mWeb Safari

Screen.Recording.2025-07-22.at.15.07.50.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-22.at.14.56.07.mov

MacOS: Desktop

Screen.Recording.2025-07-22.at.14.58.43.mov

melvin-bot · 2025-07-22T08:10:36Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2025-07-28T08:10:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

fedirjh · 2025-07-28T08:10:36Z

Screenshots/Videos

Android: HybridApp

CleanShot.2025-07-28.at.09.38.43.mp4

Android: mWeb Chrome

CleanShot.2025-07-28.at.09.32.16.mp4

iOS: HybridApp

CleanShot.2025-07-28.at.09.56.21.mp4

iOS: mWeb Safari

CleanShot.2025-07-28.at.09.13.04.mp4

MacOS: Chrome / Safari

CleanShot.2025-07-28.at.09.10.59.mp4

MacOS: Desktop

CleanShot.2025-07-28.at.10.05.18.mp4

src/pages/home/report/ReportActionsList.tsx

…ation-expense-from-reports

fedirjh

LGTM

…ation-expense-from-reports

huult · 2025-08-01T02:12:21Z

@jasperhuangg all your!

github-actions · 2025-08-04T19:59:18Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.1.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dangrous · 2025-08-05T16:41:22Z

hi! git bisect led me from this deploy blocker to this PR, specifically f9504e8

Can y'all take a look? we should probably revert if we can't find anything soon. Looks like #67867 is a similar issue, too.

huult · 2025-08-05T23:01:14Z

I am checking

huult · 2025-08-06T03:34:11Z

@dangrous

#67867 The RCA of this ticket is not related to this PR. Could you watch the video? Do you agree? If yes, I will check the RCA and post a proposal.

Screen.Recording.2025-08-06.at.10.30.54.mp4

github-actions · 2025-08-06T19:30:14Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

rojiphil · 2025-10-22T02:31:21Z

src/pages/home/report/ReportActionsList.tsx

            setIsFloatingMessageCounterVisible(false);
-            reportScrollManager.scrollToBottom();
+
+            if (!shouldScrollToEnd) {


Not including setIsFloatingMessageCounterVisible within the new condition shouldScrollToEnd made the New Message floating message to disappear. This was addressed in #71962

Improve navigation behavior when opening expenses from report

f9504e8

huult requested a review from a team as a code owner July 22, 2025 08:10

melvin-bot bot requested a review from fedirjh July 22, 2025 08:10

melvin-bot bot removed the request for review from a team July 22, 2025 08:10

fedirjh reviewed Jul 28, 2025

View reviewed changes

src/pages/home/report/ReportActionsList.tsx Outdated Show resolved Hide resolved

huult added 2 commits July 28, 2025 21:18

Merge remote-tracking branch 'upstream/main' into 64012-improve-navig…

89af20d

…ation-expense-from-reports

Add scroll-to-end behavior for transaction thread

3baa8e8

fedirjh approved these changes Jul 29, 2025

View reviewed changes

melvin-bot bot requested a review from jasperhuangg July 29, 2025 11:08

Merge remote-tracking branch 'upstream/main' into 64012-improve-navig…

e3a1536

…ation-expense-from-reports

jasperhuangg approved these changes Aug 1, 2025

View reviewed changes

jasperhuangg merged commit 81d455f into Expensify:main Aug 1, 2025
18 checks passed

github-actions bot mentioned this pull request Aug 4, 2025

Deploy Checklist: New Expensify 2025-08-04 #67808

Closed

BlameGPT mentioned this pull request Aug 4, 2025

Expense - App crashes after resolving duplicates #67810

Closed

8 tasks

mitarachim mentioned this pull request Aug 5, 2025

[PAY][$250] Expense - Transaction thread does not scroll down to show the sent message in Reports #67867

Closed

8 tasks

dangrous mentioned this pull request Aug 5, 2025

[Due for payment 2025-08-15] Reports - New message button appears and disappears when expense RHP is opened #67845

Closed

8 tasks

melvin-bot bot mentioned this pull request Aug 6, 2025

[Due for payment 2025-08-13] [$250] Improve navigation behavior when opening expenses from reports #64012

Closed

pac-guerreiro mentioned this pull request Sep 1, 2025

[63253] (1/2) Open transaction thread on top #68932

Merged

49 tasks

lorretheboy mentioned this pull request Sep 5, 2025

[Due for payment 2025-09-30] [$250] Expense - Last message behind the keypad after auto scrolling #69379

Closed

8 tasks

rojiphil reviewed Oct 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve navigation behavior when opening expenses from report #66852

Improve navigation behavior when opening expenses from report #66852

Uh oh!

huult commented Jul 22, 2025

Uh oh!

melvin-bot bot commented Jul 22, 2025

Uh oh!

fedirjh commented Jul 28, 2025 •

edited

Loading

Uh oh!

fedirjh commented Jul 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

fedirjh left a comment

Uh oh!

huult commented Aug 1, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

dangrous commented Aug 5, 2025

Uh oh!

huult commented Aug 5, 2025

Uh oh!

huult commented Aug 6, 2025

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

rojiphil Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Improve navigation behavior when opening expenses from report #66852

Improve navigation behavior when opening expenses from report #66852

Uh oh!

Conversation

huult commented Jul 22, 2025

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 22, 2025

Uh oh!

fedirjh commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Uh oh!

fedirjh commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots/Videos

Uh oh!

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Aug 1, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

dangrous commented Aug 5, 2025

Uh oh!

huult commented Aug 5, 2025

Uh oh!

huult commented Aug 6, 2025

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

rojiphil Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fedirjh commented Jul 28, 2025 •

edited

Loading

fedirjh commented Jul 28, 2025 •

edited

Loading