[63253] (1/2) Open transaction thread on top #68932

pac-guerreiro · 2025-08-21T16:33:05Z

Explanation of Change

This is part of the initial PR → #66165 (comment)
And related ticket → #63253

We need to split the changes from the original PR into smaller, more manageable PRs.

In this one, we aim to ensure that when opening the transaction thread, the view scrolls to the top by default rather than to the bottom

With fix:

478002387-ecb76fe7-c6cb-4c5a-adc3-4dd2744b991a.mp4

On staging:

478002409-1f1e9984-329d-4ca5-a2e6-21e465d0048d.mp4

Fixed Issues

$#63253
PROPOSAL:

Tests

Open Reports > Expense Reports
Open an expense report with multiple transactions on it
Open one transaction thread
Ensure the list is scrolled to the top

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android_Native.mp4

Android: mWeb Chrome

Android_Chrome.mp4

iOS: Native

iOS_Native.mp4

iOS: mWeb Safari

iOS_Safari.mp4

MacOS: Chrome / Safari

MacOS_Chrome.mp4

MacOS: Desktop

MacOS_Desktop.mp4

…d-start-at-the-top

melvin-bot · 2025-08-21T16:33:11Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/home/report/ReportActionsList.tsx

allgandalf · 2025-08-21T20:20:14Z

src/pages/home/report/useReportUnreadMessageScrollTracking.ts

        const unreadActionIndex = ref.current.unreadMarkerReportActionIndex;
        const hasUnreadMarkerReportAction = unreadActionIndex !== -1;
-        const unreadActionVisible = isInverted ? unreadActionIndex >= minIndex : unreadActionIndex <= maxIndex;
+        const unreadActionVisible = isInverted ? unreadActionIndex >= minIndex : unreadActionIndex < maxIndex;


why did we remove the equal to comparison here?

@allgandalf according to the commit history: fix: showing new message indicator pill on transaction thread

…hread-on-top

allgandalf

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-28.at.12.45.02.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-08-27.at.8.42.51.PM.mov

iOS: HybridApp

Screen.Recording.2025-08-28.at.12.58.11.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-08-27.at.8.47.12.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-27.at.7.34.03.PM.mov

MacOS: Desktop

Screen.Recording.2025-08-27.at.7.35.43.PM.mov

mountiny

Thanks! Lets try this out

…hread-on-top

allgandalf · 2025-08-27T15:24:22Z

Flaky tests mayb :(, if there are new commits , lets merge main again please

…hread-on-top

allgandalf · 2025-08-28T12:01:49Z

@pac-guerreiro lets merge main again, hopefully the test failure will go away

…hread-on-top

mountiny · 2025-08-28T15:20:25Z

This is coming from main

…hread-on-top

trjExpensify

"the view scrolls to the top by default rather than to the bottom"

What's the expectation on open if there's unread comment(s) in the thread? Should we be scrolling to the bottom in that instance or not? CC: @JmillsExpensify @Expensify/design

dubielzyk-expensify · 2025-09-01T01:16:34Z

What's the expectation on open if there's unread comment(s) in the thread? Should we be scrolling to the bottom in that instance or not? CC: @JmillsExpensify @Expensify/design

If we wanna go ahead and make this change a thing, I think it should still be anchored to the top even with unread comments because the "Unread comments" pill will be showing, right? So that'll give users a one tap to be scrolled down to the newest comment anyways. I think I prefer that to the inconsistency of it being scrolled to the top in some instances and bottom in others

pac-guerreiro · 2025-09-01T10:46:19Z

@trjExpensify @dubielzyk-expensify this behaviour is already implemented in production since #66852 was merged.

My PR will refactor the current implementation with a more robust one (slack thread)

shawnborton · 2025-09-01T13:34:00Z

I agree with Jon's comment above.

mountiny

I will move this one ahead as we have been waiting for it for a while. If we can adjust the case for unread messages or similar, we can follow up 🙌

OSBotify · 2025-09-01T15:20:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-02T22:46:25Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.1-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mountiny · 2025-09-04T09:35:09Z

@pac-guerreiro as this was reverted, lets try to work on v2 fixing the linked issues asap please 🙌 thank you!

OSBotify · 2025-09-05T19:33:24Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rinej and others added 7 commits August 14, 2025 12:21

open transaction thread on top

f474bac

Merge branch 'main' into when-opening-the-transaction-thread-it-shoul…

2bf7906

…d-start-at-the-top

fix: showing new message indicator pill on transaction thread

f2ce077

Merge branch 'main' into when-opening-the-transaction-thread-it-shoul…

ac1c7db

…d-start-at-the-top

fix(63253): scrolling to bottom on transaction threads

a82fa9a

Merge branch 'main' into when-opening-the-transaction-thread-it-shoul…

20b1d60

…d-start-at-the-top

Merge branch 'main' into when-opening-the-transaction-thread-it-shoul…

399a5d6

…d-start-at-the-top

pac-guerreiro requested a review from a team as a code owner August 21, 2025 16:33

melvin-bot bot assigned pac-guerreiro Aug 21, 2025

melvin-bot bot requested review from allgandalf and removed request for a team August 21, 2025 16:33

allgandalf reviewed Aug 21, 2025

View reviewed changes

src/pages/home/report/ReportActionsList.tsx Show resolved Hide resolved

allgandalf reviewed Aug 21, 2025

View reviewed changes

pac-guerreiro added 2 commits August 25, 2025 13:22

Merge branch 'main' into pac-guerreiro/fix/63253-1-open-transaction-t…

cb34d48

…hread-on-top

refactor(63253): apply suggestion

7154958

allgandalf approved these changes Aug 26, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny August 26, 2025 18:49

mountiny approved these changes Aug 26, 2025

View reviewed changes

Merge branch 'main' into pac-guerreiro/fix/63253-1-open-transaction-t…

4aab142

…hread-on-top

Merge branch 'main' into pac-guerreiro/fix/63253-1-open-transaction-t…

83b148b

…hread-on-top

allgandalf approved these changes Aug 27, 2025

View reviewed changes

allgandalf requested a review from mountiny August 27, 2025 19:29

Merge branch 'main' into pac-guerreiro/fix/63253-1-open-transaction-t…

a1a4968

…hread-on-top

pac-guerreiro added 2 commits August 29, 2025 13:04

Merge branch 'main' into pac-guerreiro/fix/63253-1-open-transaction-t…

ed2d579

…hread-on-top

Merge branch 'main' into pac-guerreiro/fix/63253-1-open-transaction-t…

de2dc89

…hread-on-top

pac-guerreiro requested a review from a team as a code owner August 29, 2025 12:50

rinej mentioned this pull request Aug 29, 2025

Open transaction thread on top #68528

Closed

51 tasks

trjExpensify reviewed Aug 30, 2025

View reviewed changes

mountiny approved these changes Sep 1, 2025

View reviewed changes

mountiny merged commit 8b28384 into Expensify:main Sep 1, 2025
21 checks passed

mountiny mentioned this pull request Sep 1, 2025

Better RHP view #67533

Closed

51 tasks

OSBotify mentioned this pull request Sep 2, 2025

Deploy Checklist: New Expensify 2025-09-02 #69693

Closed

mitarachim mentioned this pull request Sep 2, 2025

Expense - Blank space at the bottom in the transaction thread in self DM #69701

Closed

8 tasks

huult mentioned this pull request Sep 3, 2025

Update condition to scroll to end #68419

Closed

50 tasks

jponikarchuk mentioned this pull request Sep 3, 2025

[HOLD on PR 69073] Expense - Comment section shows up at the top while the report is loading #69732

Closed

8 tasks

mitarachim mentioned this pull request Sep 3, 2025

When expense thread has message, report does not scroll correctly when menu/keyboard is opened #69758

Closed

8 tasks

jponikarchuk mentioned this pull request Sep 3, 2025

Expense - New message button appears on top when the unread message is within the viewport #69761

Closed

8 tasks

mountiny mentioned this pull request Sep 3, 2025

[CP Staging] Revert "[63253] (1/2) Open transaction thread on top" #69784

Merged

pac-guerreiro mentioned this pull request Sep 11, 2025

[63253] (1/2) Open transaction thread on top #70250

Merged

49 tasks

[63253] (1/2) Open transaction thread on top #68932

[63253] (1/2) Open transaction thread on top #68932

Conversation

pac-guerreiro commented Aug 21, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 21, 2025

Uh oh!

Uh oh!

allgandalf Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

pac-guerreiro Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Aug 27, 2025

Uh oh!

allgandalf commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Aug 28, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Sep 1, 2025

Uh oh!

pac-guerreiro commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Sep 1, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 1, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

mountiny commented Sep 4, 2025

Uh oh!

OSBotify commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

allgandalf left a comment •

edited

Loading

allgandalf commented Aug 28, 2025 •

edited

Loading

pac-guerreiro commented Sep 1, 2025 •

edited

Loading