Skip to content

[CP Staging] Revert "[63253] (1/2) Open transaction thread on top"#69784

Merged
arosiclair merged 1 commit intomainfrom
revert-68932-pac-guerreiro/fix/63253-1-open-transaction-thread-on-top
Sep 3, 2025
Merged

[CP Staging] Revert "[63253] (1/2) Open transaction thread on top"#69784
arosiclair merged 1 commit intomainfrom
revert-68932-pac-guerreiro/fix/63253-1-open-transaction-thread-on-top

Conversation

@mountiny
Copy link
Contributor

@mountiny mountiny commented Sep 3, 2025 •
edited by arosiclair
Loading

Reverts #68932

$ #69701
$ #69732
$ #69761
$ #69758

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69784.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69784/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/69784/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69784/NewExpensify.dmg https://69784.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@arosiclair arosiclair marked this pull request as ready for review September 3, 2025 21:21
@arosiclair arosiclair requested review from a team as code owners September 3, 2025 21:21
@melvin-bot melvin-bot bot requested review from tylerkaraszewski and removed request for a team September 3, 2025 21:21
@melvin-bot
Copy link

melvin-bot bot commented Sep 3, 2025

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@arosiclair arosiclair merged commit 12d2426 into main Sep 3, 2025
21 of 25 checks passed
@arosiclair arosiclair deleted the revert-68932-pac-guerreiro/fix/63253-1-open-transaction-thread-on-top branch September 3, 2025 21:54
@melvin-bot
Copy link

melvin-bot bot commented Sep 3, 2025

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Sep 3, 2025
@arosiclair
Copy link
Contributor

arosiclair commented Sep 3, 2025

Straight revert

@mountiny mountiny changed the title Revert "[63253] (1/2) Open transaction thread on top" [CP Staging] Revert "[63253] (1/2) Open transaction thread on top" Sep 3, 2025
@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Sep 3, 2025
@arosiclair @OSBotify
Merge pull request #69784 from Expensify/revert-68932-pac-guerreiro/f…
25d0cf2 
…ix/63253-1-open-transaction-thread-on-top

Revert "[63253] (1/2) Open transaction thread on top"

(cherry picked from commit 12d2426)

(cherry-picked to staging by arosiclair)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 3, 2025
@OSBotify OSBotify mentioned this pull request Sep 3, 2025
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2025

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.1-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 4, 2025

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.1-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 5, 2025

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 5, 2025

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.2-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

pac-guerreiro added a commit to callstack-internal/Expensify-App that referenced this pull request Sep 8, 2025
@pac-guerreiro
Revert "Merge pull request Expensify#69784 from Expensify/revert-6893…
571b8af 
…2-pac-guerreiro/fix/63253-1-open-transaction-thread-on-top"

This reverts commit 12d2426, reversing
changes made to c001b19.
@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2025

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.2-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions github-actions bot mentioned this pull request Sep 12, 2025
Merged
49 tasks
@OSBotify OSBotify mentioned this pull request Sep 19, 2025
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Sep 19, 2025

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.16-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 23, 2025

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arosiclair arosiclair arosiclair approved these changes

@tylerkaraszewski tylerkaraszewski Awaiting requested review from tylerkaraszewski

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mountiny @arosiclair @OSBotify