-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update condition to scroll to end #68419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update condition to scroll to end #68419
Conversation
…ion-to-scroll-to-end
|
@fedirjh bump |
|
@huult Can you explain this PR? |
|
@fedirjh Which one do you not understand? |
|
@huult There are no details about the changes, what does it fix? |
|
I updated the condition to remove const shouldScrollToEnd =
(isExpenseReport(report) || isTransactionThread(parentReportAction)) && isSearchTopmostFullScreenRoute() && hasNewestReportAction && !unreadMarkerReportActionID;to const shouldScrollToEnd =
(isExpenseReport(report) || isTransactionThread(parentReportAction)) && isSearchTopmostFullScreenRoute() && !unreadMarkerReportActionID; |
@huult So the bug only appears if the chat is empty? |
|
@fedirjh yes, like #64012 (comment) |
|
@huult I couldn't replicate the bug in #64012 (comment) , even with empty messages expense. So I am not really sure if the code changes within this PR will fix the bug. |
|
@trjExpensify Can you please trigger a build on this PR? we want to make sure the bug is fully fixed with @heyjennahay's account #64012 (comment) |
|
Yep, web-only fine @fedirjh? |
|
@trjExpensify Yes, that works. |
|
Running 👍 |
|
🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
cc @heyjennahay Could you please test if the bug is fixed in https://68419.pr-testing.expensify.com/ |
|
I just tested and unfortunately the issue is still happening. And there seems to be a new issue too 😬 Video recording of test in the link you provided showing: |
|
@heyjennahay This only scrolls to the top when the expense is opened from the report tab cc @fedirjh |
|
Ah got it. Let me test again now |
|
@heyjennahay It looks like this issue is not related to this PR, I think. |
|
cc @truph01 |
Screen.Recording.2025-09-08.at.17.51.24.mov |
|
@truph01 #68932 (comment) I saw that the PR was reverted. Please wait for the new deploy to test again. |
Could you merge main? @huult |
…date-condition-to-scroll-to-end
|
@truph01 it's done |
|
@huult I just tested your solution in the latest main, and it looks like it doesn't work. Here is a video: Screen.Recording.2025-09-15.at.15.52.15.movHere is the code change I applied: const shouldScrollToEnd = (isExpenseReport(report) || isTransactionThread(parentReportAction)) && isSearchTopmostFullScreenRoute() && !unreadMarkerReportActionID; |
|
@huult Could you check my comment? |
|
@truph01 omg, sorry. I missed your comment. I’ll check this soon |
…ion-to-scroll-to-end
Screen.Recording.2025-09-22.at.09.26.23.mov@truph01 It’s working after I merged from main. |
|
@truph01 Could you check my comment? |



Details
Fixed Issues
$ #64012
PROPOSAL: #64012 (comment)
Tests
Same QA step
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-07-22.at.15.01.11.mov
Android: mWeb Chrome
Screen.Recording.2025-07-22.at.15.02.14.mov
iOS: Native
Screen.Recording.2025-07-22.at.15.03.45.mov
iOS: mWeb Safari
Screen.Recording.2025-07-22.at.15.07.50.mov
MacOS: Chrome / Safari
Screen.Recording.2025-07-22.at.14.56.07.mov
MacOS: Desktop
Screen.Recording.2025-07-22.at.14.58.43.mov