Fix deleted expense is unselected before disappearing #67216

bernhardoj · 2025-07-27T16:34:25Z

Explanation of Change

Fixed Issues

$ #66028
PROPOSAL: #66028 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open Reports
Create a new expense from FAB
On the Report page, delete the expense
Verify the expense is deleted without being unselected first

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

ndroid.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2025-07-27T16:34:31Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2025-07-30T10:40:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-22.at.23.22.03.mov

Android: mWeb Chrome

Screen.Recording.2025-08-22.at.23.24.34.mov

iOS: HybridApp

Screen.Recording.2025-08-25.at.00.19.07.mov

iOS: mWeb Safari

Screen.Recording.2025-08-25.at.00.20.59.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-21.at.17.47.55.web.mov

MacOS: Desktop

Screen.Recording.2025-08-21.at.17.49.49.desktop.mov

hoangzinh · 2025-07-30T10:46:24Z

src/libs/SearchUIUtils.ts

 */
 function isSearchResultsEmpty(searchResults: SearchResults) {
-    return !Object.keys(searchResults?.data).some((key) => key.startsWith(ONYXKEYS.COLLECTION.TRANSACTION));
+    return !Object.values(searchResults?.data).some((data) => 'transactionID' in data && (data as SearchTransaction)?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);


Should we keep the previous code, but add searchResults?.data[key].pendingAction != DELETE? Beside that, can you help to add unit test for this util please?

hoangzinh · 2025-08-19T23:41:47Z

cc @bernhardoj just in case you missed this PR

…re-remove

bernhardoj · 2025-08-20T07:28:46Z

@hoangzinh sorry, totally missed it. Updated!

hoangzinh · 2025-08-21T00:31:49Z

@bernhardoj looks like we need to fix some linters here.

bernhardoj · 2025-08-21T06:18:04Z

Fixed

hoangzinh · 2025-08-21T09:12:55Z

tests/unit/Search/SearchUIUtilsTest.ts

+                data: {
+                    personalDetailsList: {},
+                    // eslint-disable-next-line @typescript-eslint/naming-convention
+                    transactions_1: {


Suggested change

transactions_1: {

transactions_1805965960759424086: {

Any reason to change the ID?

ah, to be identical with transactionID in the body. Wdyt?

Ah, I didn't realize that. Updated!

hoangzinh · 2025-08-21T09:13:54Z

@bernhardoj please also don't forget to upload recordings for
Android: Native
Android: mWeb Chrome
iOS: Native

hoangzinh · 2025-08-21T10:57:34Z

Look like the issue is still reproducible in small screen device, when we delete expense in a group of expenses

Screen.Recording.2025-08-21.at.17.54.53.mov

…re-remove

bernhardoj · 2025-08-22T07:40:19Z

Fixed

hoangzinh · 2025-08-22T16:09:06Z

@bernhardoj Eslint is failed

…re-remove

bernhardoj · 2025-08-24T15:25:47Z

Fixed

hoangzinh

LGTM

OSBotify · 2025-08-25T16:59:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

luacmartins · 2025-08-25T20:39:46Z

FYI this PR broke grouped headers. Working on a fix here

OSBotify · 2025-08-26T11:19:26Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.1.99-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…xpense-is-unselected-before-remove" This reverts commit b4af02d, reversing changes made to 8c3b8be.

Revert "Merge pull request #67216 from `bernhardoj/fix/66028-deleted-expense-is-unselected-before-remove`

Revert "Merge pull request #67216 from `bernhardoj/fix/66028-deleted-expense-is-unselected-before-remove` (cherry picked from commit 5d0fd99) (cherry-picked to staging by AndrewGable)

OSBotify · 2025-08-28T01:17:11Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-08-28T01:38:39Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.0-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

s77rt · 2025-08-30T11:10:13Z

src/components/SelectionList/Search/TransactionGroupListItem.tsx

    useSyncFocus(pressableRef, !!isFocused, shouldSyncFocus);

+    const pendingAction =
+        (item.pendingAction ?? groupItem.transactions.every((transaction) => transaction.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE))


We should have checked if we have transactions in the first place. If we don't, this will return true even though we don't have any pending action.

Yeah, thanks for pointing @s77rt. @bernhardoj already convered it in this PR #69406

OSBotify · 2025-09-02T22:17:33Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T23:10:46Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

optimistically mark transaction as deleted and filter it out

ded66a7

bernhardoj requested a review from a team as a code owner July 27, 2025 16:34

melvin-bot bot requested review from hoangzinh and removed request for a team July 27, 2025 16:34

prettier

6797925

hoangzinh reviewed Jul 30, 2025

View reviewed changes

bernhardoj added 3 commits August 20, 2025 15:23

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

b6e364e

…re-remove

refactor

9836943

add test

618f4cd

lint

ee976da

hoangzinh reviewed Aug 21, 2025

View reviewed changes

bernhardoj added 3 commits August 22, 2025 13:18

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

56d94fc

…re-remove

fix test

9f2b693

fix pending delete report or transaction is not hidden

d439801

trjExpensify mentioned this pull request Aug 22, 2025

[Due for payment 2025-10-07] [$250] Android - Reports -When deleting expense while offline, selection mode is applied on preview #68716

Closed

8 tasks

bernhardoj added 3 commits August 24, 2025 22:23

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

f738b43

…re-remove

rename

f59f6e4

lint

0ce4d8d

hoangzinh approved these changes Aug 24, 2025

View reviewed changes

melvin-bot bot requested a review from AndrewGable August 24, 2025 17:22

AndrewGable approved these changes Aug 25, 2025

View reviewed changes

AndrewGable merged commit b4af02d into Expensify:main Aug 25, 2025
21 checks passed

This was referenced Aug 25, 2025

[Due for payment 2025-09-04] Search group headers don't render #69191

Closed

Fix grouped headers #69189

Merged

OSBotify mentioned this pull request Aug 26, 2025

Deploy Checklist: New Expensify 2025-08-26 #69233

Closed

bernhardoj mentioned this pull request Aug 27, 2025

Fix Create Expense button doesn't show after deleting all transactions in search page #66983

Merged

51 tasks

lakchote mentioned this pull request Aug 27, 2025

[Due for payment 2025-09-19] [Due for payment 2025-09-09] Reports - App crashes when deleting invoice via dropdown button when there is no selection #69344

Closed

8 tasks

AndrewGable added a commit that referenced this pull request Aug 27, 2025

Revert "Merge pull request #67216 from bernhardoj/fix/66028-deleted-e…

84f8197

…xpense-is-unselected-before-remove" This reverts commit b4af02d, reversing changes made to 8c3b8be.

AndrewGable mentioned this pull request Aug 27, 2025

Revert "Merge pull request #67216 from bernhardoj/fix/66028-deleted-expense-is-unselected-before-remove #69396

Merged

48 tasks

AndrewGable added a commit that referenced this pull request Aug 27, 2025

Merge pull request #69396 from Expensify/revert-pr-67216

5d0fd99

Revert "Merge pull request #67216 from `bernhardoj/fix/66028-deleted-expense-is-unselected-before-remove`

melvin-bot bot mentioned this pull request Aug 28, 2025

[Due for payment 2025-09-19] [$250] Reports - Deleted expense is unselected before disappearing #66028

Closed

8 tasks

s77rt reviewed Aug 30, 2025

View reviewed changes

Fix deleted expense is unselected before disappearing #67216

Fix deleted expense is unselected before disappearing #67216

Uh oh!

Conversation

bernhardoj commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 27, 2025

Uh oh!

hoangzinh commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Aug 19, 2025

Uh oh!

bernhardoj commented Aug 20, 2025

Uh oh!

hoangzinh commented Aug 21, 2025

Uh oh!

bernhardoj commented Aug 21, 2025

Uh oh!

hoangzinh Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

bernhardoj Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

bernhardoj Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Aug 21, 2025

Uh oh!

hoangzinh commented Aug 21, 2025

Uh oh!

bernhardoj commented Aug 22, 2025

Uh oh!

hoangzinh commented Aug 22, 2025

Uh oh!

bernhardoj commented Aug 24, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 25, 2025

Uh oh!

luacmartins commented Aug 25, 2025

Uh oh!

OSBotify commented Aug 26, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

s77rt Aug 30, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh Aug 31, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

bernhardoj commented Jul 27, 2025 •

edited

Loading

hoangzinh commented Jul 30, 2025 •

edited

Loading