#2 - Fix deleted expense is unselected before disappearing #69406

bernhardoj · 2025-08-28T03:56:24Z

Explanation of Change

Fixed Issues

$ #69344
$ #66028
PROPOSAL: #66028 (comment) #69344 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

#66028

Open Reports
Create a new expense from FAB
On the Report page, delete the expense
Verify the expense is deleted without being unselected first

#69344

Send at least 2 invoices to anyone
Open Reports > Expenses
Change the Type to Invoice
Select any invoice
Press the invoice to open it
Delete the invoice from the report screen
Verify the selected invoice is unselected

For mWeb/Android/iOS, it's not possible to open the report while selected, so just make sure the delete works.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…7216" This reverts commit 5d0fd99, reversing changes made to 659d7dd.

melvin-bot · 2025-08-28T03:56:30Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2025-08-31T09:44:42Z

Code looks good. @bernhardoj, can you resolve conflict so I can start recording for PR?

…re-remove

bernhardoj · 2025-09-01T03:55:53Z

Fixed

…re-remove

bernhardoj · 2025-09-01T13:15:32Z

The GH actions errors are unrelated to this PR>

hoangzinh · 2025-09-01T22:32:10Z

Look like they were fixed in the main branch. Do you mind merging the latest main branch again? @bernhardoj

…re-remove

bernhardoj · 2025-09-02T04:37:47Z

@hoangzinh done

hoangzinh · 2025-09-02T12:56:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-09-03.at.17.43.01.android.mov

Android: mWeb Chrome

Screen.Recording.2025-09-03.at.17.39.50.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-09-03.at.17.56.14.mov

iOS: mWeb Safari

Screen.Recording.2025-09-03.at.17.46.15.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-03.at.17.26.06.web.mov

MacOS: Desktop

Screen.Recording.2025-09-03.at.17.34.17.mov

hoangzinh · 2025-09-03T10:58:28Z

@bernhardoj can you resolve conflicts again?

…re-remove

bernhardoj · 2025-09-03T11:54:16Z

@hoangzinh done

hoangzinh

LGTM

AndrewGable · 2025-09-03T22:04:06Z

FYI Conflicts

…re-remove

bernhardoj · 2025-09-04T04:06:21Z

@AndrewGable Fixed

AndrewGable · 2025-09-04T17:31:04Z

Safe to ignore the failing test: https://expensify.slack.com/archives/C01GTK53T8Q/p1757006279943369

trjExpensify

Second time's a charm, as they say!

AndrewGable · 2025-09-09T23:04:26Z

Sorry keep forgetting to merge this one, conflicts again. Merging main should fix the tests too

hoangzinh · 2025-09-10T01:06:03Z

@bernhardoj, can you help resolve the conflict again? TIA

…re-remove

bernhardoj · 2025-09-10T04:15:06Z

@AndrewGable done

OSBotify · 2025-09-10T15:07:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-10T23:29:48Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.9-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-11T11:11:10Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.11-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-12T00:16:28Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

DylanDylann · 2025-10-31T03:47:02Z

src/components/SelectionList/Search/TransactionGroupListItem.tsx

    useSyncFocus(pressableRef, !!isFocused, shouldSyncFocus);

+    const pendingAction =
+        (item.pendingAction ?? (groupItem.transactions.length > 0 && groupItem.transactions.every((transaction) => transaction.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE)))


Coming from: #72406

When displaying report item, pendingAction here is calculated incorrectly, it will always be delete regardless of item.pendingAction

bernhardoj added 2 commits August 28, 2025 11:30

Revert "Merge pull request Expensify#69396 from Expensify/revert-pr-6…

f969dee

…7216" This reverts commit 5d0fd99, reversing changes made to 659d7dd.

remove from selected list when deleting expense

6b0aade

bernhardoj requested a review from a team as a code owner August 28, 2025 03:56

melvin-bot bot assigned bernhardoj Aug 28, 2025

melvin-bot bot requested review from hoangzinh and removed request for a team August 28, 2025 03:56

hoangzinh mentioned this pull request Aug 31, 2025

Fix deleted expense is unselected before disappearing #67216

Merged

51 tasks

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

1b7c1a0

…re-remove

bernhardoj requested a review from a team as a code owner September 1, 2025 03:55

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

92e681b

…re-remove

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

7187ab8

…re-remove

bernhardoj added 3 commits September 3, 2025 19:50

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

8064684

…re-remove

lint

1fd0e89

readd the fix

98bb7b0

hoangzinh approved these changes Sep 3, 2025

View reviewed changes

melvin-bot bot requested a review from AndrewGable September 3, 2025 13:06

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

617f3ef

…re-remove

AndrewGable previously approved these changes Sep 4, 2025

View reviewed changes

trjExpensify previously approved these changes Sep 5, 2025

View reviewed changes

mallenexpensify mentioned this pull request Sep 9, 2025

[Due for payment 2025-09-19] [$250] Reports - Deleted expense is unselected before disappearing #66028

Closed

8 tasks

Merge branch 'main' into fix/66028-deleted-expense-is-unselected-befo…

2f8bdf5

…re-remove

bernhardoj dismissed stale reviews from trjExpensify and AndrewGable via 2f8bdf5 September 10, 2025 04:14

fix type

859be15

AndrewGable approved these changes Sep 10, 2025

View reviewed changes

AndrewGable merged commit 8dc1074 into Expensify:main Sep 10, 2025
21 checks passed

OSBotify mentioned this pull request Sep 10, 2025

Deploy Checklist: New Expensify 2025-09-10 #70325

Closed

melvin-bot bot mentioned this pull request Sep 12, 2025

[Due for payment 2025-09-19] [Due for payment 2025-09-09] Reports - App crashes when deleting invoice via dropdown button when there is no selection #69344

Closed

8 tasks

DylanDylann reviewed Oct 31, 2025

View reviewed changes

DylanDylann mentioned this pull request Oct 31, 2025

[Awaiting checklist] [Due for payment 2025-10-30] [$250] Reports - Report with expenses shows strikethrough style after splitting expense offline #72406

Closed

16 tasks

#2 - Fix deleted expense is unselected before disappearing #69406

#2 - Fix deleted expense is unselected before disappearing #69406

Uh oh!

Conversation

bernhardoj commented Aug 28, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 28, 2025

Uh oh!

hoangzinh commented Aug 31, 2025

Uh oh!

bernhardoj commented Sep 1, 2025

Uh oh!

bernhardoj commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Sep 1, 2025

Uh oh!

bernhardoj commented Sep 2, 2025

Uh oh!

hoangzinh commented Sep 2, 2025 • edited by AndrewGable Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Sep 3, 2025

Uh oh!

bernhardoj commented Sep 3, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewGable commented Sep 3, 2025

Uh oh!

bernhardoj commented Sep 4, 2025

Uh oh!

AndrewGable commented Sep 4, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewGable commented Sep 9, 2025

Uh oh!

hoangzinh commented Sep 10, 2025

Uh oh!

bernhardoj commented Sep 10, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 11, 2025

Uh oh!

OSBotify commented Sep 12, 2025

Uh oh!

DylanDylann Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bernhardoj commented Sep 1, 2025 •

edited

Loading

hoangzinh commented Sep 2, 2025 •

edited by AndrewGable

Loading