Fix opening an expense report from Reports page shows the same report when open Inbox by bernhardoj · Pull Request #67437 · Expensify/App

bernhardoj · 2025-07-30T17:07:49Z

Explanation of Change

Fixed Issues

$ #67122
PROPOSAL: #67122 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have an expense
Web:

In Inbox, open any non-expense report
Open Reports page
Open any expense
Go back to Inbox
Verify it still shows the report from step 1

Android/iOS/mWeb:

Open Reports page
Go back to Inbox
Verify it shows the LHN

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

Uploading ios mweb.mp4…

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2025-07-30T17:07:54Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-08-02T22:56:05Z

src/pages/home/ReportScreen.tsx

+        if (!isReportInRHP) {
+            const {moneyRequestReportActionID, transactionID, iouReportID} = route.params;

-        // When we get here with a moneyRequestReportActionID and a transactionID from the route it means we don't have the transaction thread created yet
-        // so we have to call OpenReport in a way that the transaction thread will be created and attached to the parentReportAction
-        if (transactionID && currentUserEmail && !report) {
-            const iouReport = getReportOrDraftReport(iouReportID);
-            const iouAction = getReportAction(iouReportID, moneyRequestReportActionID);
-            const optimisticTransactionThread = buildTransactionThread(iouAction, iouReport, undefined, reportIDFromRoute);
-            openReport(reportIDFromRoute, undefined, [currentUserEmail], optimisticTransactionThread, moneyRequestReportActionID, false, [], undefined, transactionID);
+            // When we get here with a moneyRequestReportActionID and a transactionID from the route it means we don't have the transaction thread created yet
+            // so we have to call OpenReport in a way that the transaction thread will be created and attached to the parentReportAction
+            if (transactionID && currentUserEmail && !report) {
+                const iouReport = getReportOrDraftReport(iouReportID);
+                const iouAction = getReportAction(iouReportID, moneyRequestReportActionID);
+                const optimisticTransactionThread = buildTransactionThread(iouAction, iouReport, undefined, reportIDFromRoute);
+                openReport(reportIDFromRoute, undefined, [currentUserEmail], optimisticTransactionThread, moneyRequestReportActionID, false, [], undefined, transactionID);
+            }


looks like this cause a regression

Create a expense, dont open it.

go to reports page and open the expense

notice it shows not found page

Screen.Recording.2025-08-03.at.4.06.22.AM.mov

Yeah, I experience this and am really confused with it because sometimes I also experience it on main. Also, the updated code above will only run if it is not in RHP. In main, the code also only runs if it's not in RHP because in RHP, there is no moneyRequestReportActionID, transactionID, iouReportID params.

Can you recheck on main?

I just merged with main and can't repro it anymore.

not reproducible anymore! Thank you!

ishpaul777 · 2025-08-04T11:59:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-04.at.12.40.59.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-08-04.at.12.42.57.AM.mov

iOS: HybridApp

Screen.Recording.2025-08-04.at.12.19.15.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-08-03.at.4.04.05.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-03.at.3.25.27.AM.mov

MacOS: Desktop

Screen.Recording.2025-08-04.at.5.23.19.PM.mov

mountiny · 2025-08-04T13:06:48Z

How is this looking?

mountiny · 2025-08-04T17:01:34Z

src/components/Navigation/NavigationTabBar/index.tsx

+        const rootState = navigationRef.getRootState() as State<RootNavigatorParamList>;
+        const lastReportNavigator = rootState.routes.findLast((route) => route.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR);
+        const lastReportNavigatorState = lastReportNavigator && lastReportNavigator.key ? getPreservedNavigatorState(lastReportNavigator?.key) : undefined;
+        const lastReportRoute = lastReportNavigatorState?.routes.findLast((route) => route.name === SCREENS.REPORT);
+
+        if (lastReportRoute) {
+            const {reportID} = lastReportRoute.params as ReportsSplitNavigatorParamList[typeof SCREENS.REPORT];
+            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));
+            return;
+        }


@adamgrzybowski @WojtekBoman is this the cleanest way to write this logic? @bernhardoj Can you please add plain English comments here too? We should explain what this is doing and why. Thank you

Added comment. FYI, I copied this logic from the search tab

App/src/components/Navigation/NavigationTabBar/index.tsx

Lines 122 to 145 in 5eca224

const navigateToSearch = useCallback(() => {

if (selectedTab === NAVIGATION_TABS.SEARCH) {

return;

}

clearSelectedText();

interceptAnonymousUser(() => {

const rootState = navigationRef.getRootState() as State<RootNavigatorParamList>;

const lastSearchNavigator = rootState.routes.findLast((route) => route.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR);

const lastSearchNavigatorState = lastSearchNavigator && lastSearchNavigator.key ? getPreservedNavigatorState(lastSearchNavigator?.key) : undefined;

const lastSearchRoute = lastSearchNavigatorState?.routes.findLast((route) => route.name === SCREENS.SEARCH.ROOT);

if (lastSearchRoute) {

const {q, ...rest} = lastSearchRoute.params as SearchFullscreenNavigatorParamList[typeof SCREENS.SEARCH.ROOT];

const queryJSON = buildSearchQueryJSON(q);

if (queryJSON) {

const query = buildSearchQueryString(queryJSON);

Navigation.navigate(

ROUTES.SEARCH_ROOT.getRoute({

query,

...rest,

}),

);

return;

}

As @bernhardoj wrote, it's handled the same way for the Search page. However, this solution will soon need to be adjusted once the PR introducing route preloading is merged. @mountiny I'm considering what we should merge first? Should I adapt preloading to this solution or should this solution be adapted to preloading?

Seems like preloading is quite close so I will hold this PR

ishpaul777 · 2025-08-17T20:34:35Z

on HOLD for #66890

ishpaul777 · 2025-08-29T21:09:53Z

i see #66890 got merged, @bernhardoj can we resume work here?

bernhardoj · 2025-09-04T13:32:50Z

@ishpaul777 sorry, I missed this. I just retested it and can't reproduce it because OpenReport doesn't update the report's lastReadTime. I think it's a BE bug?

bernhardoj · 2025-09-08T06:03:13Z

^ Still same

ishpaul777 · 2025-09-08T08:42:02Z

on my radar will check this soon!

ishpaul777 · 2025-09-08T19:47:36Z

@bernhardoj i can still reproduce

Screen.Recording.2025-09-09.at.1.13.33.AM.mov

bernhardoj · 2025-09-09T07:36:47Z

Hmm, I can't reproduce it because lastReadTime isn't updated (so the last accessed report will still be the same, in the video, after opening the #admins room, the lastReadTime shows past date) when opening a report. I have tried changing accounts, but it still happens to me.

web.mp4

ishpaul777 · 2025-09-11T20:23:05Z

tried few times on different accounts i can still reproduce the orignal issue : /, cant reproduce what you are seeing @bernhardoj

Screen.Recording.2025-09-12.at.1.48.57.AM.mov

mountiny · 2026-01-06T10:24:13Z

@aimane-chnaif can you please review?

aimane-chnaif · 2026-01-06T11:01:02Z

src/components/Navigation/NavigationTabBar/index.tsx

+        const rootState = navigationRef.getRootState() as State<RootNavigatorParamList>;
+        const lastReportNavigator = rootState.routes.findLast((route) => route.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR);
+        const lastReportNavigatorState = lastReportNavigator && lastReportNavigator.key ? getPreservedNavigatorState(lastReportNavigator?.key) : undefined;
+        const lastReportRoute = lastReportNavigatorState?.routes.findLast((route) => route.name === SCREENS.REPORT);


As code is duplicated, can we define function on top of this file and use in both places?

aimane-chnaif · 2026-01-06T14:44:58Z

src/components/Navigation/NavigationTabBar/index.tsx

+
+        const lastReportRoute = getLastRoute(NAVIGATORS.REPORTS_SPLIT_NAVIGATOR, SCREENS.REPORT);
+        if (lastReportRoute) {
+            const {reportID} = lastReportRoute.params as ReportsSplitNavigatorParamList[typeof SCREENS.REPORT];


Is it possible that reportID might not exist or 0 here?
Just asking to avoid any unexpected regressions of being redirected to weird route, which leads to not found page or infinite loading.

might not exist

Hmm, I'm not sure, but it shouldn't be a problem because we will always use the last accessed report when the reportID is missing. Report route also accepts undefined reportID.

App/src/pages/home/ReportScreen.tsx

Lines 212 to 222 in e219999

const lastAccessedReportID = findLastAccessedReport(!isBetaEnabled(CONST.BETAS.DEFAULT_ROOMS), 'openOnAdminRoom' in route.params && !!route.params.openOnAdminRoom)?.reportID;

// It's possible that reports aren't fully loaded yet

// in that case the reportID is undefined

if (!lastAccessedReportID) {

return;

}

Navigation.isNavigationReady().then(() => {

Log.info(`[ReportScreen] no reportID found in params, setting it to lastAccessedReportID: ${lastAccessedReportID}`);

navigation.setParams({reportID: lastAccessedReportID});

});

or 0 here?

This one is possible if the user opens a report with ID 0, but this isn't a problem.

web.mp4

aimane-chnaif · 2026-01-06T15:14:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

src/components/Navigation/NavigationTabBar/index.tsx

mountiny · 2026-01-08T21:02:11Z

@codex review

chatgpt-codex-connector · 2026-01-08T21:20:40Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny · 2026-01-08T21:50:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecb143dbe1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/Navigation/NavigationTabBar/index.tsx

WojtekBoman

Changes look good to me :D

NAB: We can adjust types of getLastRoute params:
function getLastRoute(navigator: ValueOf<typeof NAVIGATORS>, screen: string)

mountiny

Thanks

mountiny · 2026-01-09T10:31:04Z

src/components/Navigation/NavigationTabBar/index.tsx

    shouldShowFloatingCameraButton?: boolean;
 };

+function getLastRoute(navigator: string, screen: string) {


Could you update the types in some future PR @bernhardoj please

@mountiny Here is the PR: #79203

OSBotify · 2026-01-09T10:46:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-09T20:00:34Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-10T02:19:40Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

aimane-chnaif · 2026-01-12T11:38:31Z

@bernhardoj please consider #79249, #79315 in v2

OSBotify · 2026-01-13T03:11:10Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

bernhardoj added 3 commits July 31, 2025 00:43

update type and adjust code

81870fa

navigate to the last report route

5c87ffa

lint

1a9aa39

bernhardoj requested a review from a team as a code owner July 30, 2025 17:07

melvin-bot bot requested a review from ishpaul777 July 30, 2025 17:07

melvin-bot bot removed the request for review from a team July 30, 2025 17:07

ishpaul777 reviewed Aug 2, 2025

View reviewed changes

bernhardoj added 2 commits August 3, 2025 23:12

Merge branch 'main' into fix/67122-open-existing-report

d85e748

prettier

710b10c

mountiny assigned bernhardoj Aug 4, 2025

ishpaul777 approved these changes Aug 4, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny August 4, 2025 15:10

mountiny reviewed Aug 4, 2025

View reviewed changes

bernhardoj added 2 commits August 5, 2025 11:44

Merge branch 'main' into fix/67122-open-existing-report

3e9a2d2

add comment

940962d

mountiny changed the title ~~Fix opening an expense report from Reports page shows the same report when open Inbox~~ [HOLD https://github.com/Expensify/App/pull/66890] Fix opening an expense report from Reports page shows the same report when open Inbox Aug 5, 2025

merged with main

c663075

bernhardoj requested a review from a team as a code owner September 4, 2025 13:34

mountiny changed the title ~~[HOLD https://github.com/Expensify/App/pull/66890] Fix opening an expense report from Reports page shows the same report when open Inbox~~ Fix opening an expense report from Reports page shows the same report when open Inbox Sep 11, 2025

bernhardoj changed the title ~~[HOLD https://github.com/Expensify/App/issues/72122] Fix opening an expense report from Reports page shows the same report when open Inbox~~ Fix opening an expense report from Reports page shows the same report when open Inbox Jan 6, 2026

prettier

46d1ebf

mountiny requested a review from aimane-chnaif January 6, 2026 10:23

aimane-chnaif reviewed Jan 6, 2026

View reviewed changes

dry-ing code

ecb143d

aimane-chnaif reviewed Jan 6, 2026

View reviewed changes

aimane-chnaif approved these changes Jan 6, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny January 6, 2026 15:14

mountiny reviewed Jan 7, 2026

View reviewed changes

src/components/Navigation/NavigationTabBar/index.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 8, 2026

View reviewed changes

src/components/Navigation/NavigationTabBar/index.tsx Outdated Show resolved Hide resolved

bernhardoj added 2 commits January 9, 2026 09:38

Merge branch 'main' into fix/67122-open-existing-report

69416e2

preserve all params

10e3c44

WojtekBoman approved these changes Jan 9, 2026

View reviewed changes

mountiny approved these changes Jan 9, 2026

View reviewed changes

mountiny merged commit 1b9ec77 into Expensify:main Jan 9, 2026
34 checks passed

OSBotify mentioned this pull request Jan 9, 2026

Deploy Checklist: New Expensify 2026-01-09 #79227

Closed

77 tasks

nlemma mentioned this pull request Jan 9, 2026

[Due for payment 2026-02-19] [Due for payment 2026-01-21] Expense - Not here page opens in Inbox after deleting report on Reports #79249

Closed

7 tasks

mitarachim mentioned this pull request Jan 12, 2026

[Due for payment 2026-02-19] [Due for payment 2026-01-21] Web - Copilot - Not here page opens on Inbox after switching account #79315

Closed

7 tasks

mountiny mentioned this pull request Jan 12, 2026

[CP Staging] Revert "Fix opening an expense report from Reports page shows the same report when open Inbox" #79331

Merged

ZhenjaHorbach mentioned this pull request Jan 12, 2026

[Due for payment 2026-01-21] App crashes when transitioning from OD to ND #79277

Closed

7 tasks

	const navigateToSearch = useCallback(() => {
	if (selectedTab === NAVIGATION_TABS.SEARCH) {
	return;
	}
	clearSelectedText();
	interceptAnonymousUser(() => {
	const rootState = navigationRef.getRootState() as State<RootNavigatorParamList>;
	const lastSearchNavigator = rootState.routes.findLast((route) => route.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR);
	const lastSearchNavigatorState = lastSearchNavigator && lastSearchNavigator.key ? getPreservedNavigatorState(lastSearchNavigator?.key) : undefined;
	const lastSearchRoute = lastSearchNavigatorState?.routes.findLast((route) => route.name === SCREENS.SEARCH.ROOT);

	if (lastSearchRoute) {
	const {q, ...rest} = lastSearchRoute.params as SearchFullscreenNavigatorParamList[typeof SCREENS.SEARCH.ROOT];
	const queryJSON = buildSearchQueryJSON(q);
	if (queryJSON) {
	const query = buildSearchQueryString(queryJSON);
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query,
	...rest,
	}),
	);
	return;
	}

	const lastAccessedReportID = findLastAccessedReport(!isBetaEnabled(CONST.BETAS.DEFAULT_ROOMS), 'openOnAdminRoom' in route.params && !!route.params.openOnAdminRoom)?.reportID;

	// It's possible that reports aren't fully loaded yet
	// in that case the reportID is undefined
	if (!lastAccessedReportID) {
	return;
	}
	Navigation.isNavigationReady().then(() => {
	Log.info(`[ReportScreen] no reportID found in params, setting it to lastAccessedReportID: ${lastAccessedReportID}`);
	navigation.setParams({reportID: lastAccessedReportID});
	});

Conversation

bernhardoj commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny commented Aug 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Aug 17, 2025

Uh oh!

ishpaul777 commented Aug 29, 2025

Uh oh!

bernhardoj commented Sep 4, 2025

Uh oh!

bernhardoj commented Sep 8, 2025

Uh oh!

ishpaul777 commented Sep 8, 2025

Uh oh!

ishpaul777 commented Sep 8, 2025

Uh oh!

bernhardoj commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jan 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Jan 6, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

mountiny commented Jan 8, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 8, 2026

Uh oh!

mountiny commented Jan 8, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

bernhardoj commented Jul 30, 2025 •

edited

Loading

bernhardoj Aug 3, 2025 •

edited

Loading

ishpaul777 commented Aug 4, 2025 •

edited

Loading

bernhardoj commented Sep 9, 2025 •

edited

Loading

ishpaul777 commented Sep 11, 2025 •

edited

Loading

aimane-chnaif Jan 6, 2026 •

edited

Loading

WojtekBoman left a comment •

edited

Loading