Conversation
…e report when open Inbox"
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1fef686ba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| name: CONST.TELEMETRY.SPAN_NAVIGATE_TO_INBOX_TAB, | ||
| op: CONST.TELEMETRY.SPAN_NAVIGATE_TO_INBOX_TAB, | ||
| }); | ||
|
|
||
| if (shouldUseNarrowLayout) { | ||
| Navigation.navigate(ROUTES.HOME); | ||
| return; | ||
| } | ||
|
|
||
| const lastReportRoute = getLastRoute(NAVIGATORS.REPORTS_SPLIT_NAVIGATOR, SCREENS.REPORT); | ||
| if (lastReportRoute) { | ||
| const {reportID, reportActionID, referrer, backTo} = lastReportRoute.params as ReportsSplitNavigatorParamList[typeof SCREENS.REPORT]; | ||
| Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID, reportActionID, referrer, backTo)); | ||
| return; | ||
| } | ||
|
|
||
| Navigation.navigate(ROUTES.HOME); |
There was a problem hiding this comment.
Preserve last inbox report when switching to Inbox
Always navigating to ROUTES.HOME here drops the preserved ReportsSplitNavigator state and rebuilds the split with only the HOME route; on wide layout, SplitRouter fills the central pane with the default SCREENS.REPORT, which uses ReportUtils.findLastAccessedReport for initialReportID (ReportsSplitNavigator.tsx lines 36–51). If the user just opened a report from the Search tab, that report becomes the last accessed, so switching to Inbox shows the same report again instead of the last Inbox report/list—reintroducing the “Inbox shows the report opened from Reports” regression.
Useful? React with 👍 / 👎.
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Straight revert |
…existing-report [CP Staging] Revert "Fix opening an expense report from Reports page shows the same report when open Inbox" (cherry picked from commit 3be066b) (cherry-picked to staging by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.99-1 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.17-0 🚀
|
|
Hi @mountiny. Can we check it off? |
|
Yes |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀
|
Reverts #67437
Fixed issues
$ #79249
$ #79315