Change Invite whisper actions

[parasharrajat]

Explanation of Change

Fixed Issues

#58811
$ #60690
$ #60689
PROPOSAL: #60690 (comment)

Tests

1. Open a workspace expense chat.
2. Mention a user who is not a member of the chat and workspace.
3. Verify a whisper message should pop up that asks:

"Invite <@user> to this workspace so they can submit expenses?"
[Invite to submit expenses]
[Invite to chat only]
[Do Nothing]

4. If they choose [Invite to submit expenses]:

   • verify Whisper is removed.
   • User is added to the workspace as member.
   • The system confirms the invite via a new whisper:

      “Great, you chose to invite them to the workspace! I've invited them and they'll 
       submit expenses in [invitee's workspace chat name](link new user’s workspace chat). 
       If you need to make them an admin, you can do that in the [workspace member 
       settings] (link to workspace member settings).”
       [Got it]
   

   • Clicking/tapping [Got it] will remove the confirmation whisper.

5. If they choose [Invite to chat only]

   • The whisper is dismissed, and the system posts a message from the inviter like it does today: “invited @user”

6. If no selection is made, the mentioned user isn’t invited to the workspace chat and the whisper remains.

7. If Do Nothing is selected, whisper hides and nothing happens.

   • Verify that mentioning multiple user also behaves same as mentioning a single user.

• Verify that no errors appear in the JS console

Offline tests

You can't take actions on whispers while offline.

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

31.07.2025_16.48.52_REC.mp4

Android: mWeb Chrome

31.07.2025_16.50.20_REC.mp4

iOS: Native

31.07.2025_16.54.16_REC.mp4

iOS: mWeb Safari

31.07.2025_16.56.10_REC.mp4

MacOS: Chrome / Safari

31.07.2025_16.46.25_REC.mp4

MacOS: Desktop

31.07.2025_17.00.44_REC.mp4

[carlosmiceli]

@rushatgabhane let's test/review this carefully so we avoid reverting this a 3rd time 🙏

[parasharrajat]

There was a small mistake that we didn't test properly last time. I hope that we will test it thoroughly this time.

[rushatgabhane]

kindly add it in test steps of the PR

[melvin-bot]

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

Updated.

@Pujan92 Sorry for the mention, Rushat will review this PR.

[carlosmiceli]

@parasharrajat @rushatgabhane The case that we should confirm it works this time is for multiple mentions, right?

[parasharrajat]

Yes, tested that too.

[parasharrajat]

But I will let Rushat confirm this.

[Pujan92]

@carlosmiceli plz unassign me here

[parasharrajat]

Bump @rushatgabhane

[rushatgabhane]

im blocked by this. API calls are returning error code 403 https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1754031321186819?thread_ts=1754031321.186819&cid=C01GTK53T8Q

…

On Fri, Aug 1, 2025, 15:01 Rajat ***@***.***> wrote: *parasharrajat* left a comment (Expensify/App#67496) <#67496 (comment)> Bump @rushatgabhane <https://github.com/rushatgabhane> — Reply to this email directly, view it on GitHub <#67496 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHCMM4KO6UTY2XDZJYRJX2D3LNJIBAVCNFSM6AAAAACCZSBN52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBUGMZTIOBUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[parasharrajat]

Use this https://expensify.slack.com/archives/C08CZDJFJ77/p1754049948307439

[carlosmiceli]

@rushatgabhane @parasharrajat just in case, let's check that we're not introducing this bug: #67651

Also, there's new conflicts.

[parasharrajat]

No, we haven't changed any logic around that feature.

[parasharrajat]

Updated.

[rushatgabhane]

@parasharrajat could you please include test steps for everything, or we might miss a few things

[parasharrajat]

Do you have few test cases in mind? I will think about it

Can you please share those? I will add them.

[parasharrajat]

I believe the test steps are correct according to the issue. Did I miss something?

[carlosmiceli]

@rushatgabhane small bump, we're so close 🙏

[carlosmiceli]

Yeah, that one passed but now there's a style failure 😅

[parasharrajat]

Man, now there is another check failure not related to this PR... @carlosmiceli Can we skip that, please?

[parasharrajat]

Done, removed that style.

[parasharrajat]

No design review needed. I just removed a extra style class which triggered the review.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.90-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[lanitochka17]

@parasharrajat Hello
According to steps in PR whisper message should be like this:
"
"Invite <@user> to this workspace so they can submit expenses?"
[Invite to submit expenses]
[Invite to chat only]
[Do Nothing]
"
But on sample videos it is different (Heads up, @user isn't a member of this room) and same as on staging now. Ignore copy in steps?
Thanks

[parasharrajat]

@carlosmiceli Any thoughts on why message is still old one?

[parasharrajat]

I think we are yet to enable that message from the backend. @lanitochka17 I think yes let's ignore the message for now.

[carlosmiceli]

@parasharrajat @rushatgabhane wait, how could the QA fail if you tested with the current BE? If you tested this PR and it worked, then it should also work for @lanitochka17 because there hasn't been any changes in the BE since the original BE PRs with the new whispers got merged and deployed.

[carlosmiceli]

@lanitochka17 not sure what videos you are mentioning, but I just did a quick test in staging:

[parasharrajat]

No, changes of this PR are working. QA is asking for the message Heads up,..... This should be different as per the issue "Invite <@user> to this workspace so they can submit expenses?"

[parasharrajat]

I remember that we talked about this earlier and decided to enable that message after this FE pr is merged. Trying to find that comment.

[carlosmiceli]

Ah, my bad, thanks for clarifying! I'll fix that then, don't worry about it. You can ignore that copy change then @lanitochka17 🙏

[lanitochka17]

@carlosmiceli ok, thanks

[puneetlath]

Sorry y'all. Reverted it again: #68157

[github-actions]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[parasharrajat]

Damn it. This PR is now giving me headaches.

New PR #68188

[parasharrajat]

I believe we should get different set of eyes for review on the new one.