Reapply Change Invite whisper actions logic

[parasharrajat]

Explanation of Change

Fixed Issues

#58811
$ #60690
$ #60689
PROPOSAL: #60690 (comment)

Tests

Note: Links will behave like normal links as you paste them in chat messages. So based on the context, navigating back will not always take you back to previous chat.

1. Open a workspace expense chat.
2. Mention a user who is not a member of the chat and workspace.
3. Verify a whisper message should pop up that asks:

"Invite <@user> to this workspace so they can submit expenses?"
[Invite to submit expenses]
[Invite to chat only]
[Do Nothing]

4. If they choose [Invite to submit expenses]:

   • verify Whisper is removed.
   • User is added to the workspace as member.
   • The system confirms the invite via a new whisper:

      “Great, you chose to invite them to the workspace! I've invited them and they'll 
       submit expenses in [invitee's workspace chat name](link new user’s workspace chat). 
       If you need to make them an admin, you can do that in the [workspace member 
       settings] (link to workspace member settings).”
       [Got it]
   

   • Clicking/tapping [Got it] will remove the confirmation whisper.

5. If they choose [Invite to chat only]

   • The whisper is dismissed, and the system posts a message from the inviter like it does today: “invited @user”

6. If no selection is made, the mentioned user isn’t invited to the workspace chat and the whisper remains.

7. If Do Nothing is selected, whisper hides and nothing happens.

   • Verify that mentioning multiple user also behaves same as mentioning a single user.

• Verify that no errors appear in the JS console

Offline tests

You can't take actions on whispers while offline.

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

31.07.2025_16.48.52_REC.mp4

Android: mWeb Chrome

31.07.2025_16.50.20_REC.mp4

iOS: Native

31.07.2025_16.54.16_REC.mp4

iOS: mWeb Safari

31.07.2025_16.56.10_REC.mp4

MacOS: Chrome / Safari

31.07.2025_16.46.25_REC.mp4

MacOS: Desktop

31.07.2025_17.00.44_REC.mp4

[melvin-bot]

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

This PR was originally reverted #67496 (comment). Its the new PR but we still need to fix the links which are coming from backend for now. I will check whether we can solve that from FE.

[abdulrahuman5196]

This PR was originally reverted #67496 (comment). Its the new PR but we still need to fix the links which are coming from backend for now. I will check whether we can solve that from FE.

@parasharrajat I don't understand this.

[parasharrajat]

So this PR does not solve the issue for which we reverted it. That issue is around the linking behaviour. These links are generated from the backend, so I think we need to update them correctly on the backend to fix that.

Here is the issue #68142. Do you think we can solve that issue on FE? If so, I will update this PR to solve it.

[carlosmiceli]

These links are generated from the backend, so I think we need to update them correctly on the backend to fix that.

I don't think this is accurate, all navigation is handled in the FE and we don't currently set backTo params anywhere in the BE.

[carlosmiceli]

I think it's just a matter of using getUrlWithBackToParam.

[parasharrajat]

I will create a custom renderer for the whisper action.

The only thing to check is getting this [invitee's workspace chat name](link new user’s workspace chat) link. Do we have this data on the action message? Or otherwise, I will have to use regex to get this link from backend message

[carlosmiceli]

I don't understand, can't we do something like this?:

App/src/libs/ReportUtils.ts

Line 5568 in abcdac0

Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountID.at(0), isSelfDMReport || shouldUseActiveRoute ? Navigation.getActiveRoute() : backTo));

[parasharrajat]

Yes, I will check whether we have members' expense report data somewhere or we can generate that in some way. I will let you know once I have gone through it.

[parasharrajat]

Asked on slack for best approach as I see multiple techniques and not sure what is best.

[parasharrajat]

@carlosmiceli I think we can directly merge this. There are no changes other than direct revert of revert PR.

[OSBotify]

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.98-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.98-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[ZhenjaHorbach]

Came from this issue
More context here

[parasharrajat]

You should tag us during the initial phase when the issue was reported if the issue is a regression. I can see that it was reported as a regression and original author and C+ was not tagged to solve it.

[ZhenjaHorbach]

This was not a deploy blocker and we fixed it as a default issue 🙂
#68076 (comment)

[parasharrajat]

Regression does not have to be DP. Anyway, thanks for handling that issue.