fix: selected report is not highlighted with a checkmark on confirmation page #67711

NJ-2020 · 2025-08-02T08:19:14Z

Explanation of Change

Report field is editable only if there're other eligible reports:
- Open (draft or un-submitted); and
- From the same destination workspace; and
- If create from global create menu, show all eligible reports from all workspaces
The selected report is highlighted with a checkmark in reports list

Fixed Issues

$ #62601
PROPOSAL: #62601 (comment)

Tests

Precondition: Created 1 workspace

Global create, no reports

Tap + from global create action and then > Create Expense
Enter amount, tap Show more
Verify that: The Report field is not editable

Global create, multiple workspaces | multiple reports

Go to any workspace
Create some reports
Click + from global create action and then > Create Expense
Enter amount, tap Show more
Verify that: Report field is editable + Shows all open (draft or un-submitted) reports + The latest open report from the default workspace is selected by default

Workspace chat, single report

Go to any workspace
Click + in the workspace composer chat
Create Expense
Enter amount, tap Show more
Verify that: The Report field is not editable and the single report is being selected

Workspace chat, multiple reports

Go to any workspace
Click + in the workspace composer chat
Create Expense
Enter amount, tap Show more
Verify that: Report field is editable + Shows all open (draft or un-submitted) reports from the current workspace + The latest open report from the current workspace is selected by default

Expense report

Go to any workspace chat
Open any report
Click + > Create Expense
Enter amount, tap Show more
Verify that: The Report field is not editable and the current report is being selected

Transaction report > Report push row

Go to any workspace chat
Open any report
Click the report menu field
Verify that: Report field is editable + Shows all open, draft, submitted, or un-submitted reports from all workspaces + The current report is selected by default

Add Expense

Go to any workspace chat
Open report directly or select any report preview

Click the Create Expense option on the dropdown menu
Enter amount, tap Show more
Verify that: The Report field is not editable and the current report is being selected

Self DM, no reports

Go to Self DM
Create an Expense
Click Send to someone and select any workspace
Verify that: The report field is not editable

Self DM, single report

Go to Self DM
Create an Expense
Click Send to someone and select any workspace
Verify that: The report field is not editable and make sure the single report is being selected

Self DM, multiple reports

Go to Self DM
Create an Expense
Click Send to someone and select any workspace
Verify that: Report field is editable + Shows all open (draft or un-submitted) reports from that selected workspace + The latest open report from the default workspace is selected by default

Search page

Open search/reports page
Select any Expense
Move Expense
Verify that: The lists shows all open, draft, submitted, or un-submitted reports from all workspaces

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

62601_native_android.mp4

Android: mWeb Chrome

62601_mweb_android.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-06.at.16.01.06.1.1.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-06.at.13.17.01.1.1.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-09-06.at.13.09.16.1.mp4

MacOS: Desktop

Screen.Recording.2025-09-06.at.13.34.37.1.mp4

melvin-bot · 2025-08-05T05:22:49Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-08-11T02:37:07Z

@NJ-2020 We have unit tests failure that is related to this PR. Can you check?

NJ-2020 · 2025-08-11T05:39:58Z

@dominictb Done, fixed

dominictb · 2025-08-12T14:51:33Z

Shows all reports

I think these instances in test steps should be Shows all open (draft or un-submitted) reports

dominictb · 2025-08-12T14:53:52Z

Expense report > report menu

I don't understand this test case. Can you link a recording here?

dominictb · 2025-08-12T14:56:20Z

Expense report

I see duplicated test cases for this

Also "expense" and "expense report" are different. I think you meant "Open any expense report" and "Select any expense report". The expense is the transaction itself where it opens the transaction thread report. While expense report is the report grouping one or multiple expenses. Please update accordingly.

dominictb · 2025-08-12T14:59:14Z

Search page

I think the last step should only be:

4. List shows all reports including the (submitted reports) from all workspaces

Because there's no difference between self DM and workspace chat in this case.

dominictb · 2025-08-12T15:00:58Z

Add Expense

This should be "Add expense button on report header or report preview". Then we need another test case for the "report preview" case:

dominictb · 2025-08-12T15:02:56Z

We also need a test case for editing report.

dominictb · 2025-08-12T15:10:33Z

BUG: Report field is editable even though there's only 1 eligible report if I create the expense from global create

Screen.Recording.2025-08-12.at.22.09.40.mov

dominictb · 2025-08-12T15:54:38Z

BUG: Report field is editable when creating expense from chat create button and there are a submitted report and an un-submitted report

Screen.Recording.2025-08-12.at.22.53.51.mov

dominictb · 2025-08-12T15:58:23Z

BUG: Report name changes from Expense Report 2025-08-12 to Expense Report #REPORT_ID when there is no eligible (open) expense report:

Screen.Recording.2025-08-12.at.22.56.41.mov

dominictb · 2025-08-12T16:08:05Z

BUG: #62977 (comment)

NJ-2020 · 2025-08-14T01:12:41Z

BUG: #67711 (comment)

@dominictb I am able to reproduce this on main as well

Screen.Recording.2025-08-14.at.08.06.32.mov

NJ-2020 · 2025-08-14T01:14:13Z

BUG: #62977 (comment)

I am not able to reproduce this

NJ-2020 · 2025-08-14T02:07:56Z

Updated test cases

NJ-2020 · 2025-08-14T02:16:23Z

Expense report > report menu
I don't understand this test case. Can you link a recording here?

@dominictb I mean this one:

Screen.Recording.2025-08-14.at.09.15.03.mov

dominictb · 2025-09-09T08:40:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-09-10.at.17.55.48-compressed.mov

Android: mWeb Chrome

Screen.Recording.2025-09-10.at.18.06.44-compressed.mov

iOS: HybridApp

Screen.Recording.2025-09-10.at.17.24.10-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-09-10.at.17.44.27-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-09.at.15.55.02-compressed.mov

MacOS: Desktop

dominictb · 2025-09-09T08:50:29Z

Self DM, multiple reports

Please update the step 4 of this test case to "Shows all open (draft or un-submitted) reports from that selected workspace"

dominictb · 2025-09-09T08:52:14Z

BUG: Report push row shows report A but report editor shows report B as selected in self DM:

Create several open reports in a workspace chat
Send an IOU from self DM to that workspace
Observe that Report push row shows report A but report editor shows another report as selected

NJ-2020 · 2025-09-10T03:30:24Z

@dominictb I am not able to reproduce this

BUG: Report push row shows report A but report editor shows report B as selected in self DM:

Could you please re-try again? Thanks

NJ-2020 · 2025-09-10T03:31:09Z

Please update the step 4 of this test case to

Done, updated

dominictb · 2025-09-10T10:42:28Z

Please update Tests to highlight the default selected report. For example:

Global create, multiple workspaces | multiple reports
5. Verify that:

The Report field is editable +
Shows all open (draft or un-submitted) reports

Verify that: Report field is editable + Shows all open (draft or un-submitted) reports + The latest open report from the default workspace is selected by default

Workspace chat, multiple reports
5. Verify that:

The Report field is editable
Shows all open (draft or un-submitted) reports from the current workspace

Verify that: Report field is editable + Shows all open (draft or un-submitted) reports from the current workspace + The latest open report from the current workspace is selected by default

Transaction report > Report push row
4. Verify that:

The Report field is editable
Shows all open, draft, submitted, or un-submitted reports from all workspaces

Verify that: Report field is editable + Shows all open, draft, submitted, or un-submitted reports from all workspaces + The current report is selected by default

Self DM, multiple reports
4. Verify that:

The report field is editable
Shows all open (draft or un-submitted) reports from that selected workspace

Verify that: Report field is editable + Shows all open (draft or un-submitted) reports from that selected workspace + The latest open report from the default workspace is selected by default

Whenever you mention reports, they should be open (draft or un-submitted) reports. For example, "Self DM, multiple reports" should be "Self DM, multiple open (draft or un-submitted) reports`.
Please update Explanation of Change like this:

- Report field is editable only if there're other eligible reports:
  - Open (draft or un-submitted); and
  - From the same destination workspace; and
  - If create from global create menu, show all eligible reports from all workspaces
- The selected report is highlighted with a checkmark in reports list

dominictb · 2025-09-10T10:43:02Z

After the above update, we're good to go. Thanks.

dominictb · 2025-09-10T11:04:29Z

BUG

For the "Global create, multiple workspaces | multiple reports" case:

When I select a workspace that has many open reports, the report field is editable and it shows all open reports from all workspaces
But if I changed to another workspace that has only 1 open report, the report field is not editable

Screen.Recording.2025-09-10.at.18.02.19.mov

I think for the second case, the report field should be editable since we're showing all reports from all workspaces, not just that single workspace.

luacmartins · 2025-09-10T12:29:52Z

Cool, @NJ-2020 let's address the comments above.

NJ-2020 · 2025-09-11T06:52:52Z

#67711 (comment)

@dominictb Thank you

NJ-2020 · 2025-09-11T06:53:39Z

BUG "Global create" menu selection, multiple workspaces | multiple reports" case ...:

Done, fixed ✅

NJ-2020 · 2025-09-11T06:54:26Z

Updated test cases

Please re-review

cc: @dominictb @luacmartins

Thanks

dominictb

🎀👀🎀 LGTM

luacmartins

LGTM

OSBotify · 2025-09-11T20:16:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-12T00:31:26Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.13-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-15T12:19:54Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.13-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

aimane-chnaif · 2025-11-06T14:26:41Z

src/components/MoneyRequestConfirmationListFooter.tsx

    // When creating an expense in an individual report, the report field becomes read-only
    // since the destination is already determined and there's no need to show a selectable list.
-    const shouldReportBeEditable = !!firstOutstandingReport && !isMoneyRequestReport(reportID, allReports);
+    const shouldReportBeEditable = (isFromGlobalCreate ? allOutstandingReports.length > 1 : availableOutstandingReports.length > 1) && !isMoneyRequestReport(reportID, allReports);


@NJ-2020 is there a reason for using allOutstandingReports when isFromGlobalCreate = true?
I think we can always use availableOutstandingReports like this:

const shouldReportBeEditable = availableOutstandingReports.length > 1 && !isMoneyRequestReport(reportID, allReports);

I get all eligible reports properly when create from FAB.

Issue: #73609 (comment)

@NJ-2020 bump above question. I see you're active on other PRs

@aimane-chnaif When creating an expense from the global action, we need to check all outstanding reports across workspaces so users can select a different report (from another workspace) if needed.

This was added here to fix this bug where workspaces with only one report, the report field aren't editable.

Thanks!

NJ-2020 changed the title ~~Fix/62601 1~~ fix: selected report is not highlighted with a checkmark on confirmation page Aug 2, 2025

NJ-2020 marked this pull request as ready for review August 5, 2025 05:22

NJ-2020 requested a review from a team as a code owner August 5, 2025 05:22

melvin-bot bot requested review from dominictb and removed request for a team August 5, 2025 05:22

NJ-2020 added 4 commits August 11, 2025 11:32

fix: 62601 - selected report is not highlighted with a checkmark

0c5cb65

fix some issues

3238cea

fix report menu item selection

7f67639

fix error

0e1c929

NJ-2020 force-pushed the fix/62601-1 branch from aa3096b to 0e1c929 Compare August 11, 2025 04:33

fix: test failure

e5540cf

NJ-2020 added 2 commits August 14, 2025 06:47

Merge remote-tracking branch 'origin' into fix/62601-1

85ea84a

fix report menu item (editable)

f12a992

fix conflicts

827ba9f

luacmartins self-requested a review September 10, 2025 10:57

NJ-2020 and others added 3 commits September 11, 2025 10:35

Merge branch 'Expensify:main' into fix/62601-1

414e4e8

fix global report menu item

f947ccc

fix eslint check

9a383ec

This comment was marked as off-topic.

Sign in to view

dominictb approved these changes Sep 11, 2025

View reviewed changes

luacmartins approved these changes Sep 11, 2025

View reviewed changes

luacmartins merged commit 3ab8482 into Expensify:main Sep 11, 2025
22 of 24 checks passed

OSBotify mentioned this pull request Sep 11, 2025

Deploy Checklist: New Expensify 2025-09-11 #70433

Closed

30 tasks

jponikarchuk mentioned this pull request Sep 12, 2025

Expense - Report field shows a caret and does not respond when clicked #70440

Closed

8 tasks

melvin-bot bot mentioned this pull request Sep 15, 2025

[Due for payment 2025-09-23] [$250] Expense - The selected report is not highlighted with a checkmark on confirmation page #62601

Closed

16 tasks

aimane-chnaif reviewed Nov 6, 2025

View reviewed changes

NJ-2020 mentioned this pull request Nov 20, 2025

[Due for payment 2025-12-12] [$250] Report field - When Workflows settings are disabled, Report field is only clickable with at least 2 reports #74740

Closed

16 tasks

aimane-chnaif mentioned this pull request Jan 13, 2026

Fix report field is enabled when there are no outstanding reports #79415

Merged

53 tasks

fix: selected report is not highlighted with a checkmark on confirmation page #67711

fix: selected report is not highlighted with a checkmark on confirmation page #67711

Uh oh!

Conversation

NJ-2020 commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 5, 2025

Uh oh!

dominictb commented Aug 11, 2025

Uh oh!

NJ-2020 commented Aug 11, 2025

Uh oh!

dominictb commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Aug 12, 2025

Uh oh!

dominictb commented Aug 12, 2025

Uh oh!

dominictb commented Aug 12, 2025

Uh oh!

dominictb commented Aug 12, 2025

Uh oh!

dominictb commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Aug 12, 2025

Uh oh!

dominictb commented Aug 12, 2025

Uh oh!

dominictb commented Aug 12, 2025

Uh oh!

dominictb commented Aug 12, 2025

Uh oh!

NJ-2020 commented Aug 14, 2025

Uh oh!

NJ-2020 commented Aug 14, 2025

Uh oh!

NJ-2020 commented Aug 14, 2025

Uh oh!

NJ-2020 commented Aug 14, 2025

Uh oh!

dominictb commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Sep 9, 2025

Uh oh!

dominictb commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NJ-2020 commented Sep 10, 2025

Uh oh!

NJ-2020 commented Sep 10, 2025

Uh oh!

dominictb commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Sep 10, 2025

Uh oh!

dominictb commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Sep 10, 2025

Uh oh!

NJ-2020 commented Sep 11, 2025

Uh oh!

NJ-2020 commented Sep 11, 2025

Uh oh!

NJ-2020 commented Sep 11, 2025

Uh oh!

NJ-2020 commented Aug 2, 2025 •

edited

Loading

dominictb commented Aug 12, 2025 •

edited

Loading

dominictb commented Aug 12, 2025 •

edited

Loading

dominictb commented Sep 9, 2025 •

edited

Loading

dominictb commented Sep 9, 2025 •

edited

Loading

dominictb commented Sep 10, 2025 •

edited

Loading

dominictb commented Sep 10, 2025 •

edited

Loading