Fix report field is enabled when there are no outstanding reports #79415

bernhardoj · 2026-01-13T05:41:56Z

Explanation of Change

Fixed Issues

$ #78788
PROPOSAL: #78788 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition:

Use a new account as admin
Turn off Submission frequency, Add approvals, and Make or track payments in the Workflows settings.
Admin has invited User B to the workspace.
Admin's workspace chat is empty or does not have an open report.

[User B] Create an empty report in workspace chat.
[Admin] Open FAB > Create expense > Manual.
[Admin] Enter amount > Next.
[Admin] If needed, change the destination to workspace from precondition.
[Admin] Verify the Report field is not enabled

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweg.mp4

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-01-13T05:42:02Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-01-13T05:50:39Z

Additional video:

others.mp4

codecov · 2026-01-13T05:58:58Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../components/MoneyRequestConfirmationListFooter.tsx	`84.13% <100.00%> (-0.17%)`	⬇️
src/hooks/useOutstandingReports.ts	`100.00% <100.00%> (ø)`
...es/iou/request/step/IOURequestEditReportCommon.tsx	`76.38% <100.00%> (+0.52%)`	⬆️
...rc/pages/iou/request/step/IOURequestStepReport.tsx	`0.00% <0.00%> (ø)`
... and 51 files with indirect coverage changes

aimane-chnaif · 2026-01-13T14:27:48Z

Please confirm that this doesn't reintroduce the following issues:

[$250] Expense - Report field opens not here page when workspace has outstanding report and no draft #73609
fix: selected report is not highlighted with a checkmark on confirmation page #67711 (comment)

chatgpt-codex-connector · 2026-01-13T14:38:05Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

bernhardoj · 2026-01-13T15:59:26Z

#73609

1.mp4

#67711 (comment)

2.mp4

@aimane-chnaif all fine

aimane-chnaif · 2026-01-16T12:45:52Z

One more to confirm no regression - #76205

aimane-chnaif · 2026-01-16T18:23:54Z

Please fix conflict

…chat-doesnt-have-open-report

bernhardoj · 2026-01-17T14:19:08Z

src/components/MoneyRequestConfirmationListFooter.tsx

    // When creating an expense in an individual report, the report field becomes read-only
    // since the destination is already determined and there's no need to show a selectable list.
-    const shouldReportBeEditable =
-        (isFromGlobalCreate && !isPerDiemRequest ? shouldReportBeEditableFromFAB : availableOutstandingReports.length > 1) && !isMoneyRequestReport(reportID, allReports);


Updated to handle #77963. It also fixes an issue where reports from all policy is shown in the edit report page.

aimane-chnaif · 2026-01-18T07:44:52Z

Please merge main to fix lint

aimane-chnaif · 2026-01-18T07:48:30Z

There's conflict with #79591. Update accordingly.

…chat-doesnt-have-open-report

bernhardoj · 2026-01-18T09:08:06Z

@aimane-chnaif done

aimane-chnaif · 2026-01-18T09:09:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

aimane-chnaif · 2026-01-18T10:18:46Z

Is this bug or expected? (happening on production)

Screen.Recording.2026-01-18.at.11.14.40.am.mov

Report is not selected as default when there is outstanding report in selected workspace

aimane-chnaif · 2026-01-18T10:14:14Z

src/pages/iou/request/step/IOURequestStepReport.tsx

                transactionIDs={transaction ? [transaction.transactionID] : []}
                selectedReportID={selectedReportID}
-                selectedPolicyID={!isEditing && !isFromGlobalCreate ? reportOrDraftReport?.policyID : undefined}
+                selectedPolicyID={(!isEditing && !isFromGlobalCreate) || isPerDiemTransaction ? reportOrDraftReport?.policyID : undefined}


I am not sure if we should fix the bug which is out of scope. (happening on production)
This still doesn't fix the issue when create per diem from FAB.
reportOrDraftReport is undefined. Should we use perDiemOriginalPolicy?.id instead?

reportOrDraftReport is undefined

I can see the report object available.

I am not sure if we should fix the bug which is out of scope

I'm up to you

I am still seeing other workspace. Let's use perDiemOriginalPolicy?.id if you agree

Screen.Recording.2026-01-18.at.11.50.46.am.mov

Oh, I forget to turn off the Submission frequency.

Let's use perDiemOriginalPolicy?.id

Hmm, it's undefined for non perdiem request. I think let's handle this on a separate issue so we can test this more and not increase the scope of this PR.

I meant to update like this:

isPerDiemTransaction ? perDiemOriginalPolicy.id : !isEditing && !isFromGlobalCreate ? reportOrDraftReport?.policyID : undefined

Either revert or update

Oh, make sense. That works. Updated!

bernhardoj · 2026-01-18T10:30:05Z

Report is not selected as default when there is outstanding report in selected workspace

I think it's expected if Submission frequency is turned off

aimane-chnaif · 2026-01-18T10:32:26Z

src/components/MoneyRequestConfirmationListFooter.tsx

-
-        return outstandingReports.filter((report) => {
-            const reportNameValuePair = reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID}`];
-            return !isArchivedReport(reportNameValuePair) && isReportOutstanding(report, report?.policyID, reportNameValuePairs, false);


Does new hook also count for archived report?

ok, isReportOutstanding has that check.

aimane-chnaif · 2026-01-18T10:33:06Z

src/components/MoneyRequestConfirmationListFooter.tsx


-    const shouldReportBeEditableFromFAB = isUnreported ? allOutstandingReports.length >= 1 : allOutstandingReports.length > 1;
-
+    const outstandingReports = useOutstandingReports(undefined, isFromGlobalCreate && !isPerDiemRequest ? undefined : policyID, ownerAccountID, false);


Is it correct that last param (isEditing) is always false?

Yes, this page is always for creating new one

aimane-chnaif · 2026-01-18T11:22:52Z

Report is not selected as default when there is outstanding report in selected workspace

I think it's expected if Submission frequency is turned off

This also happens when all (Submission frequency, Add approvals, and Make or track payments) are turned on.
Out of scope as this is not caused by our PR but note that the behavior is different after selecting report.

main: Report field is enabled

this branch: Report field is disabled

bernhardoj · 2026-01-18T13:03:39Z

note that the behavior is different after selecting report.

Do you have a repro steps?

aimane-chnaif · 2026-01-18T14:39:43Z

note that the behavior is different after selecting report.

Do you have a repro steps?

I am not able to reproduce anymore after relogin. Not blocker.

aimane-chnaif · 2026-01-18T14:40:02Z

Let's just address #79415 (comment)

…r diem

JmillsExpensify · 2026-01-20T08:58:21Z

Additional video:

others.mp4

Super helpful, thanks!

JmillsExpensify

Product changes look good. Approving!

grgia · 2026-01-22T14:40:36Z

@bernhardoj conflicts, otherwise LGTM

…chat-doesnt-have-open-report

bernhardoj · 2026-01-22T15:05:21Z

@grgia fixed

OSBotify · 2026-01-22T16:13:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-22T22:53:32Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.7-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-23T22:04:52Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

fix report field is enabled when there are no outstanding reports

f7dfd43

bernhardoj requested review from a team as code owners January 13, 2026 05:41

melvin-bot bot assigned bernhardoj Jan 13, 2026

melvin-bot bot requested review from JmillsExpensify and aimane-chnaif and removed request for a team January 13, 2026 05:42

melvin-bot bot removed the request for review from a team January 13, 2026 05:42

lint

119d3fb

bernhardoj added 2 commits January 17, 2026 21:06

Merge branch 'main' into fix/78788-report-field-is-clickable-when-ws-…

5ffd446

…chat-doesnt-have-open-report

don't allow moving expense to different workspace if it's per diem

daf44a1

bernhardoj commented Jan 17, 2026

View reviewed changes

bernhardoj added 2 commits January 18, 2026 16:51

Merge branch 'main' into fix/78788-report-field-is-clickable-when-ws-…

16eb7dc

…chat-doesnt-have-open-report

lint

2a6cd11

aimane-chnaif suggested changes Jan 18, 2026

View reviewed changes

aimane-chnaif reviewed Jan 18, 2026

View reviewed changes

fix report page shows outstanding report from other workspaces for pe…

351200c

…r diem

aimane-chnaif approved these changes Jan 19, 2026

View reviewed changes

melvin-bot bot requested a review from grgia January 19, 2026 02:41

JmillsExpensify previously approved these changes Jan 20, 2026

View reviewed changes

grgia previously approved these changes Jan 22, 2026

View reviewed changes

Merge branch 'main' into fix/78788-report-field-is-clickable-when-ws-…

7c58e13

…chat-doesnt-have-open-report

bernhardoj dismissed stale reviews from grgia and JmillsExpensify via 7c58e13 January 22, 2026 15:01

grgia approved these changes Jan 22, 2026

View reviewed changes

grgia merged commit cd868e4 into Expensify:main Jan 22, 2026
31 checks passed

OSBotify mentioned this pull request Jan 22, 2026

Deploy Checklist: New Expensify 2026-01-22 #80277

Closed

63 tasks

This was referenced Jan 22, 2026

Report - Empty report disappears after moving expense to a new report. #80289

Closed

Per diem - Report from other workspace is missing in report list when moving per diem expense #80309

Open

melvin-bot bot mentioned this pull request Jan 23, 2026

[Due for payment 2026-01-30] [$250] Expense - Report field opens not here page when auto-reporting is OFF & member has open report #78788

Open

7 tasks

nyomanjyotisa mentioned this pull request Jan 24, 2026

Fix: Error when creating per diem expense after selecting report from different workspace #79939

Merged

53 tasks


		const shouldReportBeEditableFromFAB = isUnreported ? allOutstandingReports.length >= 1 : allOutstandingReports.length > 1;

		const outstandingReports = useOutstandingReports(undefined, isFromGlobalCreate && !isPerDiemRequest ? undefined : policyID, ownerAccountID, false);

Fix report field is enabled when there are no outstanding reports #79415

Fix report field is enabled when there are no outstanding reports #79415

Conversation

bernhardoj commented Jan 13, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

bernhardoj commented Jan 13, 2026

Uh oh!

codecov bot commented Jan 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aimane-chnaif commented Jan 13, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 13, 2026

Uh oh!

bernhardoj commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Jan 16, 2026

Uh oh!

aimane-chnaif commented Jan 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Jan 18, 2026

Uh oh!

aimane-chnaif commented Jan 18, 2026

Uh oh!

bernhardoj commented Jan 18, 2026

Uh oh!

aimane-chnaif commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Jan 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jan 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Jan 18, 2026

Uh oh!

bernhardoj commented Jan 18, 2026

Uh oh!

aimane-chnaif commented Jan 18, 2026

Uh oh!

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

bernhardoj commented Jan 13, 2026 •

edited

Loading

aimane-chnaif commented Jan 18, 2026 •

edited

Loading

aimane-chnaif Jan 18, 2026 •

edited

Loading