Skip to content

Conversation

@dominictb
Copy link
Contributor

@dominictb dominictb commented Aug 12, 2025

Explanation of Change

Fixed Issues

$ #64849
PROPOSAL:

Tests

Precondtion:

  • manualDistance beta is enabled
  1. Press FAB > Create expense
  2. Verify Distance tab is not there
  3. Go to any group chat > + > Split expense
  4. Verify Distance tab is there

  1. Press FAB > Track distance
  2. Verify we have Map and Manual tabs
  3. Verify Map tab opens the first time using this feature
  4. Switch to Manual tab
  5. Close the RHP
  6. Press FAB > Track distance
  7. Verify Manual tab opens (last selected tab opens by default)

  1. Press FAB > Track distance > Map
  2. Proceed to create a map distance expense
  3. Verify everything works just like before

  1. Press FAB > Track distance > Manual
  2. Verify the distance unit matches workspace settings (km or mi, it's mi by default if workspace has not configured distance rates feature)
  3. Press Next
  4. Verify invalid distance error shows
  5. Input any distance amount > Next
  6. Verify the Amount is calculated properly based on Rate
  7. Verify receipt cell does not show
  8. Verify you can update the Rate and the Amount will be updated accordingly
  9. Press Create expense

  1. Go to self DM > + > Track distance > Manual
  2. Input any distance amount > Next
  3. Verify rate is $0.7 / mile by default and it's read only
  4. Verify the Amount is calculated properly based on Rate
  5. Verify receipt cell does not show
  6. Press Track expense

  1. Repeat steps 24 - 29 with any 1:1 DM

  1. Repeat steps 16 - 23 with any workspace chat
  2. It's expected that you cannot edit the Distance in either confirmation step or in expense report view for now. It would be implemented later
  • Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-08-15.at.02.42.54.mov
iOS: mWeb Safari
MacOS: Chrome / Safari

Track expense in self DM:

Screen.Recording.2025-08-15.at.00.22.49-compressed.mov

IOU:

Screen.Recording.2025-08-15.at.00.58.10.mov

Workspace expense:

Screen.Recording.2025-08-15.at.00.36.20-compressed.mov
MacOS: Desktop

@dominictb dominictb marked this pull request as ready for review August 14, 2025 18:22
@dominictb dominictb requested a review from a team as a code owner August 14, 2025 18:22
@melvin-bot melvin-bot bot requested review from allroundexperts and removed request for a team August 14, 2025 18:22
@melvin-bot
Copy link

melvin-bot bot commented Aug 14, 2025

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dominictb
Copy link
Contributor Author

dominictb commented Aug 14, 2025

@Expensify/design Can I get the Map icon SVG here? I couldn't find it in the current codebase. Figma link. The closest thing we've got is this one.

Screenshot 2025-08-15 at 01 27 47

@shawnborton
Copy link
Contributor

I can fire that up quickly, one sec

@melvin-bot melvin-bot bot requested a review from neil-marcellini August 22, 2025 21:49
@neil-marcellini neil-marcellini merged commit ea2177e into Expensify:main Aug 25, 2025
31 of 32 checks passed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.1.99-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@aldo-expensify
Copy link
Contributor

This is causing this deploy blocker: #69238

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 26, 2025

@dominictb How can we enable the manualDistance beta? We haven't it using Gmail and Expensifail accounts.

francoisl added a commit that referenced this pull request Aug 26, 2025
This reverts commit ea2177e, reversing
changes made to 744b401.
aldo-expensify added a commit that referenced this pull request Aug 26, 2025
Revert #68402 "[Manual distance] Create the distance creation tabs"
OSBotify pushed a commit that referenced this pull request Aug 26, 2025
Revert #68402 "[Manual distance] Create the distance creation tabs"

(cherry picked from commit d3d0087)

(cherry-picked to staging by francoisl)
Julesssss added a commit that referenced this pull request Aug 26, 2025
* main: (180 commits)
  Update Mobile-Expensify submodule version to 9.1.99-1
  Update version to 9.1.99-1
  Revert "Merge pull request #68402 from dominictb/feat/64849"
  Update Central-Billing.md
  Rename central-billing.md to Central-Billing.md
  Revert "fix: `ActionSheetAwareScrollView` not working with `maintainVisibleContentPosition`"
  fix: Unable to delete message in chat on Android
  renamed function
  Update Mobile-Expensify submodule version to 9.1.99-0
  Update version to 9.1.99-0
  fix: unknow user is displayed if selecting another report
  Update Mobile-Expensify submodule version to 9.1.98-12
  Update version to 9.1.98-12
  fix: hovering over the new user avatar does not display email
  Update src/components/Modal/ReanimatedModal/Container/index.tsx
  eslint-rule
  remove empty line
  add UTs
  Update central-billing.md
  Update Mobile-Expensify submodule version to 9.1.98-11
  ...
dominictb added a commit to dominictb/epsf-app that referenced this pull request Aug 27, 2025
@dominictb
Copy link
Contributor Author

@IuliiaHerets This PR was reverted. No need to QA now. Thank you.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2025

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.1-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@jponikarchuk
Copy link

@dominictb @shawnborton @allroundexperts Could you help please, how can we enable the manualDistance beta?

@dominictb
Copy link
Contributor Author

@neil-marcellini I think this should be Internal QA, right?

@shawnborton
Copy link
Contributor

cc @neil-marcellini to help for testing

@arosiclair
Copy link
Contributor

I'm checking this off since it's behind a beta and not ready for Applause QA. Please QA this on staging/prod when you get the chance @neil-marcellini

@OSBotify
Copy link
Contributor

OSBotify commented Sep 5, 2025

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.