-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Manual distance] Create the distance creation tabs #68402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Expensify/design Can I get the Map icon SVG here? I couldn't find it in the current codebase. Figma link. The closest thing we've got is this one.
|
|
I can fire that up quickly, one sec |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.1.99-0 🚀
|
|
This is causing this deploy blocker: #69238 |
|
@dominictb How can we enable the manualDistance beta? We haven't it using Gmail and Expensifail accounts. |
Revert #68402 "[Manual distance] Create the distance creation tabs"
* main: (180 commits) Update Mobile-Expensify submodule version to 9.1.99-1 Update version to 9.1.99-1 Revert "Merge pull request #68402 from dominictb/feat/64849" Update Central-Billing.md Rename central-billing.md to Central-Billing.md Revert "fix: `ActionSheetAwareScrollView` not working with `maintainVisibleContentPosition`" fix: Unable to delete message in chat on Android renamed function Update Mobile-Expensify submodule version to 9.1.99-0 Update version to 9.1.99-0 fix: unknow user is displayed if selecting another report Update Mobile-Expensify submodule version to 9.1.98-12 Update version to 9.1.98-12 fix: hovering over the new user avatar does not display email Update src/components/Modal/ReanimatedModal/Container/index.tsx eslint-rule remove empty line add UTs Update central-billing.md Update Mobile-Expensify submodule version to 9.1.98-11 ...
…t/64849"" This reverts commit 7d44700.
|
@IuliiaHerets This PR was reverted. No need to QA now. Thank you. |
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.1-0 🚀
|
|
@dominictb @shawnborton @allroundexperts Could you help please, how can we enable the manualDistance beta? |
|
@neil-marcellini I think this should be |
|
cc @neil-marcellini to help for testing |
|
I'm checking this off since it's behind a beta and not ready for Applause QA. Please QA this on staging/prod when you get the chance @neil-marcellini |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀
|

Explanation of Change
Fixed Issues
$ #64849
PROPOSAL:
Tests
Precondtion:
manualDistancebeta is enabledkmormi, it'smiby default if workspace has not configured distance rates feature)$0.7 / mileby default and it's read onlyOffline tests
NA
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-08-15.at.02.42.54.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Track expense in self DM:
Screen.Recording.2025-08-15.at.00.22.49-compressed.mov
IOU:
Screen.Recording.2025-08-15.at.00.58.10.mov
Workspace expense:
Screen.Recording.2025-08-15.at.00.36.20-compressed.mov
MacOS: Desktop