[Manual distance] Create the distance creation tabs v2 #69372

dominictb · 2025-08-27T16:52:07Z

Explanation of Change

Fixed Issues

$ #64849
PROPOSAL:

Tests

Precondtion:

manualDistance beta is enabled

Press FAB > Create expense
Verify Distance tab is not there
Go to any group chat > + > Split expense
Verify Distance tab is there

Press FAB > Track distance
Verify we have Map and Manual tabs
Verify Map tab opens the first time using this feature
Switch to Manual tab
Close the RHP
Press FAB > Track distance
Verify Manual tab opens (last selected tab opens by default)

Press FAB > Track distance > Map
Proceed to create a map distance expense
Verify everything works just like before

Press FAB > Track distance > Manual
Verify the distance unit matches workspace settings (km or mi, it's mi by default if workspace has not configured distance rates feature)
Press Next
Verify invalid distance error shows
Input any distance amount > Next
Verify the Amount is calculated properly based on Rate
Verify receipt cell does not show
Verify you can update the Rate and the Amount will be updated accordingly
Press Create expense

Go to self DM > + > Track distance > Manual
Input any distance amount > Next
Verify rate is $0.7 / mile by default and it's read only
Verify the Amount is calculated properly based on Rate
Verify receipt cell does not show
Press Track expense

Repeat steps 24 - 29 with any 1:1 DM

Repeat steps 16 - 23 with any workspace chat
It's expected that you cannot edit the Distance in either confirmation step or in expense report view for now. It would be implemented later

Precondition:

Account has self DM.
manualDistance beta is NOT enabled

Go to self DM.
Click + > Create expense > Distance.
Enter waypoints > Next.
Remember the amount and distance on the confirm page.
Click Create expense.
Open the transaction thread.
Verify the amount is correct (equals distance multiplied by millage rate, matches the amount in step 4)

Precondition:

Account has self DM.
manualDistance beta is enabled

Go to self DM.
Click + > Track distance > Manual.
Enter distance > Next.
Remember the amount and distance on the confirm page.
Click Create expense.
Open the transaction thread.
Verify the amount is correct (equals distance multiplied by millage rate, matches the amount in step 4)

Go to workspace chat.
Create a manual expense without receipt.
Open the transaction thread.
Click on the receipt.
Verify app opens receipt upload/scan page

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-08-15.at.02.42.54.mov

Normal distance expense:

Screen.Recording.2025-08-28.at.00.32.55-compressed.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Receipt is editable for manual distance and manual amount expenses:

Normal distance requests:

Screen.Recording.2025-08-28.at.00.08.21-compressed.mov

Split normal distance requests:

Screen.Recording.2025-08-28.at.00.10.57-compressed.mov

Map & Manual distance expense in self DM:

Screen.Recording.2025-08-28.at.00.04.46-compressed.mov

Map & Manual distance expense in IOU:

Screen.Recording.2025-08-28.at.00.15.33-compressed.mov

Screen.Recording.2025-08-28.at.00.16.34-compressed.mov

Workspace:

Screen.Recording.2025-08-28.at.00.27.06-compressed.mov

Screen.Recording.2025-08-28.at.00.31.12-compressed.mov

Move track expenses to workspace:

Screen.Recording.2025-08-28.at.00.18.15-compressed.mov

Categorize, Submit to someone, Share with accountant track expense:

Screen.Recording.2025-08-28.at.00.20.02-compressed.mov

MacOS: Desktop

…t/64849"" This reverts commit 7d44700.

melvin-bot · 2025-08-27T19:16:25Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…eat/64849-2

dominictb · 2025-08-27T20:37:19Z

Note that the auto focus issue in distance amount step is a known issue that has happened a lot recently. Like #69356, #69296 or #69242. It's being worked on.

dominictb · 2025-08-27T20:37:49Z

And the crash issue that happened previously #69278 is not related to this PR

allroundexperts · 2025-08-27T22:47:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-08-28.at.5.32.59.AM.mov

iOS: HybridApp

Screen.Recording.2025-08-28.at.5.21.30.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-08-28.at.5.16.27.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-28.at.4.22.56.AM.mov

Screen.Recording.2025-08-28.at.4.24.29.AM.mov

Screen.Recording.2025-08-28.at.4.25.32.AM.mov

Screen.Recording.2025-08-28.at.4.26.15.AM.mov

Screen.Recording.2025-08-28.at.4.30.23.AM.mov

MacOS: Desktop

Screen.Recording.2025-08-28.at.4.56.07.AM.mov

Screen.Recording.2025-08-28.at.4.57.01.AM.mov

dominictb · 2025-08-27T23:38:28Z

This bug #69372 (comment) is expected for now because the edit distance page will be implemented later in #64368

dominictb · 2025-08-27T23:39:17Z

This bug #69372 (comment) is expected as per design doc but we can disable it temporarily until #64369 gets done. Wdyt?

allroundexperts · 2025-08-27T23:41:05Z

This bug #69372 (comment) is expected as per design doc but we can disable it temporarily until #64369 gets done. Wdyt?

Let's leave it as it is and address it in #64369

allroundexperts

I tested this for #69256 & #69238 apart from the test steps in the OP and can verify that those work fine.

neil-marcellini

Looks great and very thoroughly tested. Thanks!

OSBotify · 2025-08-29T02:18:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-02T22:48:04Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.1-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2025-09-04T09:29:57Z

Hello @neil-marcellini This PR should be internal QA, as this #68402 (comment)? Thank you

arosiclair · 2025-09-04T22:11:03Z

Same thing here. Please QA this when you get the chance @neil-marcellini

OSBotify · 2025-09-05T19:35:03Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

linhvovan29546 · 2025-12-09T02:50:02Z

src/pages/iou/request/step/IOURequestStepDistanceManual.tsx

+    const isCreatingNewRequest = !(backTo || isEditing);
+
+    const customUnitRateID = getRateID(transaction);
+    const unit = DistanceRequestUtils.getRate({transaction, policy}).unit;


We missed an edge case for the default workspace. When starting Track Distance manual from the global button, we need to display the default workspace’s unit. Without that, the bug in #75154 occurs, we applied the fix here #76147.

dominictb added 3 commits August 27, 2025 23:44

Revert "Revert "Merge pull request Expensify#68402 from dominictb/fea…

f6e4d35

…t/64849"" This reverts commit 7d44700.

fix: receipt in manual expense is not editable

6ca0e2d

fix: distance param is included in normal distance request

860f3fa

melvin-bot bot assigned dominictb Aug 27, 2025

dominictb mentioned this pull request Aug 27, 2025

[Due for payment 2025-09-26] Allow editing manual distance #64368

Closed

dominictb added 4 commits August 28, 2025 01:39

fix: default distance category is not set

3ad340f

fix: default distance category is not set

898f867

add beta guards to getRequestType

8f46cb0

fix: confirmation step navigates back to normal iou start page

668cd74

dominictb marked this pull request as ready for review August 27, 2025 19:16

dominictb requested review from a team as code owners August 27, 2025 19:16

melvin-bot bot requested review from allroundexperts and removed request for a team August 27, 2025 19:16

dominictb added 2 commits August 28, 2025 02:27

fix: hover to view receipt triggers on manual distance request

59c1e9e

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

30a4647

…eat/64849-2

dominictb mentioned this pull request Aug 27, 2025

[$500] [Due for payment 2025-09-12] Create the distance creation tabs #64849

Closed

fix: lastDistanceExpenseType logic does not work

284fb85

This comment was marked as outdated.

Sign in to view

allroundexperts approved these changes Aug 28, 2025

View reviewed changes

melvin-bot bot requested a review from neil-marcellini August 28, 2025 00:48

neil-marcellini approved these changes Aug 29, 2025

View reviewed changes

neil-marcellini merged commit 7877ec4 into Expensify:main Aug 29, 2025
21 checks passed

OSBotify mentioned this pull request Sep 2, 2025

Deploy Checklist: New Expensify 2025-09-02 #69693

Closed

vincdargento mentioned this pull request Sep 25, 2025

Track distance - Rate field always opens upgrade page when recipient is user #71331

Closed

8 tasks

linhvovan29546 reviewed Dec 9, 2025

View reviewed changes

[Manual distance] Create the distance creation tabs v2 #69372

[Manual distance] Create the distance creation tabs v2 #69372

Uh oh!

Conversation

dominictb commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 27, 2025

Uh oh!

dominictb commented Aug 27, 2025

Uh oh!

dominictb commented Aug 27, 2025

Uh oh!

allroundexperts commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

dominictb commented Aug 27, 2025

Uh oh!

dominictb commented Aug 27, 2025

Uh oh!

allroundexperts commented Aug 27, 2025

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 29, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

izarutskaya commented Sep 4, 2025

Uh oh!

arosiclair commented Sep 4, 2025

Uh oh!

OSBotify commented Sep 5, 2025

Uh oh!

linhvovan29546 Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dominictb commented Aug 27, 2025 •

edited

Loading

allroundexperts commented Aug 27, 2025 •

edited

Loading