[63253] (2/2) Render optimistic transaction thread by pac-guerreiro · Pull Request #69073 · Expensify/App

pac-guerreiro · 2025-08-22T20:28:44Z

Explanation of Change

This is part of the initial PR → #66165 (comment)
And related ticket → #63253

We need to split the changes from the original PR into smaller, more manageable PRs.

In this one, we aim to ensure that when opening the transaction thread, we render the transaction details optimistically

Fixed Issues

$#63253
PROPOSAL:

Tests

Open Reports > Expense Reports
Open an expense report with multiple transactions on it
Open one transaction thread
Ensure the transaction details are loaded immediately (since all the transaction data should be available)
Use the arrows in the header to cycle through the expense views
The transaction details should be visible immediately even if the report actions are loading

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android_Native.mp4

Android: mWeb Chrome

Android_Chrome.mp4

iOS: Native

iOS_Native.mp4

iOS: mWeb Safari

iOS_Safari.mp4

MacOS: Chrome / Safari

MacOS_Chrome.mp4

MacOS: Desktop

MacOS_Desktop.mp4

…transaction-thread

melvin-bot · 2025-08-26T11:32:11Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…transaction-thread

c3024 · 2025-08-29T04:03:45Z

The app crashes.

It looks like there was an issue with merging. There is a removed variable that is exported.

src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx

…transaction-thread

trjExpensify

Agree with the aim of this PR: "we aim to ensure that when opening the transaction thread, we render the transaction details optimistically" 👍

c3024

Tiny suggestion. Apart from this everything looks good. I am testing and will soon complete the checklist.

src/pages/home/report/ReportActionsView.tsx

c3024 · 2025-09-01T10:11:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

arrowAndroid.mov

Android: mWeb Chrome

arrowAndroidmWeb.mov

iOS: HybridApp

arrowiOS.mov

iOS: mWeb Safari

arrowiOSmWeb.mov

MacOS: Chrome / Safari

arrowChrome.mov

MacOS: Desktop

arrowDesktop.mov

c3024

Apart from this suggestion, everything LGTM!

…transaction-thread

pac-guerreiro · 2025-09-01T22:23:30Z

@c3024 thanks for the suggestion, I just applied it 😄

mountiny · 2025-09-01T22:28:12Z

Thanks! waiting on this one for next deploy as we already got bunch of larger changes merged in the upcoming release

mountiny · 2025-09-22T11:00:31Z

Great @OlimpiaZurek @pac-guerreiro thank you! creating a new build to test this more

github-actions · 2025-09-22T11:00:57Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-09-22T11:25:01Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69073.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69073/NewExpensify.dmg	https://69073.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

VickyStash · 2025-09-22T14:24:15Z

Hey @mountiny, it looks like android/ios builds has failed, should I merge main and we give a try one more time?

mountiny · 2025-09-23T23:22:03Z

@VickyStash yes please

…transaction-thread

VickyStash · 2025-09-24T07:46:41Z

Hey @mountiny, I've merged the latest main.

After some testing I've noticed a couple of things I want to confirm:

web1+questions.mp4

When I switch/open held expense, the Remove hold button appears after the expense is loaded. If I'm offline, it doesn't appear until the connection is on. The same with comments, the number of comments is shown, but they are not displayed till the data is loaded (user online).

ios+questions.mp4

On mobile I've noticed the content jump when all of the comments are loaded, though I guess it won't be so noticeable when we will open all treans at top position.

mountiny · 2025-09-24T09:14:44Z

I think that is okay. We just do not have the information available locally, do we? So when you reopen the transaction again, the Hold button is already showing correctly, right?
Yeah, I think that makes sense and this won't look bad when the transaction opens at the top (which is why I think that Pr has to come first)

…transaction-thread

codecov · 2025-10-03T14:11:43Z

Codecov Report

❌ Patch coverage is 24.39024% with 31 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...tView/MoneyRequestReportTransactionsNavigation.tsx	5.88%	16 Missing ⚠️
...stReportView/MoneyRequestReportTransactionList.tsx	0.00%	6 Missing ⚠️
src/libs/actions/Report.ts	0.00%	4 Missing ⚠️
src/components/MoneyRequestHeader.tsx	25.00%	3 Missing ⚠️
src/pages/home/report/ReportActionsView.tsx	80.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

VickyStash · 2025-10-06T06:37:14Z

UPD:

the HOLDing PR was merged, @mountiny can you please remove hold label from this PR title
I'm starting the PR re-testing/checking

…transaction-thread

trjExpensify · 2025-10-06T15:51:34Z

I've removed the hold in the title for you, @VickyStash.

VickyStash · 2025-10-06T15:53:46Z

Cross-posting updates, for visibility. I've found several issues that I'm working on:

With the updated logic to open transaction thread on top, there is a jump when optimistic CONST.REPORT.ACTIONS.TYPE.CREATED report action is updated with the real one, I have found the fix, but I want to check a couple of other ideas to make it smooth on native platforms.
There is a header blinking when the screen re-renders with the real thread data on android
One transaction thread shows loading, not the optimistic data
I haven't checked mWeb platfroms, there can be something as well

roryabraham · 2025-10-06T22:57:56Z

@VickyStash I'm going to convert this to draft while you're working through the kinks, hope that's ok. Of course, feel free to submit for review again once it's ready

…transaction-thread # Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx # src/pages/home/ReportScreen.tsx

mountiny · 2025-10-07T10:10:03Z

@VickyStash What is the latest on this one? Anything you would need help with from someone else or some product question we can help with?

VickyStash · 2025-10-07T10:25:31Z

@VickyStash What is the latest on this one? Anything you would need help with from someone else or some product question we can help with?

Hey @mountiny, you can find the latest update here. Right now, I'm actively working on fixing the issues and checking over updates that were lately merged.
I had just one question, if we want to keep this PR or should I open a new one, as I'm not the author of this one and can't update title/checklist/mark comments as resolved.

mountiny · 2025-10-07T13:07:04Z

closing in favour of #72001 so @VickyStash can edit the PR description just fine

feat(63253): render optimistic transaction thread

ff56768

melvin-bot bot assigned pac-guerreiro Aug 22, 2025

pac-guerreiro added 2 commits August 25, 2025 13:35

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

d439b2d

…transaction-thread

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

1dcd544

…transaction-thread

pac-guerreiro marked this pull request as ready for review August 26, 2025 11:32

pac-guerreiro requested a review from a team as a code owner August 26, 2025 11:32

melvin-bot bot requested a review from allgandalf August 26, 2025 11:32

melvin-bot bot removed the request for review from a team August 26, 2025 11:32

allgandalf removed their request for review August 26, 2025 11:57

pac-guerreiro added 3 commits August 27, 2025 15:34

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

9925681

…transaction-thread

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

85947db

…transaction-thread

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

57684cd

…transaction-thread

mountiny requested review from c3024 and mountiny August 28, 2025 15:14

c3024 suggested changes Aug 29, 2025

View reviewed changes

src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

681b03d

…transaction-thread

pac-guerreiro requested a review from a team as a code owner August 29, 2025 12:50

fix(63253): potential undefined iouAction

52f69a6

trjExpensify previously approved these changes Aug 30, 2025

View reviewed changes

c3024 suggested changes Sep 1, 2025

View reviewed changes

src/pages/home/report/ReportActionsView.tsx Outdated Show resolved Hide resolved

c3024 approved these changes Sep 1, 2025

View reviewed changes

pac-guerreiro added 2 commits September 1, 2025 23:08

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

c781441

…transaction-thread

refactor(63253): apply suggestion

05b13a9

pac-guerreiro dismissed trjExpensify’s stale review via 05b13a9 September 1, 2025 22:23

pac-guerreiro mentioned this pull request Sep 3, 2025

[HOLD on PR 69073] Expense - Comment section shows up at the top while the report is loading #69732

Closed

8 tasks

OlimpiaZurek added 2 commits September 19, 2025 16:07

fix optimistic create report transaction

e84c0ad

fix prettier

653475e

VickyStash mentioned this pull request Sep 23, 2025

Update the transaction thread report loading to show skeleton for report actions only if transaction data available #63253

Closed

16 tasks

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

468efb9

…transaction-thread

mountiny changed the title ~~[63253] (2/2) Render optimistic transaction thread~~ [HOLD opening transaction thread on top] [63253] (2/2) Render optimistic transaction thread Sep 24, 2025

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

94b7d5e

…transaction-thread

VickyStash added 2 commits October 6, 2025 09:24

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

e99cc4d

…transaction-thread

Simplify reportActionsToDisplay logic

09edd89

trjExpensify changed the title ~~[HOLD opening transaction thread on top] [63253] (2/2) Render optimistic transaction thread~~ [63253] (2/2) Render optimistic transaction thread Oct 6, 2025

roryabraham marked this pull request as draft October 6, 2025 22:57

VickyStash added 3 commits October 7, 2025 09:44

Merge branch 'main' into pac-guerreiro/fix/63253-2-render-optimistic-…

0d4cc55

…transaction-thread # Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx # src/pages/home/ReportScreen.tsx

Improve the logic

116581d

Fix prettier errors

62d93c8

VickyStash mentioned this pull request Oct 7, 2025

Render optimistic transaction thread #72001

Merged

54 tasks

mountiny closed this Oct 7, 2025

Conversation

pac-guerreiro commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 26, 2025

Uh oh!

c3024 commented Aug 29, 2025

Uh oh!

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

c3024 commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

pac-guerreiro commented Sep 1, 2025

Uh oh!

mountiny commented Sep 1, 2025

Uh oh!

mountiny commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

VickyStash commented Sep 22, 2025

Uh oh!

mountiny commented Sep 23, 2025

Uh oh!

VickyStash commented Sep 24, 2025

Uh oh!

mountiny commented Sep 24, 2025

Uh oh!

codecov bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

VickyStash commented Oct 6, 2025

Uh oh!

trjExpensify commented Oct 6, 2025

Uh oh!

VickyStash commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roryabraham commented Oct 6, 2025

Uh oh!

mountiny commented Oct 7, 2025

Uh oh!

VickyStash commented Oct 7, 2025

Uh oh!

mountiny commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pac-guerreiro commented Aug 22, 2025 •

edited

Loading

c3024 commented Sep 1, 2025 •

edited

Loading

codecov bot commented Oct 3, 2025 •

edited

Loading

VickyStash commented Oct 6, 2025 •

edited

Loading