fix: submit button is present after creating a scan expense with missing amount and missing merchant by mkzie2 · Pull Request #69218 · Expensify/App

mkzie2 · 2025-08-26T08:47:28Z

Explanation of Change

fix: approve button is present after submitting a scan expense with missing amount

Fixed Issues

$ #67173
PROPOSAL: #67173 (comment)

Tests

Precondition: The workspace enables the workflow and setting the default approver

Create an empty expense report
Submit an invalid scan receipt
Verify the SmartScan fails
Verify the submit button doesn't appear
Enter the merchant
Submit the expense
Verify that the approve button appears for the approver.
Approve the report
Verify the report is approved.

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Precondition: The workspace enables the workflow and setting the default approver

Create an empty expense report
Submit an invalid scan receipt
Verify the SmartScan fails
Verify the submit button doesn't appear
Enter the merchant
Submit the expense
Verify that the approve button appears for the approver.
Approve the report
Verify the report is approved.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-08-05.at.23.11.36.mov

Android: mWeb Chrome

Screen.Recording.2025-08-05.at.23.13.22.mov

iOS: Native

Screen.Recording.2025-08-05.at.23.12.09.mov

iOS: mWeb Safari

Screen.Recording.2025-08-05.at.23.12.34.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-05.at.23.09.45.mov

MacOS: Desktop

Screen.Recording.2025-08-05.at.23.13.53.mov

…mitting a scan expense with missing amount""

melvin-bot · 2025-08-26T09:24:33Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-08-29T10:56:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

2025-08-29.13.33.20.mov

MacOS: Desktop

2025-08-29.13.33.20.mov

ZhenjaHorbach · 2025-08-29T11:37:10Z

LGTM !

trjExpensify

I think we should be handling this better to not show a submit button in the first place if all the expenses on the report are partial.

It results in this pretty janky error message in-line:

2025-09-03_12-59-35.mp4

CC: @JmillsExpensify

mkzie2 · 2025-09-07T14:27:01Z

@trjExpensify In this PR, we also hide the submit button when the transaction's amount and transaction's merchant.

trjExpensify · 2025-09-08T15:21:28Z

@trjExpensify In this PR, we also hide the submit button when the transaction's amount and transaction's merchant.

Can you rephrase that comment? I'm not following you. Thanks!

mkzie2 · 2025-09-11T16:02:24Z

@trjExpensify In this PR, we also hide the submit button when the transaction's amount and transaction's merchant are missed.

trjExpensify · 2025-09-11T18:04:14Z

Why does this video have a submit button?

mkzie2 · 2025-09-11T18:14:59Z

@trjExpensify The video is on staging.

trjExpensify · 2025-09-11T18:22:43Z

Interesting, and why don't the tests cover the Submit case if this PR introduces that fix?

mkzie2 · 2025-09-12T02:55:31Z

Updated the test step.

ZhenjaHorbach · 2025-09-15T09:20:39Z

@mkzie2
Could you update the branch to the latest version of main to fix pipeline?

github-actions · 2026-02-11T22:09:30Z

🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-11T22:10:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #69218.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

trjExpensify · 2026-02-11T22:11:11Z

Build keeps failing when I try to do web-only for speed.

github-actions · 2026-02-11T22:14:19Z

🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-11T22:14:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #69218.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

trjExpensify · 2026-02-11T22:25:32Z

Now trying for all.

github-actions · 2026-02-11T22:26:00Z

🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-11T22:28:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #69218.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

trjExpensify · 2026-02-11T22:34:02Z

I give up for now, can't test. I'd like to see an end-to-end video of these steps:

Create an empty expense report
Add a receipt that will fail scanning.
Verify the SmartScan fails
Verify the submit button doesn't appear
Enter the merchant
Verify the Submit button appears
Submit the report
Verify the expense report submits fine
Verify that the approve button appears for the approver.
Approve the report
Verify the report is approved.

ZhenjaHorbach · 2026-02-12T12:35:34Z

@mkzie2
Could you try to update the branch to the latest version of main?

jasperhuangg · 2026-02-12T17:54:24Z

just kicked off another build, we'll see if it works

github-actions · 2026-02-12T17:54:39Z

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-12T17:54:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #69218.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

ZhenjaHorbach · 2026-02-13T07:39:14Z

@trjExpensify
Let's try to run adhoc builds again!

jasperhuangg · 2026-02-13T22:35:07Z

it's running

github-actions · 2026-02-13T22:35:55Z

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-13T23:02:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #69218.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-74e9112e55d422f591d198c0c64b6260e5c0cac1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fb9f60dfa87c93a03ef6407e8c42088936a71e79/index.html

Web 🕸️
https://69218.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

jasperhuangg · 2026-02-18T20:36:03Z

@trjExpensify the QR codes for the AdHoc build are ready to go!

trjExpensify

Create an empty expense report

Add a receipt that will fail scanning

Verify the SmartScan fails

Verify the submit button doesn't appear

Enter the merchant

Verify the Submit button appears

Submit the report

Verify the expense report submits fine

Verify that the approve button appears for the approver.

Approve the report

Verify the report is approved

^^ executed those and it worked! 👍

2026-02-24_22-48-00.mp4

github-actions · 2026-02-25T00:37:23Z

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-25T00:42:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #69218.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9b9a94f-b795e6a-23ce88aa5d3c1eb2371b07601eb28882ab1299e8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9b9a94f-b795e6a-3e1e716630f9065ba4def6447744eebff9e8d8ba/index.html

Web 🕸️
https://69218.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-25T00:45:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-25T18:22:39Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T14:54:12Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "[CP Staging] Revert "fix: approve button is present after sub…

f16f7de

…mitting a scan expense with missing amount""

melvin-bot bot assigned mkzie2 Aug 26, 2025

fix missing merchant case

b344d45

mkzie2 changed the title ~~Revert "[CP Staging] Revert "fix: approve button is present after submitting a scan expense with missing amount""~~ fix: approve button is present after submitting a scan expense with missing amount Aug 26, 2025

mkzie2 added 2 commits August 26, 2025 16:15

fix test

00afc44

run prettier

93c84fc

mkzie2 marked this pull request as ready for review August 26, 2025 09:24

mkzie2 requested a review from a team as a code owner August 26, 2025 09:24

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team August 26, 2025 09:24

mkzie2 mentioned this pull request Aug 26, 2025

[Due for Payment 2026-03-17][$250] Web - Expense - Approve button is present after submitting a scan expense with missing amount #67173

Closed

8 tasks

ZhenjaHorbach approved these changes Aug 29, 2025

View reviewed changes

melvin-bot bot requested a review from jasperhuangg August 29, 2025 11:37

jasperhuangg requested a review from a team September 2, 2025 17:43

trjExpensify requested changes Sep 3, 2025

View reviewed changes

Merge branch 'main' into revert-69169-revert-67941-mkzie2-issue/67173

599dfbf

merge main

68987be

mkzie2 added 2 commits September 15, 2025 16:25

Merge branch 'main' into revert-69169-revert-67941-mkzie2-issue/67173

a1ff5c6

Merge branch 'main' into revert-69169-revert-67941-mkzie2-issue/67173

33380ee

jasperhuangg added the Ready To Build label Feb 12, 2026

Merge branch 'main' into revert-69169-revert-67941-mkzie2-issue/67173

4ed5acc

trjExpensify approved these changes Feb 24, 2026

View reviewed changes

jasperhuangg merged commit 9b9a94f into Expensify:main Feb 25, 2026
29 checks passed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

jponikarchuk mentioned this pull request Feb 26, 2026

[$250] Expense - Submit button appears briefly after the SmartScan fails #83573

Closed

7 tasks

ijmalik mentioned this pull request Mar 26, 2026

[$250] Report - "Waiting for you to fix the issue" displays on admin side #86252

Open

7 tasks

Conversation

mkzie2 commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 26, 2025

Uh oh!

ZhenjaHorbach commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Aug 29, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mkzie2 commented Sep 7, 2025

Uh oh!

trjExpensify commented Sep 8, 2025

Uh oh!

mkzie2 commented Sep 11, 2025

Uh oh!

trjExpensify commented Sep 11, 2025

Uh oh!

mkzie2 commented Sep 11, 2025

Uh oh!

trjExpensify commented Sep 11, 2025

Uh oh!

mkzie2 commented Sep 12, 2025

Uh oh!

ZhenjaHorbach commented Sep 15, 2025

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

trjExpensify commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

trjExpensify commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

trjExpensify commented Feb 11, 2026

Uh oh!

ZhenjaHorbach commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasperhuangg commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

ZhenjaHorbach commented Feb 13, 2026

Uh oh!

jasperhuangg commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

jasperhuangg commented Feb 18, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mkzie2 commented Aug 26, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 29, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 12, 2026 •

edited

Loading