-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[NO QA] Remove stray </div> tag from travel analytics documentation #69308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@madmax330 @brianlee-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
* main: Update Travel-Event-Management.md Update Booking-Event-Travel.md remove duplicate page fix remaining route issue Create Booking-Event-Travel.md Create Booking-Travel-for-Event-Attendees.md Create View-Event-As-Employee-or-Guest.md Create Booking-Travel-for-Event-Attendees.md move page to correct dir remove redirect create subcategory Rename Event-Management to Event-Management.md Rename docs/articles/travel/Event-Management to docs/articles/travel/hubs/Event-Management Update redirects.csv Create Event-Management
|
A preview of your ExpensifyHelp changes have been deployed to https://bbf1c388.helpdot.pages.dev ⚡️ |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
Explanation of Change
Removed a stray HTML
</div>closing tag that was incorrectly placed at the end of the travel analytics overview documentation. The tag was not properly paired with an opening tag and shouldn't exist in a Markdown file.Also removed some trailing spaces noticed here.
Fixed Issues
N/A
Tests
Offline tests
N/A - documentation change only
QA Steps
N/A - no code change
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - documentation change only
Android: mWeb Chrome
N/A - documentation change only
iOS: Native
N/A - documentation change only
iOS: mWeb Safari
N/A - documentation change only
MacOS: Chrome / Safari
N/A - documentation change only
MacOS: Desktop
N/A - documentation change only