Create Event-Management #69120

Christinadobrzyn · 2025-08-24T17:23:47Z

Fixes https://github.com/Expensify/Expensify/issues/533839

Explanation of Change

Tracking GH - https://github.com/Expensify/Expensify/issues/533839#issuecomment-3215945805
Travel event management articles
I'm also trying to create a new category, I hope I did that right

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Tracking GH - Expensify/Expensify#533839 (comment)

melvin-bot · 2025-08-24T17:24:23Z

melvin-bot · 2025-08-24T17:24:25Z

@Julesssss @VictoriaExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Christinadobrzyn · 2025-08-24T17:25:49Z

@strepanier03 I followed Step 2B in our SO but I'm not sure if I created the new subcategory correctly under travel.

I think we need to publish this before I can publish the other articles as they are also going to live under this category. Is that right? It's been a long time since I've created a new category in our help articles.

Trying to create a new subcategory under Travel. I think I need to make a new path to the folder?

Christinadobrzyn · 2025-08-24T17:37:17Z

I don't think I'm doing this right, I'm trying to create a new subcategory of "Event Management" under Travel. I followed this SO to create the path but that article is specific for changing a name, so I'm not sure if that is right for creating a new subcategory...

…hubs/Event-Management Trying to create a new subcategory named "Event Management" under https://help.expensify.com/travel/hubs/ I didn't add the "hubs" part in the original path so updating here.

updating the article name to fix an issue

* main: (119 commits) Update Mobile-Expensify submodule version to 9.1.98-7 Update version to 9.1.98-7 Update Mobile-Expensify submodule version to 9.1.98-6 Update version to 9.1.98-6 Revert "fix: approve button is present after submitting a scan expense with missing amount" replace unsupported .toSorted syntax with regular .sort revert PR Do not hide empty trip rooms in most recent mode fix: test Remove resolved and integrity bump react-fast-pdf fix: remove call to getReportNameValuePairs in method getAllReportActionsErrorsAndReportActionThatRequiresAttention package-lock.json file update after merging main Update Mobile-Expensify submodule version to 9.1.98-5 Update version to 9.1.98-5 Update Mobile-Expensify submodule version to 9.1.98-4 Update version to 9.1.98-4 Update Mobile-Expensify submodule version to 9.1.98-3 Update version to 9.1.98-3 fix: sharing image with new users show header err ...

OSBotify · 2025-08-25T17:48:57Z

A preview of your ExpensifyHelp changes have been deployed to https://ff96652b.helpdot.pages.dev ⚡️

Julesssss · 2025-08-25T17:56:16Z

I don't think I'm doing this right, I'm trying to create a new subcategory of "Event Management" under Travel.

Number of hubs in _routes.yml does not match number of hubs in docs/travel/articles. Please update _routes.yml with hub info.

Hey @Christinadobrzyn. I checked the 'failed to build' action and it hinted at the problem. I believe we needed to edit the routes file to add a subcategory with this change. Please could you check to see if I understood correctly, thanks

Julesssss · 2025-08-25T18:28:06Z

Hmm I'm a bit confused of the desired structure reading through the linked issue. I fixed the original issue but the new section and page just links to another help page? Please let me know what we expect to see here:

Christinadobrzyn · 2025-08-25T19:13:35Z

Thank you so much for all the help @Julesssss! I really appreciate the help with creating that new section.

Re your question here - I created a redirect because I wasn't sure how to create a new path. We don't need to keep the subcategory "Event Management," just the main section that you've made. I will be PRing new subcategories but they aren't going to be named "Event Management".

Julesssss · 2025-08-25T21:10:41Z

No worries 🙂

So I don't think we can make 'Event Management' a page currently (without the >). I think because it's at the same 'level' as the other sub categories we are stuck.

So I think we need to live with the single page under the Event Management, or perhaps wait until the subcategory pages are ready. Let me know which you think would be a better solution.

Christinadobrzyn · 2025-08-25T21:19:47Z

Ah ok. I have the subcategory pages ready to add to a PR. I just don't have the "Travel Management" section active yet to create the PR for the other pages.

Maybe if I combine the PRs into this one, that will help?

Julesssss · 2025-08-25T21:43:58Z

Maybe if I combine the PRs into this one, that will help?

Yeah that sounds good to me, I'm happy to help combine them if that makes things easier. Feel free to share any docs you have ready.

• Tracking - Expensify/Expensify#533839 • Creating a new help article to book travel for even attendees

• Tracking Expensify/Expensify#533839 • Creating new article about how to view an event as an attendee or guest

Christinadobrzyn · 2025-08-25T23:09:49Z

Ok, I added all the files here, I'm so sorry that is a huge review Sheena.

Julesssss · 2025-08-25T23:33:12Z

I think this is working as expected now after fixing a small issue. Let me know if we need any changes once the test site is ready for testing.

Christinadobrzyn · 2025-08-25T23:46:10Z

Oh awesome! I think that looks right based on the other Travel folders!

Christinadobrzyn · 2025-08-26T00:06:45Z

There are some links in the articles that will need to be updated once all of these articles are live, as they are dependent on each other. I will do that once they are live.

Julesssss · 2025-08-26T16:18:25Z

Sounds good, happy to help review

Christinadobrzyn · 2025-08-26T17:09:48Z

@Julesssss is it possible to remove the "Event Management" subfolder or to replace it with the "Travel Event Management" subfolder?

Julesssss · 2025-08-26T17:22:58Z

is it possible to remove the "Event Management" subfolder or to replace it with the "Travel Event Management" subfolder?

Sure, so remove one of the children of Expensify Travel > Event Management? I see that under that navigation we have both Event Management and Travel Event Management so I removed Event Management as the name is the same as the parent category. But let me know if I misunderstood

Here's how it looks for me now:

updated the access instructions

small tweak

strepanier03 · 2025-08-26T18:54:26Z

Made some changes, waiting on a fresh build and then I'll give it another review.

strepanier03 · 2025-08-26T19:01:29Z

Hmm, I'm not sure how to fix the build error.

@Julesssss - Aside from the build error, I think we should push these articles out as is. I only made a few tiny tweaks and reviewed teh build before I did, so I know what changes I made.

I think it's more important to have these live than have these perfect. We can make additional improvements after they are live.

Can you help resolve the build error and merge these?

strepanier03

I reviewed the last build and then made a few tweaks.

I think these should be merged and put live and then we can improve them if needed afterward.

* main: (180 commits) Update Mobile-Expensify submodule version to 9.1.99-1 Update version to 9.1.99-1 Revert "Merge pull request #68402 from dominictb/feat/64849" Update Central-Billing.md Rename central-billing.md to Central-Billing.md Revert "fix: `ActionSheetAwareScrollView` not working with `maintainVisibleContentPosition`" fix: Unable to delete message in chat on Android renamed function Update Mobile-Expensify submodule version to 9.1.99-0 Update version to 9.1.99-0 fix: unknow user is displayed if selecting another report Update Mobile-Expensify submodule version to 9.1.98-12 Update version to 9.1.98-12 fix: hovering over the new user avatar does not display email Update src/components/Modal/ReanimatedModal/Container/index.tsx eslint-rule remove empty line add UTs Update central-billing.md Update Mobile-Expensify submodule version to 9.1.98-11 ...

Julesssss · 2025-08-26T21:47:27Z

Ignoring the unrelated failures due to the iOS app build. The help site is looking good!

francoisl

LGTM

docs/articles/travel/event-management/View-Event-As-Employee-or-Guest.md

francoisl · 2025-08-26T21:55:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-08-26T21:57:57Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Julesssss · 2025-08-26T21:58:20Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

No, mobile build failures are unrelated

OSBotify · 2025-08-28T01:39:51Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.0-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T22:18:45Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T23:11:58Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Create Event-Management

83be5b2

Tracking GH - Expensify/Expensify#533839 (comment)

Christinadobrzyn assigned strepanier03 and Christinadobrzyn Aug 24, 2025

Christinadobrzyn requested a review from a team as a code owner August 24, 2025 17:23

melvin-bot bot requested review from Julesssss and VictoriaExpensify and removed request for a team August 24, 2025 17:24

Update redirects.csv

9c02569

Trying to create a new subcategory under Travel. I think I need to make a new path to the folder?

Christinadobrzyn requested review from strepanier03 and removed request for VictoriaExpensify August 24, 2025 17:37

Christinadobrzyn unassigned strepanier03 Aug 24, 2025

Christinadobrzyn and others added 5 commits August 24, 2025 11:39

Rename docs/articles/travel/Event-Management to docs/articles/travel/…

339eb02

…hubs/Event-Management Trying to create a new subcategory named "Event Management" under https://help.expensify.com/travel/hubs/ I didn't add the "hubs" part in the original path so updating here.

Rename Event-Management to Event-Management.md

fdb317f

updating the article name to fix an issue

create subcategory

8cdf9a9

remove redirect

8f56137

move page to correct dir

9b357f7

Christinadobrzyn added 2 commits August 25, 2025 16:59

Create Booking-Travel-for-Event-Attendees.md

9a5b16e

• Tracking - Expensify/Expensify#533839 • Creating a new help article to book travel for even attendees

Create View-Event-As-Employee-or-Guest.md

44bafd6

• Tracking Expensify/Expensify#533839 • Creating new article about how to view an event as an attendee or guest

fix remaining route issue

f04ceed

remove duplicate page

096cf85

strepanier03 added 2 commits August 26, 2025 11:45

Update Booking-Event-Travel.md

297028e

updated the access instructions

Update Travel-Event-Management.md

e2ac960

small tweak

strepanier03 approved these changes Aug 26, 2025

View reviewed changes

Julesssss approved these changes Aug 26, 2025

View reviewed changes

francoisl approved these changes Aug 26, 2025

View reviewed changes

docs/articles/travel/event-management/View-Event-As-Employee-or-Guest.md Show resolved Hide resolved

Julesssss merged commit 384bcf1 into main Aug 26, 2025
15 of 19 checks passed

Julesssss deleted the Christinadobrzyn-patch-4 branch August 26, 2025 21:57

melvin-bot bot added the Emergency label Aug 26, 2025

Julesssss removed the Emergency label Aug 26, 2025

Julesssss mentioned this pull request Aug 26, 2025

[NO QA] Remove stray </div> tag from travel analytics documentation #69308

Merged

50 tasks

OSBotify mentioned this pull request Aug 28, 2025

Deploy Checklist: New Expensify 2025-08-28 #69401

Closed

70 tasks

Create Event-Management #69120

Create Event-Management #69120

Uh oh!

Conversation

Christinadobrzyn commented Aug 24, 2025 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

PR Author Checklist

Uh oh!

melvin-bot bot commented Aug 24, 2025 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Concierge reviewer checklist:

Uh oh!

melvin-bot bot commented Aug 24, 2025

Uh oh!

Christinadobrzyn commented Aug 24, 2025

Uh oh!

Christinadobrzyn commented Aug 24, 2025

Uh oh!

OSBotify commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss commented Aug 25, 2025

Uh oh!

Julesssss commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Christinadobrzyn commented Aug 25, 2025

Uh oh!

Julesssss commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Christinadobrzyn commented Aug 25, 2025

Uh oh!

Julesssss commented Aug 25, 2025

Uh oh!

Christinadobrzyn commented Aug 25, 2025

Uh oh!

Julesssss commented Aug 25, 2025

Uh oh!

Christinadobrzyn commented Aug 25, 2025

Uh oh!

Christinadobrzyn commented Aug 26, 2025

Uh oh!

Julesssss commented Aug 26, 2025

Uh oh!

Christinadobrzyn commented Aug 26, 2025

Uh oh!

Julesssss commented Aug 26, 2025

Uh oh!

strepanier03 commented Aug 26, 2025

Uh oh!

strepanier03 commented Aug 26, 2025

Uh oh!

strepanier03 left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francoisl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

francoisl commented Aug 26, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot bot commented Aug 26, 2025

Uh oh!

Julesssss commented Aug 26, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

Reviewers

Christinadobrzyn commented Aug 24, 2025 •

edited by Julesssss

Loading

melvin-bot bot commented Aug 24, 2025 •

edited by Julesssss

Loading

OSBotify commented Aug 25, 2025 •

edited

Loading

Julesssss commented Aug 25, 2025 •

edited

Loading

Julesssss commented Aug 25, 2025 •

edited

Loading

Julesssss commented Aug 26, 2025 •

edited

Loading