Conversation
|
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
@nlemma Have you checked if this bug can't be reproduced on staging? |
|
@blazejkustra it is not reproducible both on staging and prod. |
I just built it on the newest main and it works as expected: Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-11-03.at.12.23.02.mp4I think the best path forward would be to trigger another adhoc so that you can test it with a fresh main 😄 cc @mountiny |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@nlemma Could you try again with the new build? ☝️ |
|
@blazejkustra the issue is still there. retest.mp4 |
|
I was able to reproduce, will keep you updated |
|
Okay, I built the newest main (without my changes) and I'm also able to reproduce this issue. I think it might be a recent regression @nlemma, but it is not related to this PR. Simulator.Screen.Recording.-.iPhone.15.Plus.-.2025-11-03.at.19.37.21.mov |
|
@blazejkustra Is this the only issue that we have? @nlemma can you try to reproduce in the most recent staging that should include this code |
All issues are either reproducible on main or not at all, so I'd say there are no bugs/issues @mountiny |
|
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
mountiny
left a comment
There was a problem hiding this comment.
@blazejkustra Just one question
|
Let's do it |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Account - Blank page opens when viewing the saved profile pictureVersion Number: 9.2.42-0 PR:69469 Action Performed:
Expected Result:Saved profile picture displayed when viewing photo Actual Result:Blank page opens when viewing the saved profile picture Workaround:Unknown Platforms:Which of our officially supported platforms is this issue occurring on?
Screenshots/VideosBug6995048_1762359010155.ScreenRecording_11-05-2025_11-06-55_1.1.mp4Upwork Automation - Do Not Edit |
|
Seems a bit unrelated, but I'll confirm tomorrow morning |
|
Just verified it, it's not caused by reanimated changes @lanitochka17 and it is already fixed on main 🚀 I can reproduce on this branch/adhoc: reanimated.mp4However on the newest main (with reanimated v4 already merged) it can't be reproduced: main.mp4edit: @jmusial confirmed this issue existed but it's already fixed: #74012 |
|
@blazejkustra, which steps should we follow for testing this PR? |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.45-0 🚀
|
|
@IuliiaHerets As mentioned, there are no specific tests, feel free to check this off and any deploy blocker / issue that will be found might be related to this |
|
@mountiny FWIW the issue is still reproducible in the latest stg. retest.mp4 |
Before this PR was merged I was also able to reproduce on main:
Please raise this issue in the normal process, but I'm positive it's not coming from this migration |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀
|
Explanation of Change
Fixed Issues
$ #69504
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13680
Tests
Perform a general smoke test across the app. Reanimated affects many components. For example:
Offline tests
N/A
QA Steps
Same as tests - full regression testing should cover this PR - feel free to check this off from the checklist.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop