Skip to content

Bump Reanimated to v4#69469

Merged
mountiny merged 59 commits intoExpensify:mainfrom
software-mansion-labs:chore/reanimated-v4
Nov 5, 2025
Merged

Bump Reanimated to v4#69469
mountiny merged 59 commits intoExpensify:mainfrom
software-mansion-labs:chore/reanimated-v4

Conversation

@blazejkustra
Copy link
Contributor

@blazejkustra blazejkustra commented Aug 28, 2025

Explanation of Change

Fixed Issues

$ #69504
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13680

Tests

Perform a general smoke test across the app. Reanimated affects many components. For example:

  • Magic code input and other text inputs
  • Avatar changes
  • Modals and RHP
  • Tooltips

Offline tests

N/A

QA Steps

Same as tests - full regression testing should cover this PR - feel free to check this off from the checklist.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@github-actions
Copy link
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@blazejkustra blazejkustra changed the title Testing reanimated v4 [WIP] Testing reanimated v4 Sep 9, 2025
@blazejkustra blazejkustra marked this pull request as ready for review September 9, 2025 08:09
@blazejkustra blazejkustra requested a review from a team as a code owner September 9, 2025 08:09
@blazejkustra
Copy link
Contributor Author

Report - Keyboard doesn’t appear after tapping “Edit comment”

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.2.37-1 PR:69469 Reproducible in staging?: No Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176686/test-cases/44007893 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: iPhone SE 3rd genration 2022, iOS 26.0.1

Action Performed:

Precondition: User has a workspace.

  1. Open ad hoc app
  2. Create a report
  3. Navigate to the report and send a message.
  4. Tap anywhere to dismiss the keyboard.
  5. Long press the message.
  6. Tap on 'Edit comment'

Expected Result:

When the user taps “Edit comment”, the keyboard should automatically pop up, allowing immediate text input.

Actual Result:

After tapping “Edit comment”, the keyboard does not appear.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6990869_1761960217151.ScreenRecording_10-31-2025_22-12-20_1.MP4
View all open jobs on GitHub

@nlemma Have you checked if this bug can't be reproduced on staging?

@nlemma
Copy link

nlemma commented Nov 3, 2025

@blazejkustra it is not reproducible both on staging and prod.

@blazejkustra
Copy link
Contributor Author

@blazejkustra it is not reproducible both on staging and prod.

I just built it on the newest main and it works as expected:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-11-03.at.12.23.02.mp4

I think the best path forward would be to trigger another adhoc so that you can test it with a fresh main 😄 cc @mountiny

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69469 Mobile-Expensify PR Expensify/Mobile-Expensify#13680.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69469/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/69469/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69469/NewExpensify.dmg https://69469.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@blazejkustra
Copy link
Contributor Author

blazejkustra commented Nov 3, 2025

@nlemma Could you try again with the new build? ☝️

@nlemma
Copy link

nlemma commented Nov 3, 2025

@blazejkustra the issue is still there.

retest.mp4

@blazejkustra
Copy link
Contributor Author

I was able to reproduce, will keep you updated

@blazejkustra
Copy link
Contributor Author

Okay, I built the newest main (without my changes) and I'm also able to reproduce this issue. I think it might be a recent regression @nlemma, but it is not related to this PR.

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2025-11-03.at.19.37.21.mov

@mountiny
Copy link
Contributor

mountiny commented Nov 4, 2025

@blazejkustra Is this the only issue that we have? @nlemma can you try to reproduce in the most recent staging that should include this code

@blazejkustra
Copy link
Contributor Author

blazejkustra commented Nov 5, 2025

@blazejkustra Is this the only issue that we have? @nlemma can you try to reproduce in the most recent staging that should include this code

All issues are either reproducible on main or not at all, so I'd say there are no bugs/issues @mountiny

@melvin-bot
Copy link

melvin-bot bot commented Nov 5, 2025

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blazejkustra Just one question

@blazejkustra
Copy link
Contributor Author

Let's do it :shipit: 🚀

@mountiny mountiny merged commit cdd402b into Expensify:main Nov 5, 2025
37 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Nov 5, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@lanitochka17
Copy link

lanitochka17 commented Nov 5, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Account - Blank page opens when viewing the saved profile picture

Version Number: 9.2.42-0 PR:69469
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch hybrid app or navigate to https://69469.pr-testing.expensify.com/
  2. Sign in with new account
  3. Go to Account >> Profile >> tap avatar >> Upload photo
  4. Select any option (take photo, gallery or file) >> upload and save the picture
  5. Tap the saved profile picture
  6. Tap Edit >> View photo

Expected Result:

Saved profile picture displayed when viewing photo

Actual Result:

Blank page opens when viewing the saved profile picture

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6995048_1762359010155.ScreenRecording_11-05-2025_11-06-55_1.1.mp4
Upwork Automation - Do Not Edit

    @blazejkustra
    Copy link
    Contributor Author

    Seems a bit unrelated, but I'll confirm tomorrow morning

    @blazejkustra
    Copy link
    Contributor Author

    blazejkustra commented Nov 5, 2025

    Just verified it, it's not caused by reanimated changes @lanitochka17 and it is already fixed on main 🚀

    I can reproduce on this branch/adhoc:

    reanimated.mp4

    However on the newest main (with reanimated v4 already merged) it can't be reproduced:

    main.mp4

    edit: @jmusial confirmed this issue existed but it's already fixed: #74012

    @IuliiaHerets
    Copy link

    @blazejkustra, which steps should we follow for testing this PR?

    @OSBotify
    Copy link
    Contributor

    OSBotify commented Nov 5, 2025

    🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.45-0 🚀

    platform result
    🖥 desktop 🖥 success ✅
    🕸 web 🕸 success ✅
    🤖 android 🤖 success ✅
    🍎 iOS 🍎 success ✅

    @mountiny
    Copy link
    Contributor

    mountiny commented Nov 5, 2025

    @IuliiaHerets As mentioned, there are no specific tests, feel free to check this off and any deploy blocker / issue that will be found might be related to this

    @nlemma
    Copy link

    nlemma commented Nov 6, 2025

    @mountiny FWIW the issue is still reproducible in the latest stg.

    retest.mp4

    @blazejkustra
    Copy link
    Contributor Author

    Okay, I built the newest main (without my changes) and I'm also able to reproduce this issue. I think it might be a recent regression @nlemma, but it is not related to this PR.

    Before this PR was merged I was also able to reproduce on main:

    Okay, I built the newest main (without my changes) and I'm also able to reproduce this issue. I think it might be a recent regression @nlemma, but it is not related to this PR.

    Please raise this issue in the normal process, but I'm positive it's not coming from this migration

    @OSBotify
    Copy link
    Contributor

    OSBotify commented Nov 6, 2025

    🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

    platform result
    🖥 desktop 🖥 success ✅
    🕸 web 🕸 success ✅
    🤖 android 🤖 success ✅
    🍎 iOS 🍎 success ✅

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.